Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8bbdcc76e4a84cde92b8dbfd01581d098bd2187d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8bbdcc76e4a84cde92b8dbfd01581d098bd2187d"
 Fixed #19299 -- Fixed Nullification of Foreign Keys To CharFields

 Thanks tunixman for the report and Baptiste Mispelon and
 Shai Berger for reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.78615e3078fe71c68a14da3ef3672651%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by albertyw@…):

 * needs_better_patch:  1 => 0


Comment:

 Made patch pep8.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1ed8014dae284ab034dcc77f5591c786%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 Be sure to uncheck "Patch needs improvement" so the patch appears in the
 review queue. I've left some minor comments and will take another look
 after your update, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.5ff3ff8d53336244832fe8f07de4fa4b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by albertyw@…):

 ping?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.ae3b28da3e2c06a47e101f123e61270c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by albertyw@…):

 I fixed the two things that you commented about
 (interprets_empty_strings_as_nulls and ticket id)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.14df8c7a90f79f68c1cf5358761a0899%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by shai):

 Took a look at the patch, left comments. Appears to me to be almost ready.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.ef32a1931bf0eebf44e12898bd647043%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by albertyw@…):

 * version:  1.4 => master


Comment:

 ping on this?  sorry for nagging.  I'd like to close this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.a60e58ad3babd08c4fe79c8e270fe683%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by albertyw@…):

 * cc: albertyw@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.57112865d1a3577d8803e33f06d4a6c2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by shai):

 * keywords:   => oracle


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.fe1d0ead4387059b13d3164ae530f93f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by albertyw@…):

 From ticket #21194, I have another pull request there that is based on a
 more up to date version of django.
 https://github.com/django/django/pull/1690

 The big difference that I've noticed is that in your patch, you're
 checking `connection.features.interprets_empty_strings_as_nulls` whereas
 I'm checking for `not self.related_field.empty_strings_allowed`.  From my
 interpretation of the rest of the code, the former checks whether the
 database lumps empty string and None together and changes the query to
 None if True, whereas the latter checks whether the foreign keyed field
 accepts empty string and keeps the query at empty string if True.

 They're kind of different problems, but I've added in Tunixman's code into
 my pull request so that it's more complete.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.0a72a1e9b97aa8043156e648ac1b1194%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 Closed #21194 as a duplicate of this - the patch there is slightly
 different and may be useful.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.2d3db9cec255ce619309bf6bb705a4ec%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 Left comments for improvement on the PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.bee6eddebc439f12a6133168c3298bd4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 https://github.com/django/django/pull/1197

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.00e141c1303ebbae2bf404907366dea1%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tunixman):

 And here's the new repo and branch I've cloned for this ticket, including
 all of the changes I've made so far:
 
[https://github.com/tunixman/django/commit/386ef64784a90aafbd8eace51d512dee886030a4]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tunixman):

 I also do believe in the `get_db_prep_save` case we will need to check
 since we're not just returning the value in the case of NULL, but also
 chaining on some additional processing. I've updated the code locally and
 I'm rerunning the tests for it now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tunixman):

 I'm reworking the patch now to include another case of collapsing `''` to
 `None` regardless of the `interprets_empty_strings_as_nulls` feature now,
 and I'll post an update momentarily.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by tunixman):

 I think if Oracle treats them the same way, it will regardless of which we
 return, so maybe we can just return the correct value regardless. The
 databases that make the distinction will, and the ones that don't won't,
 but we'll have the right value coming out of this function regardless. It
 may also be something we don't actually want to check in other places
 either for the same reasons: Oracle collapses both values to NULL, other
 databases make a distinction.

 I'm happy to look for other places this check might happen though, and if
 adding a check to connection.features.interprets_empty_strings_as_nulls is
 actually necessary add that as well.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
-+-
 Reporter:  evan@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 The problem is that Oracle does treat '' and None equivalently. And, this
 shows in some places of Django.

 The fix is likely incorrect as it doesn't check for
 connection.features.interprets_empty_strings_as_nulls.

 I am marking this as accepted. Haven't tested this but the description
 seems correct.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19299: Foreign keys using to_field and having legitimate empty string values fail with NULL errors

[Django]

#19299: Foreign keys using to_field and having legitimate empty string values 
fail
with NULL errors
--+
 Reporter:  evan@…|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+
 If one table references another table with a foreign
 key using a to_field that's a string, and the target column has an empty
 string as a possible value, the ORM would remap it to None, and thus
 NULL, which is not the same, and which breaks the relation.

 
[https://github.com/tunixman/django/commit/45f1da6aea8921c55dfc2f5618d03c800d3fa803
 Minimal test case and fix]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.