Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Julien Phalip ):

 In [changeset:"be5369fd24adfc788e59eaf0363d4d137ded6ef8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="be5369fd24adfc788e59eaf0363d4d137ded6ef8"
 [1.5.x] Fixed #19333 -- Moved compress.py outside of the admin static
 folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and
 Ramiro Morales for the feedback.
 Backport of c9c40bc6bc64e6
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Julien Phalip ):

 In [changeset:"be5369fd24adfc788e59eaf0363d4d137ded6ef8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="be5369fd24adfc788e59eaf0363d4d137ded6ef8"
 [1.5.x] Fixed #19333 -- Moved compress.py outside of the admin static
 folder. Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and
 Ramiro Morales for the feedback.
 Backport of c9c40bc6bc64e6
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Julien Phalip ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c9c40bc6bc64e67365338751e4967d86d0882abf"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c9c40bc6bc64e67365338751e4967d86d0882abf"
 Fixed #19333 -- Moved compress.py outside of the admin static folder.
 Thanks to camilonova, Russell Keith-Magee, Aymeric Augustin and Ramiro
 Morales for the feedback.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by ramiro):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by julien):

 * stage:  Ready for checkin => Accepted


Comment:

 Here's the suggested patch:
 
https://github.com/jphalip/django/commit/62ea2101b6012244aeb502b1435e180c7b97bd94

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by julien):

 Never mind, I got a little confused. The patch already modifies the doc...

 On second thought, I agree with Aymeric in comment:8 to not use
 `getcwd()`, so that the command can be run from anywhere.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
-+-
 Reporter:  camilonova   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by julien):

 * stage:  Accepted => Ready for checkin


Comment:

 I think the patch looks great. The only thing left to update is the doc:
 https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#compressing-javascript

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by ramiro):

 Replying to [comment:8 aaugustin]:
 > After your changes the script works only if you pass file names in
 argument or if you run it from `django/contrib/admin/static/admin/js`.
 Accordign to my understanding of the code it's also the current behavior.
 No changes here.
 >
 > The `here` variable should be called `admin_js_dir`, because that's what
 it really is :)

 If I'm right above, the meaning of this var hasn't changed either it is
 the CWD from which the script is being executed (not the dir where the
 script is located).

 >
 > I suggest renaming that variable and pointing it to
 `os.path.join(os.path.dirname(os.path.dirname(__file__)), 'static',
 'admin', 'js')` (to be tested, I just wrote it in this comment as an
 example).
 >
 > Otherwise, that's the correct fix IMO.

 The only change  this patch introduces is that to ejecute compress.py one
 needs to specify its full path (e.g. `python ../../../bin/compress.py`).
 Remember the intended potential uses of this script are core devs and
 people contributing with the admin app by submitting JS patches.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by aaugustin):

 After your changes the script works only if you pass file names in
 argument or if you run it from `django/contrib/admin/static/admin/js`.

 The `here` variable should be called `admin_js_dir`, because that's what
 it really is :)

 I suggest renaming that variable and pointing it to
 `os.path.join(os.path.dirname(os.path.dirname(__file__)), 'static',
 'admin', 'js')` (to be tested, I just wrote it in this comment as an
 example).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by camilonova):

 Ramiro, looks good and clean. Thanks

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by ramiro):

 * has_patch:  0 => 1


Comment:

 Opinions on proposed fix: https://github.com/ramiro/django/compare/19333
 -move-compress.py are welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by russellm):

 Can anyone explain why the compress.py file is actually in the static
 directory to start with? If the static directory is the directory of stuff
 you want to share, It seems to me that we could avoid this whole problem
 by putting compress.py somewhere else (like a utilities directory -- which
 is what compress.py is anyway)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by aaugustin):

 My personal website offers some Python scripts for download. I'm currently
 storing them as static files. If .py files were ignored by collectstatic
 they wouldn't be served anymore.

 I may be abusing the static files framework :) but it's possible that
 other people are doing the same thing. For this reason, "ignore .py files"
 wasn't my first choice, but I would understand it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by camilonova):

 Ignoring the .py file extensions sounds a better idea overall

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by jezdez):

 Or we could add .py to the list of ignore file extensions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
---+
 Reporter:  camilonova |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * component:  contrib.staticfiles => contrib.admin
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Cleanup/optimization => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Yes, this file isn't designed to be served, it should be moved outside of
 the admin's static directory.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19333: Collect static copies a .py file

[Django]

#19333: Collect static copies a .py file
--+
 Reporter:  camilonova|  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  contrib.staticfiles   |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 When you run a collectstatic the file compress.py gets copied to the
 static directory, and that doesn't seem right.

 I have created a pull request because this was generating PEP8 warnings
 for a project, but looking at the comments i agree this file shouldn't be
 copied.

 https://github.com/django/django/pull/474

 Maybe some can tweak the collectstatic command so it ignores .py files.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.