Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  EvilDMP
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  truncatechars| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f94f466cd3461527fb76a3e8951039a3c2388829"]:
 {{{
 #!CommitTicketReference repository=""
 revision="f94f466cd3461527fb76a3e8951039a3c2388829"
 Fixed #19496 -- Added truncatechars_html filter.

 Thanks esevece for the suggestion and  Nick Sandford and Martin Warne
 for the inital work on the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cc4176dc03afc96869f08c8809f3c0b2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  EvilDMP
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  truncatechars| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by saturn5971):

 * cc: saturn5971 (added)
 * keywords:  truncatchars => truncatechars


Comment:

 Thanks! I updated my pull request in accord with Timo's suggestions.

 [https://github.com/django/django/pull/1689]

 To eliminate redundant code between _html_chars and _html_words, I've
 collapsed them into a single function, _truncate_html. I made the
 requested documentation changes as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3677bf4066167cf39beb0b481145eda9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  EvilDMP
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * version:  1.4 => master
 * easy:  1 => 0


Comment:

 I've left some comments on the PR for improvement.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8f6a1b92bf64b9c3fea82689c666ea01%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  EvilDMP
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by saturn5971):

 truncatechars_html was incorrectly adding the '...' to text that was under
 the truncate length but only by 3 or fewer characters:

 {{{
 >>> truncatechars_html('abcd', 4)
 u'a...'
 }}}

 I've provided an updated patch here, including an addition to the test:

 [https://github.com/django/django/pull/1689]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.673c0c38442d80003b5aef019f00048c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  martmatwarne
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by EvilDMP):

 I have marked this ticket as suitable for a first-time committer attending
 a [https://dont-be-afraid-to-commit.readthedocs.org/ Don't be afraid to
 commit workshop].

 The next planned session will be hosted by
 [http://www.cardiffdevworkshop.com Cardiff Dev Workshop] on Saturday 8th
 June.

 If you want to tackle this ticket before then, or at any time in fact,
 please '''don't''' let the fact that it's assigned to me stop you. Feel
 free to re-assign it to yourself and do whatever you like to it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.47f062e2995e4740adde98d2c77d5b72%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  EvilDMP
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by EvilDMP):

 * owner:  martmatwarne => EvilDMP


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c715ebdc523c275bd5ab316d24d3e839%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  martmatwarne
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by martmatwarne):

 Actually there still appears to be issues when using html with only one
 tag pair in it

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  martmatwarne
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+

Comment (by martmatwarne):

 The above issue should now be fixed. It also appears to have broken
 truncatechars which I've now fixed

 https://github.com/django/django/pull/1126

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  martmatwarne
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by martmatwarne):

 * owner:  slurms => martmatwarne


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  slurms
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by DHessing):

 * needs_better_patch:  0 => 1


Comment:

 {{{
 >>> truncatechars_html('test', 5)
 u't ...'
 }}}
 Should return u'te...'. Truncatewords adds an extra space in
 front of the ellipsis but truncatechars doesn't.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  slurms
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by slurms):

 Used truncatewords_html as a guideline, added docs & tests. All tests pass
 under sqlite. Pull request here: https://github.com/django/django/pull/633

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  slurms
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by slurms):

 * owner:  nobody => slurms
 * status:  new => assigned
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+
 Reporter:  esevece  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  truncatchars | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by russellm):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * easy:  0 => 1
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Sure; we've added truncatedchars; makes sense that there would be a HTML-
 sensitive equivalent.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19496: truncatechars_html

[Django]

#19496: truncatechars_html
-+--
 Reporter:  esevece  |  Owner:  nobody
 Type:  New feature  | Status:  new
Component:  Template system  |Version:  1.4
 Severity:  Normal   |   Keywords:  truncatchars
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+--
 Hi,
 why don't have something like truncatewords_html for chars?
 I don't have experience with the Django's source code, so I don't have a
 patch. But I can try if you want.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.