Re: [Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+
 Reporter:  andrew@…   |Owner:  garanko
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  admin S3 DateTime  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by wraus@…):

 Has there been any progress on this? This is causing some issues for me,
 since I'm looking to switch over to S3. Technically everything still
 works, but there shouldn't be broken images in the admin just because I
 want to use S3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/079.b4ccd5281eacf3fdde813e23df6b45cc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+
 Reporter:  andrew@…   |Owner:  garanko
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  admin S3 DateTime  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by claudep):

 #21395 has been marked as a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/079.e8610c61722997d4a4a1bd57a8315e59%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+
 Reporter:  andrew@…   |Owner:  garanko
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  admin S3 DateTime  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by garanko):

 * status:  new => assigned
 * owner:  nobody => garanko


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+
 Reporter:  andrew@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  admin S3 DateTime  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by aaugustin):

 * type:  Uncategorized => Bug
 * component:  Uncategorized => contrib.admin
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+--
 Reporter:  andrew@…   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  admin S3 DateTime  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by apollo13):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Old description:

> contrib/admin/templates/admin/base.html contains the line:
> window.__admin_media_prefix__ = "{% filter
> escapejs %}{% static "admin/" %}{% endfilter %}";
>
> The __admin_media_prefix__ is used in
> contrib/admin/static/admin/js/admin/DateTimeShortcuts.js to form URLs by
> concatenation:
> DateTimeShortcuts.admin_media_prefix + 'img/icon_clock.gif'
>
> This causes a problem with certain storage backends (such as S3 Boto)
> which include authentication digests as part of the URL. For instance,
> when using the S3 Boto backend, my admin renders the following line:
> window.__admin_media_prefix__ =
> "https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQ";;
>
> Which, when concatenated with the fixed string generates the invalid URL:
> https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQimg/icon_clock.gif
>
> I suspect that the assumption the DateTime widget is relying on ({%
> static a+b %} should be equivelant to {% static a %}b) is invalid, and it
> should be using a more robust method to determine the static URL of its
> resources. The DateTime widget appears to be the only element depending
> on __admin_media_prefix__, and thus the only one to fail when switching
> to a backend that doesn't support its assumption.

New description:

 contrib/admin/templates/admin/base.html contains the line:
 {{{
 window.__admin_media_prefix__ = "{% filter
 escapejs %}{% static "admin/" %}{% endfilter %}";
 }}}

 The !__admin_media_prefix!__ is used in
 contrib/admin/static/admin/js/admin/DateTimeShortcuts.js to form URLs by
 concatenation:
 DateTimeShortcuts.admin_media_prefix + 'img/icon_clock.gif'

 This causes a problem with certain storage backends (such as S3 Boto)
 which include authentication digests as part of the URL. For instance,
 when using the S3 Boto backend, my admin renders the following line:
 {{{
 window.__admin_media_prefix__ =
 
"https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQ";;
 }}}

 Which, when concatenated with the fixed string generates the invalid URL:
 
https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQimg/icon_clock.gif

 I suspect that the assumption the DateTime widget is relying on ({% static
 a+b %} should be equivelant to {% static a %}b) is invalid, and it should
 be using a more robust method to determine the static URL of its
 resources. The DateTime widget appears to be the only element depending on
 !__admin_media_prefix!__, and thus the only one to fail when switching to
 a backend that doesn't support its assumption.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19538: __admin_media_prefix__ in admin templates

[Django]

#19538: __admin_media_prefix__ in admin templates
---+---
 Reporter:  andrew@…   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.4
 Severity:  Normal |   Keywords:  admin S3 DateTime
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+---
 contrib/admin/templates/admin/base.html contains the line:
 window.__admin_media_prefix__ = "{% filter
 escapejs %}{% static "admin/" %}{% endfilter %}";

 The __admin_media_prefix__ is used in
 contrib/admin/static/admin/js/admin/DateTimeShortcuts.js to form URLs by
 concatenation:
 DateTimeShortcuts.admin_media_prefix + 'img/icon_clock.gif'

 This causes a problem with certain storage backends (such as S3 Boto)
 which include authentication digests as part of the URL. For instance,
 when using the S3 Boto backend, my admin renders the following line:
 window.__admin_media_prefix__ =
 
"https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQ";;

 Which, when concatenated with the fixed string generates the invalid URL:
 
https://oca3\u002Dqa.s3.amazonaws.com/admin?Signature\u003DXIt%2FCc9wPWjaw%2F3ITNjkYE3bc%2FI%3D\u0026Expires\u003D1356844210\u0026AWSAccessKeyId\u003DAKIAIGREZ7J53KZ23QKQimg/icon_clock.gif

 I suspect that the assumption the DateTime widget is relying on ({% static
 a+b %} should be equivelant to {% static a %}b) is invalid, and it should
 be using a more robust method to determine the static URL of its
 resources. The DateTime widget appears to be the only element depending on
 __admin_media_prefix__, and thus the only one to fail when switching to a
 backend that doesn't support its assumption.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.