Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.4
  Internationalization   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by Ihor Kaharlichenko ):

 Extracted as a separate issue: #21963.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.e967897f719e3d39f4100e2dfe003474%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.4
  Internationalization   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by timo):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 As noted in the previous commit message: "Behavior of {% comment %}...{%
 endcomment %}tags remains unchanged." I think that means inline
 translations aren't supported for that tag.

 I'm not sure if this is something that could or should be changed, or
 rather if the limitation should simplify be documented if it's not
 already. In either case, a new ticket is better than reopening this old
 one, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.a3359152781e8cfd0067e42dd28d7145%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Ihor Kaharlichenko ):

 * cc: madkinder@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.f761128085086e9ad8a7665251271159%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Ihor Kaharlichenko ):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Unfortunately the bug seems to be fixed partially. Here's the test case:

 Template:
 {{{
 #!django
 {% load i18n %}

 {# Translators: Abbreviated month name #}
 {% trans "Jan" %}

 {# Translators: Abbreviated month name #}{% trans "Feb" %}

 {% comment %}Translators: Abbreviated month name{% endcomment %}{% trans
 "Mar" %}

 {# Translators: Abbreviated month name #} {% trans "Apr" %}

 {% comment %}Translators: Abbreviated month name{% endcomment %} {% trans
 "May" %}

 {# Translators: Abbreviated month name #}
 {% trans "Jun" %}

 {# Translators: Abbreviated month name #}

 {% trans "Jul" %}

 {% comment %}Translators: Abbreviated month name{% endcomment %}

 {% trans "Aug" %}
 }}}

 The extraction session:

 {{{
 $ ./manage.py version
 1.6.1
 $ ./manage.py makemessages -l ru -i venv
 .../trans_real.py:585: TranslatorCommentWarning: The translator-targeted
 comment 'Translators: Abbreviated month name' (file
 app1/templates/i18n_test.html, line 6) was ignored, because it wasn't the
 last item on the line.
   warnings.warn(warn_msg, TranslatorCommentWarning)

 .../trans_real.py:585: TranslatorCommentWarning: The translator-targeted
 comment 'Translators: Abbreviated month name' (file
 app1/templates/i18n_test.html, line 10) was ignored, because it wasn't the
 last item on the line.
   warnings.warn(warn_msg, TranslatorCommentWarning)

 processing locale ru
 }}}

 Resulting po file:
 {{{
 #!po
 #. Translators: Abbreviated month name
 #: app1/templates/i18n_test.html:4
 msgid "Jan"
 msgstr ""

 #: app1/templates/i18n_test.html:6
 msgid "Feb"
 msgstr ""

 #. Translators: Abbreviated month name gettext(u'Mar')
 #: app1/templates/i18n_test.html:10
 msgid "Apr"
 msgstr ""

 #. Translators: Abbreviated month name  gettext(u'May')
 #. Translators: Abbreviated month name
 #: app1/templates/i18n_test.html:15
 msgid "Jun"
 msgstr ""

 #. Translators: Abbreviated month name
 #: app1/templates/i18n_test.html:19
 msgid "Jul"
 msgstr ""

 #. Translators: Abbreviated month name
 #: app1/templates/i18n_test.html:23
 msgid "Aug"
 msgstr ""
 }}}

 The problems:

 * translations for "Mar" and "May" were completely skipped
 * there was a warning for single-tag comments (for Feb and Apr), but not
 for block comments (for Mar and May), which is inconsistent
 * Apr and Jun got wrong comments

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.8afc4e57fc4364481525cb988d2fea4c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.4
  Internationalization   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by Ramiro Morales ):

 In [changeset:"4290cc1d6e3cbbb77d4098e15bd4db6c65ee904a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4290cc1d6e3cbbb77d4098e15bd4db6c65ee904a"
 [1.6.x] Made test for issue 19552 compatible with Windows.

 Take in account platform path separator. Refs #19552.

 651bed0918 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.fff88faf6f212e8e9def89ec32825116%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.4
  Internationalization   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by Ramiro Morales ):

 In [changeset:"651bed09182cc7f2fadc54026924fd5815fc47f1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="651bed09182cc7f2fadc54026924fd5815fc47f1"
 Made test for issue 19552 compatible with Windows.

 Take in account platform path separator. Refs #19552.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/083.9b8d22a1726d80991b776013a3a0595e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.4
  Internationalization   |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Ramiro Morales ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"47ddd6a4082d55d8856b7e6beac553485dd627f7"]:
 {{{
 #!CommitTicketReference repository=""
 revision="47ddd6a4082d55d8856b7e6beac553485dd627f7"
 Fixed #19552 -- Enhanced makemessages handling of ``{# #}``-style template
 comments.

 They are simply ignored now. This allows for a more correct behavior when
 they are placed before translatable constructs on the same line.

 Previously, the latter were wrongly ignored because the former were
 preserved when converting template code to the internal Python-syntax
 form later fed to xgettext but Python has no ``/* ... */``-style
 comments.

 Also, special comments directed to translators are now only taken in
 account when they are located at the end of a line. e.g.::

   {# Translators: ignored #}{% trans "Literal A" %}{# Translators: valid,
 associated with "Literal B" below #}
   {% trans "Literal B" %}

 Behavior of ``{% comment %}...{% endcomment %}``tags remains unchanged.

 Thanks juneih at redpill-linpro dot com for the report and Claude for
 his work on the issue.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by ramiro):

 Hopefully finished work, in PR form:

 https://github.com/django/django/pull/677

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by ramiro):

 New proposed fix:

 https://github.com/ramiro/django/compare/57d439e...ramiro:ticket-19552

 Compared with item 3 of the previous comment proposal, this implementation
 doesn't disallow translator comments in the same line with other tokens,
 but ignores/warns if they aren't located at the end.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by ramiro):

 Replying to [comment:4 ramiro]:

 > Maybe something like this? (needs validation of the idea, polishing and
 tests): http://dpaste.de/hJepF/
 Ignore that patch. Moving comments to the end of the line helps in the
 general case but breaks association of translator comments.

 I believe we should ignore all the comments. 2) Get any no-comment tags
 that might be located in the same line as a comment one to be properly
 recognized and extracted and 3) Start requiring translator comments to be
 on a line by thrir own by ignoring those that don't comply just like as in
 1 but possibly making makemessages emit a warning. I have some code along
 these lines, will upload it tomorrow.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by ramiro):

 Replying to [comment:3 claudep]:
 > I realized that my patch (with the OP proposal) has one major drawback,
 it doesn't preserve the line numbers. We've made considerable efforts in
 templatize to preserve line numbers, so as line numbers in po files match
 line numbers in the source file. For comments which are not translator
 comments, we could replace `#` by `''' '''`, but this doesn't work for
 translator comments. Ramiro, any idea?

 Maybe something like this? (needs validation of the idea, polishing and
 tests): http://dpaste.de/hJepF/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by claudep):

 * stage:  Ready for checkin => Accepted


Comment:

 I realized that my patch (with the OP proposal) has one major drawback, it
 doesn't preserve the line numbers. We've made considerable efforts in
 templatize to preserve line numbers, so as line numbers in po files match
 line numbers in the source file. For comments which are not translator
 comments, we could replace `#` by `''' '''`, but this doesn't work for
 translator comments. Ramiro, any idea?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  makemessages,|  checkin
  template, gettext, xgettext|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by ramiro):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.4
  Internationalization   |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages,|  Needs documentation:  0
  template, gettext, xgettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by claudep):

 * needs_better_patch:   => 0
 * component:  Core (Management commands) => Internationalization
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19552: makemessages ignores translations in templates with inline comment tags

[Django]

#19552: makemessages ignores translations in templates with inline comment tags
-+-
 Reporter:  juneih@… |  Owner:  nobody
 Type:  Bug  | Status:  new
Component:  Core (Management |Version:  1.4
  commands)  |   Keywords:  makemessages, template,
 Severity:  Normal   |  gettext, xgettext
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+-
 I'm using the management command makemessages to create the po-file for
 translations in my Django project. I'm having trouble with translations in
 templates being ignored when they contain in-line comments. Example:


 {{{

 {# Nice comment #} {%trans "Translate me" %}

 }}}

 The string 'Translate me' is not added to the po-file. I've traced the
 reason for this to the templatize method in trans_real.py. At the bottom
 of the method you'll find the following lines:

 When running the makemessages management command
 {{{
  elif t.token_type == TOKEN_COMMENT:
 out.write(' # %s' % t.contents)
 }}}

 It appears that the comment is not blanked out, but kept and passed on to
 xgettext. The input for xgettext with the previous example will be:

 {{{
 # nice comment gettext('Translate me')
 }}}

 Which means xgettext interprets the entire line as a comment. I'm not
 really sure why gettext would need the comment in the first place, but the
 fix for me has been to just add a new line after the string, like so:

 {{{
  elif t.token_type == TOKEN_COMMENT:
 out.write(' # %s\n' % t.contents)
 }}}

 Now the input for xgettext is:

 {{{
 # nice comment
 gettext('Translate me')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.