Re: [Django] #19577: admin doc may encourage bad practices

2013-02-08 Thread Django 
#19577: admin doc may encourage bad practices
-+-
 Reporter:  foo@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"42fcfcaa529dac1fe3066797d7e4ab7aa6f6cdf3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="42fcfcaa529dac1fe3066797d7e4ab7aa6f6cdf3"
 [1.5.x] Fixed #19577 - Added HTML escaping to admin examples.

 Thanks foo@ for the report and Florian Apolloner for the review.

 Backport of eafc036476 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-25 Thread Django 
#19577: admin doc may encourage bad practices
-+-
 Reporter:  foo@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"42fcfcaa529dac1fe3066797d7e4ab7aa6f6cdf3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="42fcfcaa529dac1fe3066797d7e4ab7aa6f6cdf3"
 [1.5.x] Fixed #19577 - Added HTML escaping to admin examples.

 Thanks foo@ for the report and Florian Apolloner for the review.

 Backport of eafc036476 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-25 Thread Django 
#19577: admin doc may encourage bad practices
-+-
 Reporter:  foo@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"eafc0364764ba12babd76194d8e1f78b876471ec"]:
 {{{
 #!CommitTicketReference repository=""
 revision="eafc0364764ba12babd76194d8e1f78b876471ec"
 Fixed #19577 - Added HTML escaping to admin examples.

 Thanks foo@ for the report and Florian Apolloner for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-25 Thread Django 
#19577: admin doc may encourage bad practices
-+-
 Reporter:  foo@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by apollo13):

 * stage:  Accepted => Ready for checkin


Comment:

 Thanks, looks good now!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-24 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  1 => 0


Comment:

 Thanks for taking a look. I don't think the example is meant to assume
 that get_full_address() returns a safe string, but maybe I interpreted it
 differently. I added a comment to try to explain what I thought the intent
 of the example was in addition to the other fixes you mentioned (plus
 documenting format_html_join).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-24 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by apollo13):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-24 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by apollo13):

 The indendation is wrong at
 https://code.djangoproject.com/attachment/ticket/19577/19577.diff#L45 and
 you don't need format_html at
 https://code.djangoproject.com/attachment/ticket/19577/19577.diff#L63
 (there is no allow_tags=True) -- otherwise it looks good to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-18 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19577: admin doc may encourage bad practices

2013-01-08 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by apollo13):

 * cc: apollo13 (added)
 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Yes, this should definitely use format_html
 
(https://docs.djangoproject.com/en/dev/ref/utils/#django.utils.html.format_html).
 Do you think you can wipe up a patch for that?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19577: admin doc may encourage bad practices

2013-01-08 Thread Django 
#19577: admin doc may encourage bad practices
---+
 Reporter:  foo@…  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Documentation  |Version:  1.4
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 On https://docs.djangoproject.com/en/1.4/ref/contrib/admin/ two places
 example code demonstrate allow_tags=True in order to return HTML fragments
 containing  tags.  Inside these tags data (self.first_name and
 self.last_name) is not escaped/quoted.

 As such example code often is copy/pasted it probably should reflect "best
 practices"?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.