Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"9e746c13e81241fbf1ae64ec118edaa491790046"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9e746c13e81241fbf1ae64ec118edaa491790046"
 Stopped stripping microseconds with MySQL backend

 Refs #19716.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.2992dc808a9fb957e3039fab514c49f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"22da5f88173917bcf8a652dce84f382c9202"]:
 {{{
 #!CommitTicketReference repository=""
 revision="22da5f88173917bcf8a652dce84f382c9202"
 Fixed #19716 -- Added support for microseconds with MySQL 5.6.4 and up

 Thanks e...@cederstrand.dk for the report and Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.b559635c01e8f033f5a3803a72d5c3af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.a0c78bbdb296fd5b78a3ac5341575b82%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:  1 => 0


Comment:

 Patch updated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.1bb1f808715d0f6141858704fb215da1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 We could bump it, but not to 1.2.5. Even Debian unstable has still 1.2.3,
 which might mean that there are other issues with more recent versions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.e8959711a838163ddc0fae988bd79eff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timgraham):

 Would it be unreasonable to bump the minimum version of MySQLdb we
 support? It seems we currently require 1.2.1 or later
 (django.db.backends.mysql.base). I assume the only reason to use an older
 version is if you want to use the global packages provided by your OS
 instead of virtualenv, etc.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.6e562d95ca2f54c4c2103d916854feff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 Reference to MySQLdb bug: https://github.com/farcepest/MySQLdb1/issues/24

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.0fb118ec1f368557969acc9f8fc8b947%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:  0 => 1


Comment:

 I have a good news and a bad news:
 - the good news is that I found and fixed the source of the test failures
 mentioned above (in `adapt_datetime_with_timezone_support`).
 - the bad news is that we need a very recent version of MySQLdb (1.2.5
 released on January 2 2014) to have a bug fixed when retrieving datetime
 value with microseconds from the database, unless we obtain `None`. The
 patch will need to check and document that limitation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.10d0ca0b90c9a71789d80ad9c65a1845%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_tests:  1 => 0


Comment:

 The current state of the patch seems to generate two failures in the test
 suite (https://github.com/django/django/pull/3049#issuecomment-52261704).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.0c73a1515019f3af16726763f19ba9e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 After seeing that the tests were successful with the first commit, I
 pushed a second commit which should really add microseconds support with
 MySQL 5.6.4 and up. However, it is completely untested yet (and the CI
 server has still MySQL 5.5).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.38a066c94fc6870427a23f993e9b6beb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 As for my patch, I think that the fact that the current test suite pass
 (I'll make a PR to test this) should be sufficient.
 Of course, when we really support microseconds, the
 `supports_microsecond_precision` db feature will have to depend on the
 MySQL version.
 PR: https://github.com/django/django/pull/3049

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.2fe229576b09fd8bf45e0bb580f20375%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.d7d0f58b58443b7957b028a431fa8a4d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 Attached a proposal, which is only the first step towards the resolution
 of this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.9b1166f2fd001e49a4165fc64a952189%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.fdb55dbea0a61bc8db9ccd7a3140881f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by russ.blaisdell@…):

 Here is the update to mysqldb/times.py
 54c54,59
 < return datetime(*[ int(x) for x in d.split('-')+t.split(':') ])
 ---
 > if '.' in t:
 > t, ms = t.split('.',1)
 > ms = ms.ljust(6, '0')
 > else:
 > ms = 0
 > return datetime(*[ int(x) for x in
 d.split('-')+t.split(':')+[ms] ])
 63,65c68,75
 < h, m, s = int(h), int(m), float(s)
 < td = timedelta(hours=abs(h), minutes=m, seconds=int(s),
  if '.' in s:
 > s, ms = s.split('.')
 > ms = ms.ljust(6, '0')
 > else:
 > ms = 0
 > h, m, s, ms = int(h), int(m), int(s), int(ms)
 > td = timedelta(hours=abs(h), minutes=m, seconds=s,
 >microseconds=ms)
 77,79c87,94
 < h, m, s = int(h), int(m), float(s)
 < return time(hour=h, minute=m, second=int(s),
 < microsecond=int(math.modf(s)[0] * 100))
 ---
 > if '.' in s:
 > s, ms = s.split('.')
 > ms = ms.ljust(6, '0')
 > else:
 > ms = 0
 > h, m, s, ms = int(h), int(m), int(s), int(ms)
 > return time(hour=h, minute=m, second=s,
 > microsecond=ms)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.84d7d45b03f3b2d76f5f91a7caae99a0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by anonymous):

 I have been running with this for awhile. For 1.6.1 this is the diff for
 db/backends/mysql/base.py
 162c162
 < supports_microsecond_precision = True
 ---
 > supports_microsecond_precision = False
 352c352
 < return six.text_type(value)
 ---
 > return six.text_type(value.replace(microsecond=0))
 363c363
 < return six.text_type(value)
 ---
 > return six.text_type(value.replace(microsecond=0))
 368c368
 < return [first, second]
 ---
 > return [first.replace(microsecond=0),
 second.replace(microsecond=0)]


 I must add that I also updated mysqldb 1.2.4 to handle microseconds at the
 same time.  Both have been working without issue ever since.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.83d4e95c7618b25d59d2bc882420381c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by allcaps):

 I tested as Erik but on MySQL 5.4.6 and had the same. The datetime with
 fractions get stored in db (column datatime(6)) but get NoneType returned.

 {{{
 In [5]: get_object_or_404(MyModel, pk=1).dt_millis.__class__
 Out[5]: NoneType #This should be datetime.datetime
 }}}

 I created a custom model to create the datetime([1-6]) column. This way a
 developer has a choice on what type of datetime to use:

 {{{
 class DateTimeFractionField(models.DateTimeField):
 description = "Datetimefield with fraction second. Requires MySQL
 5.4.3 or greater"

 def __init__(self, precision, *args, **kwargs):
 self.precision = precision
 super(DateTimeFractionField, self).__init__(*args, **kwargs)

 def db_type(self, connection):
 return 'DATETIME(%s)' % self.precision

 class MyModel(models.Model):
 dt_micros  = DateTimeFractionField(6)
 }}}

 The current backend 'strips' the milliseconds with
 .replace(microsecond=0). So microseconds aren't gone. They are 0. The
 MySQL docs state that < MySQL 5.4.3 discards any fractional part.  So I
 assume that removing all .replace(microseconds=0) from the MySQL backend
 is a good beginning. Doing so let's MySQL decide if the value's get stored
 or not.

 I also tried to store datetime with fractions in Postgresql. The buildin
 datetimefield works. But I needed to modify the formfield clean method to
 submit and admin widget to display the fracrions in the admin.

 This is my first contribution. I'd like to collaborate to get this ticket
 closer to fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.b5fb7b30bb1370c4869fdb76b3007b7d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 Sure, it's a three line change if you disregard tests, documentations and
 backwards compatibility -- three concepts that are highly regarded in this
 community :)

 If we include this change in a future version of Django, what's going to
 happen:
 - for developers running an older version of MySQL?
 - for developers upgrading from an older version of Django?

 Do we need different code paths depending on the version of MySQL?

 What are the consequences for backwards compatibility?

 Here's a theoretical example. Let's assume an database column defaulting
 to `now()`. Right now, this column contains values without sub-second
 precision. These values can safely be fed into a webservice that doesn't
 support sub-second precision. If we make this change, suddenly, this will
 fail.

 To move this ticket forwards, you need to identify the consequences and
 propose a way to deal with them, either with code or with docs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.c3819078b8b58b1be96cbbed977ed4be%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by sarang (@…):

 This is a 3 line change. Hope Django developers include it.

 In "db/backends/mysql/base.py"
 function "def value_to_db_datetime(self, value)"

 Change from:
 return six.text_type(value.replace(microseconds=0))
 to:
 return six.text_type(value)

 In "db/backends/mysql/base.py"
 function "def value_to_db_time(self, value)"

 Change from:
 return six.text_type(value.replace(microseconds=0))
 to:
 return six.text_type(value)


 In "db/backends/mysql/creation.py"
 In definition of "data_types"

 Change from:
 'DateTimeField': 'datetime',
 to:
 'DateTimeField': 'datetime(6)',

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.9160635ea64cc45251e97e3555f9b294%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
-+-
 Reporter:  erik@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by carljm):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19716: Support microsecond precision in MySQL ORM DateTimeField

[Django]

#19716: Support microsecond precision in MySQL ORM DateTimeField
--+
 Reporter:  erik@…|  Owner:  nobody
 Type:  New feature   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 MariaDB, and MySQL 5.6, support sub-second precision in DATETIME fields
 (see https://kb.askmonty.org/en/microseconds-in-mariadb/).

 Ideally, the ORM should support storing and retrieving datetime() with
 microsecond precision and creating DATETIME(n) columns.

 I tested a models.DateTimeField() field backed by DATETIME(3) on MariaDB,
 but unfortunately the field on the Django model instance is always None
 even though the database contains a valid date.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.