Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
---+
 Reporter:  void   |Owner:  gchp
 Type:  New feature|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by void):

 * status:  assigned => closed
 * resolution:   => wontfix


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.f2a72c9a2f2df5ec8b4c88479ad3f59f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
---+
 Reporter:  void   |Owner:  gchp
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by void):

 The initial goal of this ticket was to deal with issue that emerged while
 working on the #18767.
 That is, translation.override was not able to change thread-local state of
 `LiveServerThread`, and it rendered everything in one language.
 #18767 ticket is fixed now and thread-local issue resolved by introducing
 settings_changed signal and its receivers, in particular to the
 `trans_real._active = threading.local()` line in `django.test.signals`.

 Therefore, I think it's safe to close this ticket as wontfix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a88d9131ca4468496fcb5c87cfff86a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
---+
 Reporter:  void   |Owner:  gchp
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by gchp):

 * owner:   => gchp
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.30bac2d557deb3949d94bfe87dfb76e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
---+
 Reporter:  void   |Owner:
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by unaizalakain):

 * status:  assigned => new
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * owner:  unaizalakain =>


Comment:

 Then more than an improvement, I think a totally different patch is
 needed, although I don't understand the need for a language thread-local
 in a testing environment that doesn't support multithreading.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.cf8e4dfcd12eec7162eaf844e54098bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 If the patch makes apollo13 run, I guess it needs improvement. :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0904ebf872405c46ff60d28f6b808cb2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by unaizalakain):

 Well, it surely isn't the most elegant way of doing it but defining some
 special functions for changing the active language when those functions
 already exist doesn't seem right to me either.

 I think disabling the language thread-local in the testing environment
 isn't too bad, after all, it's not needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b5db82d4798e761b8775a3bd7f8a6223%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by apollo13):

 * cc: apollo13 (added)


Comment:

 I'd very much prefer a method which just sets the active language in the
 other thread as suggested by julien. While the PR might work, it makes me
 run away in fear.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0864233479c33b5d44112b23e86bab8b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by unaizalakain):

 The ``set_language`` view could be used to change the live test server
 thread language but that would mean adding some kind of new method to the
 test case and the inability to use the already defined methods
 (`django.utils.translation.override`, `django.utils.translation.activate`,
 etc).

 Instead, the PR opts for making the thread local that holds the current
 active language a non-local. This is done in the two threads so suddenly
 one thread is capable of accessing the other one's active language. This
 is afterwards reverted to thread locals again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.bf2a209c8cb36e068cd7ee5c1b9f6589%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by unaizalakain):

 * has_patch:  0 => 1


Comment:

 PR sent: https://github.com/django/django/pull/2021

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.cadb3dcd8f4af6e3c54ba8193c58a111%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19869: Make changing the active language inside `LiveTestServerCase` possible (was: Add ability to restart LiveServerThread inside a test method)

[Django]

#19869: Make changing the active language inside `LiveTestServerCase` possible
-+-
 Reporter:  void |Owner:
 Type:  New feature  |  unaizalakain
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  0| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3edb10f289d4c576ac86d99e7e7f31e8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.