Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
-+-
 Reporter:  l3on |Owner:  bmispelon
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"844fbc85c1d419ed7ecbb7208bd392c1770ea72d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="844fbc85c1d419ed7ecbb7208bd392c1770ea72d"
 Fixed #19874: Apply id attribute to the outer  of
 CheckboxSelectMultiple
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
-+-
 Reporter:  l3on |Owner:  bmispelon
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
-+-
 Reporter:  l3on |Owner:  bmispelon
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by bmispelon):

 * status:  new => assigned
 * cc: bmispelon@… (added)
 * needs_tests:  1 => 0
 * version:   => master
 * owner:  nobody => bmispelon
 * needs_docs:  1 => 0
 * has_patch:  1 => 0


Comment:

 I upgraded the patch to use `format_html` instead of string interpolation.

 I also fixed the test suite and added some documentation of the feature.

 The pull request can be found there:
 https://github.com/django/django/pull/999

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
--+
 Reporter:  l3on  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by oinopion):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
--+
 Reporter:  l3on  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by carljm):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Seems reasonable to me; the id is currently only used to construct per-
 option numbered IDs, it makes sense that the base ID would be applied to
 the container.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
---+--
 Reporter:  l3on   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Forms  |  Version:
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * needs_better_patch:   => 0
 * component:  Documentation => Forms
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19874: Add id to element in CheckboxSelectMultiple

[Django]

#19874: Add id to  element in CheckboxSelectMultiple
---+
 Reporter:  l3on   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+
 Please,

 consider to add an ID to  element in CheckboxSelectMultiple.

 The patch attached fixes the problem (it's based on git/develop branch).

 Thanks in advance!

 Leo.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.