Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2021-07-27 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Per [https://groups.google.com/g/django-developers/c/GlYM25fdRnA mailing
 list discussion] we cannot envision making behavior changes here because
 we neither want to remove the blankable-and-not-nullable-and-inject-data-
 on-save idiom nor silently cast data in ways a developer might not expect.
 I collected some comments about the blank=True, null=False idiom on #4
 and will reframe it as a documentation task.

 > That said, this is a way for someone to shoot themselves in the foot,
 and the error message could be cleaner. One possible way forward would be
 for Field.get_prep_value to check if the field has empty_strings_allowed =
 False, and if so and if the value is an empty string, to throw some type
 of error with a more meaningful error message. That said, it's not
 strictly necessary, as someone will likely find this very thread from the
 current error message, and realize what the problem is.

 I think the current error (assuming it's in a similar form today to the
 original `invalid literal for int(): ''`) points out that `''` is not an
 int, so in my opinion, I wouldn't add a particularized exception for folks
 using any single particular poor combination of form and model fields.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2f7e9893c4d2dcb0bca3f5f8ea93a6ac%40djangoproject.com.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2021-07-19 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  Jacob
 |  Walls
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  Amine Zyad => Jacob Walls
 * needs_better_patch:  1 => 0


Comment:

 It seems curious that under the status quo, where `empty_strings_allowed`
 is False, that we would skip model validation even at the moment we are
 holding an empty string (as opposed to None or any of the other values in
 `empty_values`). [https://github.com/django/django/pull/14666 PR to run
 model validation in this case.]

 However, we could also treat as a duplicate of #4 and add either
 [Simon's friendly guardrail
 https://code.djangoproject.com/ticket/4#comment:5] for folks without a
 solution for MyModel.clean() or just wontfix.

 Happy to hear advice or to be nudged toward the mailing list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1e7dbe2c2a0bf79c40e62a6332164e0b%40djangoproject.com.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2018-08-09 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  Amine
 |  Zyad
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Brenton Partridge):

 For others who might come across this error, check to make sure that you
 (and your colleagues' code) are using a forms.IntegerField and not a
 forms.CharField (or similar). forms.IntegerField, if left blank by the
 submitter, will send None to the model field, but forms.CharField will
 send an empty string which triggers OP's error.

 That said, this is a way for someone to shoot themselves in the foot, and
 the error message could be cleaner. One possible way forward would be for
 `Field.get_prep_value` to check if the field has `empty_strings_allowed =
 False`, and if so and if the value is an empty string, to throw some type
 of error with a more meaningful error message. That said, it's not
 strictly necessary, as someone will likely find this very thread from the
 current error message, and realize what the problem is.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.79904b9b2cc5f0004f3be1df75e43df5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2017-09-14 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  Amine
 |  Zyad
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Zach):

 * cc: Zach (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.023e8311a868587ff3778ac601e1edca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2014-08-12 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by akaariai):

 The problem here likely comes from HTML form submissions: there "" is the
 natural None value for all fields that do not accept "" directly as a
 value. My interpretation is that empty_values should be those values that
 should be converted to None in validation. For IntegerField this should be
 None and "", for CharField just None (as "" is a valid value directly).

 I am not sure if we can change the logic so that all empty_values are
 converted to None without breaking backwards compatibility badly.

 I am not sure why we skip field validation for empty_values. Backwards
 compatibility?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e7c711c14ae2c89a178044cc936f383%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-09-18 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by charettes):

 > The developer is responsible for making sure they have a valid value."
 This is odd to me -- the developer is responsible for making sure that
 fields have a valid value, but where would that appropriately be done?

 I think a valid use case is to use the `clean()` method of the model
 associated with the field to provide such a value.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.707d9783d7fe67b92d26aec624084b0f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-09-17 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Adam Easterling ):

 After thinking about this issue at some length myself, I agree with
 loic84: The real problem is that Model doesn't call a field's clean method
 in the case that the value is "empty." That logic doesn't seem to belong
 to the Model.

 To me, it seems that this logic should be moved to the field class, so
 each field could decide what's a valid "empty value" and what isn't.

 Furthermore, there's a comment near the aformentioned Model logic that
 says, "Skip validation for empty fields with blank=True. The developer is
 responsible for making sure they have a valid value." This is odd to me --
 the developer is responsible for making sure that fields have a valid
 value, but where would that appropriately be done? You can't add a
 validator to the field, as clean() isn't run for that field. Any remaining
 solutions seem rather hacky.

 My own solution was to just override all number fields and change how they
 work, but I'm not super proud of it. Here's an example for Integers:

 {{{
 class FixedIntegerMixin(object):
 '''
 If you attempt to save an int field with a blank string, Django
 doesn't
 convert that to a None object, which is what the db expects.

 Also, if the value is "blank" according to Django (see EMPTY_VALUES
 found
 at django.core.validators) it won't call to_python for that field (see
 full_clean at django.db.models.base).

 This means that we have to override get_prep_value itself.
 '''
 def get_prep_value(self, value):
 if value is None:
 return None
 if value == "":
 return None
 return int(value)


 class IntegerField(FixedIntegerMixin, IntegerField_django):
 pass


 class SmallIntegerField(FixedIntegerMixin, SmallIntegerField_django):
 pass


 class PositiveIntegerField(FixedIntegerMixin,
 PositiveIntegerField_django):
 pass


 class PositiveSmallIntegerField(FixedIntegerMixin,
 PositiveSmallIntegerField_django):
 pass
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.52b49cfaa74efee6021db742db2a1507%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-06-19 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by loic84):

 [4cccb85e] was indeed designed with custom fields in mind, but using it is
 the right way of addressing this issue.

 Ideally each field would define exactly what values it considers empty
 rather than using the historical blanket `EMPTY_VALUES = (None, '', [],
 (), {})`.

 After all `{}` would hardly make sense for a numerical field, yet it would
 pass validation.

 For the record, there is a tricky issue where a value of `None` when
 `is_null=False` would pass validation only to burst upon saving. I've
 tried to address that but it turned out to be almost impossible without
 making significant incompatible changes. Also some people on IRC voiced
 their concerns that None/null is a database concept and that they don't
 want validation to mess with it, a few core dev however agreed that it
 should be fixed if possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.26d3eb67c93ca2c94164603c5f348920%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-06-19 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Niko Mäkelä ):

 If I add some text or leave a PositiveIntegerField empty, it says "type
 object 'unicode' has no attribute '_meta'". I'm using model forms and
 Django 1.5.0 final.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.195a7acfb15cc27d9e95a5ac40cb524a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-27 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5a459233e94ce8ae3e3c83dd32230566%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-26 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 A quick look at the code shows that DecimalField and FloatField probably
 suffer from the same issue. I'd like to fix it for all numeric fields.

 Since [4cccb85e] it's possible to customize `empty_values` per field.
 However, I'm not sure that feature was introduced for this use case. It
 appears to be targeted at custom fields (judging by the tests introduced
 in that commit). Maybe Claude could confirm.

 Besides, `IntegerField` already has `empty_strings_allowed = False`.
 Removing the empty string from `empty_values` appears to duplicate this
 information. So I really doubt it's the right fix.

 If we step back, the root cause it's Django's historical lack of model-
 level validation. Unfortunately I don't know the entire story. I'm just
 mentioning it in case it helps finding a patch consistent with the
 existing code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.436b2d207fa7df4bef4fd5e574397a9e%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-25 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 Separate ticket(s) for those issues would be great. I'd like to see each
 type of cleanup in a separate patch (for example, all indentation fixes
 together).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.894e0347eb1042b9080d8f0047e5bed1%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-25 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by anonymous):

 Thanks Timo for following up on this.
 Quick question, I understand it s not good practice to change things that
 aren't related.
 I know Django code is no PEP8 but nevertheless some part of the code
 changed in the patch were quite dirty, specially the 3 chars indent, what
 the best practice to fix those?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.92f1db2e47b5b6811a7c31bb84d15aa4%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-24 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * cc: timograham@… (added)
 * needs_better_patch:  1 => 0


Comment:

 Updated pull request without unrelated changes and tweaked test.

 https://github.com/django/django/pull/1213

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.76b6ec0b22d1ba36016fb473a3ed2366%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well

2013-05-19 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by erikr):

 * cc: eromijn@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20205: PositiveIntegerfield does not handle empty values well (was: positiveintegerfield null=True, blank=True)

2013-05-19 Thread Django 
#20205: PositiveIntegerfield does not handle empty values well
-+-
 Reporter:  anonymous|Owner:  AmiZya
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by erikr):

 * needs_better_patch:  0 => 1
 * version:  1.5 => master
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 I looked at the patch, but the amount of style fixes made in the patch
 makes it too hard for me to review the changes.
 We typically do not do code style cleanup, unless it's very extreme or the
 code is being modified already.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.