Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"abdcf818431525ec1c1165b9351cc16c5c5fa1c6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="abdcf818431525ec1c1165b9351cc16c5c5fa1c6"
 [1.5.x] Fixed #20237 (again) Allowed binary parameter to assertContains

 Backport of b04fd579d5 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b04fd579d58332632c85ecd1ab3c7062e90086a8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b04fd579d58332632c85ecd1ab3c7062e90086a8"
 Fixed #20237 (again) Allowed binary parameter to assertContains
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by claudep):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Unfortunately, there is still an issue when the `assertContains` text
 parameter itself is made up of non-ascii binary content. I'll upload a
 complementary patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"427b59495e7e2a1c58a46d278f6decec1d37938c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="427b59495e7e2a1c58a46d278f6decec1d37938c"
 [1.5.x] Fixed #20237 -- Reenabled assertContains with binary parameter

 Thanks Baptiste Mispelon for the review.
 Backport of fe01404bb9 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fe01404bb9f276446fc42390242da25122f91663"]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe01404bb9f276446fc42390242da25122f91663"
 Fixed #20237 -- Reenabled assertContains with binary parameter

 Thanks Baptiste Mispelon for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Testing framework|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:  regression   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by bmispelon):

 * cc: bmispelon@… (added)
 * stage:  Unreviewed => Ready for checkin


Comment:

 The patch looks good.

 This does indeed appear to be a regression (the same test works fine in
 django 1.4).

 I'm marking this as RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20237: Unable to test pure binary with assertContains

[Django]

#20237: Unable to test pure binary with assertContains
-+
   Reporter:  claudep|  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Testing framework  |Version:  1.5
   Severity:  Normal |   Keywords:  regression
   Triage Stage:  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 In one of my projects, I'm testing some readable content of a PDF file
 with `assertContains`. Unfortunately, this is no longer possible in Django
 1.5 (and I'm probably partially accountable for that!), as
 `assertContains` always try to decode the response content. I'd suggest to
 revert this regression.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.