Re: [Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"13de270bd52d057584023de08ea869722a7e5d5a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="13de270bd52d057584023de08ea869722a7e5d5a"
 [1.5.X] Fixed #20249 - Removed a "feature" in the tutorial that doesn't
 actually work.

 Thanks bmispelon for the report and draft patch.

 Backport of 679a2ac843 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"679a2ac843567d32c95ccc46a215bc453ccfa2d0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="679a2ac843567d32c95ccc46a215bc453ccfa2d0"
 Fixed #20249 - Removed a "feature" in the tutorial that doesn't actually
 work.

 Thanks bmispelon for the report and draft patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by bmispelon):

 After some comments from Jacob on IRC, I changed the approach and modified
 the pull request.

 His concerns were that the added code was distracting the reader from the
 real purpose of that part of the tutorial (testing).

 This new version changes the part 4 of the tutorial to make the changes
 introduced in the 5th part more seamless and less awkward.

 For reference, I kept the older version on a different branch:
 https://github.com/bmispelon/django/compare/master...ticket-20249-backup.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by bmispelon):

 * has_patch:  0 => 1


Comment:

 Here's a first attempt at rewriting the documentation:
 https://github.com/django/django/pull/1025

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by tinodb):

 * cc: tinodb (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20249: Tutorial part 5 uses broken undocumented feature

[Django]

#20249: Tutorial part 5 uses broken undocumented feature
---+
 Reporter:  bmispelon  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 As reported in #20241, passing callable arguments to a queryset's `filter`
 method doesn't actually work the way it's described in the tutorial [1].

 It's also an undocumented feature (#11629).


 [1]
 
https://github.com/django/django/blob/master/docs/intro/tutorial05.txt#L408-L411

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.