Re: [Django] #20594: models.SlugField doesn't validate against slug_re

[Django]

#20594: models.SlugField doesn't validate against slug_re
-+-
 Reporter:  carbonXT |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Database layer   |   Status:  closed
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dc9c359546580d40df209816cef244b78dcf7435"]:
 {{{
 #!CommitTicketReference repository=""
 revision="dc9c359546580d40df209816cef244b78dcf7435"
 Fixed #20594 -- Add validation to models.SlugField.

 Thanks carbonXT for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b4bb46978a586c227278d8087a15015f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20594: models.SlugField doesn't validate against slug_re

[Django]

#20594: models.SlugField doesn't validate against slug_re
-+-
 Reporter:  carbonXT |Owner:
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by bmispelon):

 * owner:  bmispelon =>
 * status:  assigned => new
 * has_patch:  0 => 1


Comment:

 PR here: https://github.com/django/django/pull/1267

 I also included some cleanup of the `URLField` validators.
 Since 9ed6e08ff99c18710c0e4875f827235f04c89d76, the `URLField` (both model
 and form field) validator doesn't depend on a parameter passed in
 `__init__` so it can be added directly to `URLField.default_validators`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.27985a4de9a137267a36786e64c165a5%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20594: models.SlugField doesn't validate against slug_re

[Django]

#20594: models.SlugField doesn't validate against slug_re
-+-
 Reporter:  carbonXT |Owner:  bmispelon
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by bmispelon):

 * cc: bmispelon@… (added)
 * owner:  nobody => bmispelon
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7991c26735a03ba62906c93ea8b541eb%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20594: models.SlugField doesn't validate against slug_re

[Django]

#20594: models.SlugField doesn't validate against slug_re
-+-
 Reporter:  carbonXT |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by claudep):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * easy:  0 => 1
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.45c1da778f320f3709d1950585c04940%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20594: models.SlugField doesn't validate against slug_re

[Django]

#20594: models.SlugField doesn't validate against slug_re
--+
 Reporter:  carbonXT  |  Owner:  nobody
 Type:  Uncategorized | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 This appears to be a bug to me:

 {{{
 from django.db import models

 class MyModel(models.Model):
 slug = models.SlugField()

 mymodel = MyModel(slug='this is an invalid % $ ## slug')
 mymodel.full_clean() # it'd expect this to raise a validation error... it
 does not.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.4f0e7d8dd33e65f068093f559a46c03a%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.