Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"8904e9fb98eaa94fd38e28706e2fe6786d3adc70"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8904e9fb98eaa94fd38e28706e2fe6786d3adc70"
 [1.5.x] Fixed #20681 -- Prevented teardown_databases from attempting to
 tear down aliases

 Thanks simonpercivall.

 Backport of d9c580306c from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.cb82ac2364c336d30e476c1d5ae42b37%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"e5241902f3d4b0f925eb67809dfb732dd46ba597"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e5241902f3d4b0f925eb67809dfb732dd46ba597"
 [1.6.x] Fixed #20681 -- Prevented teardown_databases from attempting to
 tear down aliases

 Thanks simonpercivall.

 Backport of d9c580306c from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.82f995a37e866b014bbd95304461e272%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d9c580306c4b7da49d7fd2fd1ea0e6333a784113"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d9c580306c4b7da49d7fd2fd1ea0e6333a784113"
 Fixed #20681 -- Prevented teardown_databases from attempting to tear down
 aliases

 Thanks simonpercivall.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ac696651793342aa221743e1c0a04841%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by simonpercivall):

 Patch against master uploaded. Changed from `assertEquals` to
 `assertEqual`, and changed the name of the test to be more descriptive.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bbf8d4df3f06e4553a54a6c04d540d6a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * needs_tests:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Looks good Simon, could you provide a patch against master? Also please
 use `assertEqual` rather than `assertEquals`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.1cd3c40458945f634eae1610178a07fb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+--
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by simonpercivall):

 Added new patch (more correct, I think), with test case.

 The test won't work until #19940 is fixed, though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e6d27ffe3ea7a554ca694f54b7e55fb9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+--
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by aaugustin):

 Not sure if that's related, but I've seen a similar problem when running
 tests with `DATABASES = {}` (in an app that doesn't have any models).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2c3b122d6a32253cafc3d0992a7913cb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+--
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by shai):

 Hi,

 I suspect this is either a duplicate or a regression of #14415 (the
 description is too terse to tell, esp. with no test case). Also, #19542
 (Oracle specific) may be related.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6d3083aba96d26fbd566fa15a4c0b24c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+--
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by bmispelon):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Hi,

 Could you add a test case to the patch [1]?
 Test cases are required for a patch to get merged and in this case, it
 would also make it easier to confirm the existence of the issue.

 Thanks.

 [1] https://docs.djangoproject.com/en/1.5/internals/contributing/writing-
 code/submitting-patches/#patch-style

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8616fc0fe93384f08530993e1cb71930%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+--
 Reporter:  simonpercivall |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by simonpercivall):

 * cc: percivall@… (added)
 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9002f46d7725bc8b7b03cc996827b974%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20681: teardown_databases tries to tear down aliases, which fails

[Django]

#20681: teardown_databases tries to tear down aliases, which fails
---+
 Reporter:  simonpercivall |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Testing framework  |Version:  1.5
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 If you have an aliased database, the teardown code will fail when trying
 to tear it down.

 The patch changes setup_databases to only add a (connection, db_name) to
 old_names if it's not already been added by an previous alias.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.63771aaa878d50a5d3b51c5d3f8fd27e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.