Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * severity:  Release blocker => Normal


Comment:

 It was marked as a release blocker for 1.10 because the first commit to
 master for 1.10 caused a regression that needed to be fixed or else the
 original fix reverted before 1.10 final.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.28521d950d9c913eb2b5397d137b074f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by techdragon):

 Is this going to wind up in a 1.9.x release or only land in 1.10 ?

 I ask because it was marked as a release blocker before 1.9 was shipped,
 so it makes some sense that it would appear in a 1.9.x release unless
 there is some other reason for it to be 7 months away in 1.10.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.60c62fb9441d7e9c1a74d8767ad8530b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"780bddf75b93784470a2e352ed44ee35a751d667" 780bddf7]:
 {{{
 #!CommitTicketReference repository=""
 revision="780bddf75b93784470a2e352ed44ee35a751d667"
 Fixed #20846 -- Decreased User.username max_length to 150 characters.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.81f738721da5f3f7d9303c34657a8c7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by collinanderson):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/5891

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.bb668d1be5b86194891ba6d0535c41e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by collinanderson):

 Actually, I think the shorter index solution doesn't work for UNIQUE
 indexes, which is what we're running into here.
 https://groups.google.com/d/msg/django-developers/DuSwAy0670w/wS2ohfFVDwAJ

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.1238b8f1b4baa5024e02a784eebeea20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by collinanderson):

 re #18392: Exactly. I think the best plan is to have django be cautious
 and limit the index to 191 by default.

 If the user has changed their DB config to allow longer prefixes, they can
 tell django to allow longer indexes, and can at least manually convert
 ROW_FORMAT on the tables.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.532d15f805cb1c5e802d4519fc65e8c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by adamchainz):

 We use utf8mb4 in production at YPlan just fine - we enable
 {{{innodb_large_prefix}}}, and use {{{ROW_FORMAT=DYNAMIC}}} or
 {{{ROW_FORMAT=COMPRESSED}}} on all tables, allowing the long indexes.
 However mandating this of all Django apps would be difficult - not
 everyone can change their DB config, and migrations don't currently allow
 {{{ROW_FORMAT}}} to be set and MySQL unfortunately doesn't let you set a
 default.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.4e273f7e186c6a027d16367b6c1027ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by collinanderson):

 * has_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.410f44e8c059b78e018a33d9a1e1b1ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
-+
 Reporter:  ivoras@… |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.auth |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by collinanderson):

 * status:  closed => new
 * resolution:  fixed =>
 * severity:  Normal => Release blocker


Comment:

 Yeah, we should really fix this, ideally by resolving #18392. (hint: add a
 DATABASES OPTIONS on mysql for max index length that defaults to either
 191 or 255.) I was under the impression that utf8mb4 _really_ didn't work
 with django but apparently you can get by ok besides this change.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.b4d16a5a06dcc52c12f1cb0a3c615d5d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by adamchainz):

 This patch breaks on MySQL installations using the {{{utf8mb4}}} charset,
 because it breaks the index length limit - it comes out at a maximum of
 254 * 4 = 1016 bytes whilst by default InnoDB can only index 767 bytes. I
 found this because I am using utf8mb4 in django-mysql.

 Django encourages using the utf8 charset (3 bytes per character - cannot
 store emojis), although there has been some discussion for moving to
 utf8mb4 in #18392. One can index 254 character utf8mb4 fields in MySQL by
 using a couple settings as described in that ticket, Django could enforce
 those, or the field coudl be changed to just 191 characters instead which
 is the maximum indexable (767 // 4).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.05214499c82c75008196005d6eb909f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"15ef1dd478c5b6f005e5f782b7619f718ed55e84" 15ef1dd]:
 {{{
 #!CommitTicketReference repository=""
 revision="15ef1dd478c5b6f005e5f782b7619f718ed55e84"
 Fixed #20846 -- Increased User.username max_length to 254 characters.

 Thanks Collin Anderson and Nick Sandford for work on the patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.0f504ab0413e40ced2e5fb9e851ba568%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  1 => 0


Comment:

 [https://github.com/django/django/pull/5497 Updated PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.3cfb4b68243331808ecf1e8095026251%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by collinanderson):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.9b2653ec11d4219bfd7a3cafb74d1149%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by collinanderson):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.123e114e3104ab5cf3f44d0a16907654%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.6595c0e5e35e3eec85e1e920f6f70f0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by collinanderson):

 * cc: cmawebsite@… (added)
 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.39418cee5abd5e2aa0985b4d76dd186e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * has_patch:  1 => 0
 * version:  1.5 => master
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.2af5a7af0b92952371ff6ad2b3fdfb08%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by collinanderson):

 https://groups.google.com/d/topic/django-developers/v3wYKWWYFT4/discussion

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.03297c5a5d2ab89e34dd3eae2adc1f01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by mtparsons):

 I would also like to chime in here, having just run into this issue.  We
 use a user's email address as their username and are running into a number
 of complaints from user's who are unable to register because their email
 addresses are longer than 30 characters.  I realize that the proposed
 solution is to use a custom user model, but as other posters above have
 stated, that is not always a simple process and is a lot of work solely to
 increase the length of a field.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.05eff581260cd54be2b9621f6b1f1a9e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by hwkns):

 Replying to [comment:14 freakboy3742]:
 > To me, the idea of a > 30 character *username* is pretty laughable -
 even *my* full name fits in 30 characters.
 Frankly, the length of your own name is irrelevant.  And being unable to
 imagine the need for a username longer than 30 characters is **not** a
 good reason to set that arbitrary limit.

 > If we *are* going to do this, a max_length of 254 makes the most sense
 to me (matching the length of the email field).
 Yes, 254 makes sense if we're talking about using email addresses as
 usernames, but that's still arbitrary.  Why limit the length of `username`
 in the model at all, when that can be easily accomplished in forms?  Why
 not use the largest maximum length for a `CharField` that is still
 supported by all the database backends?

 > I'm mostly bemused that people seem to have such an aversion to using
 CUSTOM_USER_MODEL ...
 Let me quote from the docs:
 > **Warning:**
 > Changing `AUTH_USER_MODEL` has a big effect on your database
 structure. It changes the tables that are available, and it will affect
 the construction of foreign keys and many-to-many relationships. If you
 intend to set `AUTH_USER_MODEL`, you should set it before creating any
 migrations or running `manage.py migrate` for the first time.
 > Changing this setting after you have tables created is not supported
 by `makemigrations` and will result in you having to manually fix your
 schema, port your data from the old user table, and possibly manually
 reapply some migrations.
 I can't imagine why anyone would be averse to that...

 > ... and that for some reason, using and/or contributing to a separate
 username model app third-party project is considered harder than pushing a
 patch into Django (a course of action that won't have practical results
 for 6-12 months).
 As it turns out, the mechanism used by the `longerusername` package to set
 the `max_length` of `User.username` is not available in Django 1.7, so
 yes, it is going to be considerably more difficult.  Even if it weren't,
 providing sensible defaults should be the goal of any good framework, so
 pushing a patch into Django is a worthwhile pursuit.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.07fa7def73e0c298be92202bd7a24c71%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by freakboy3742):

 Replying to [comment:8 carljm]:
 > That said, I do think that the overly-restrictive max-lengths in the
 default user model should be fixed, custom-user-models notwithstanding,
 and that built-in migrations should make it possible to fix. Russell, it
 sounds like you agree, at least in theory? Could we reflect that consensus
 by reopening this ticket?

 Now that we actually *have* a migration system, I agree that the
 discussion has moved from being a practical impossibility to at least a
 plausible option.

 However: To me, the idea of a > 30 character *username* is pretty
 laughable - even *my* full name fits in 30 characters. The idea that,
 using the classical definition a username, a user would select a username
 > 30 seems like a pretty unusual case to me. IMHO, increasing to some
 arbitrary other value (60, 150, whatever) to support some arbitrary
 concept of what "big enough" will mean for usernames seems like a waste of
 effort. 30 is a reasonable default, and we have custom user models if you
 really do need something different.

 Of course, that doesn't allow for the case where someone is using
 "username" to store something that wouldn't classically be called a
 "username" - the "email address as username" case, for example. I have
 some mild reservations about that as a design pattern - if you want to log
 in by email, then a custom user model with USERNAME_FIELD='email' is a
 much better solution to me. We added custom user models for a reason -
 trying to bash every possible use case into Django's default user model is
 just wrong-headed.

 To be clear, though: I'm not morally opposed to making a change to
 max_length. I'm mostly bemused that people seem to have such an aversion
 to using CUSTOM_USER_MODEL, and that for some reason, using and/or
 contributing to a separate username model app third-party project is
 considered harder than pushing a patch into Django (a course of action
 that won't have practical results for 6-12 months).

 If we *are* going to do this, a max_length of 254 makes the most sense to
 me (matching the length of the email field).

 > It occurs to me that custom user models may actually prove an obstacle
 to fixing this in a much more direct way, in that fixing it will likely
 change the abstract base models that many custom user models are
 inheriting from, and we can't ship a migration to change someone's custom
 user model. I guess if we start to allow shadowing of fields on abstract
 bases, as has been discussed recently on the mailing list, we could make
 this change only on the final concrete User model, and leave the abstract
 bases alone, for backwards-compatibility. But then future custom user
 models inheriting from those bases won't benefit from the change...

 Agreed that this is a complication. Anyone deploying a third party custom-
 user app will need to have migrations. The application of those migrations
 will need to be Django-version dependent. If you're using the custom app
 on Django 1.7, you won't need to migrate the third party app - but as soon
 as you upgrade Django, the third party app will need to run the 1.7->1.8
 migration.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.2c2793936dd25a9f189b0f356367ced2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by hwkns):

 Replying to [comment:11 carljm]:
 > If you use a `ModelForm` without overriding the field, the form field's
 `max_length` will be automatically derived from the model field's
 `max_length`.
 That does sound bad, then.  I'm tempted to say that ModelForms for the
 `User` model are not very common, but I have no data to support that
 assertion.

 > Or contribute a fix to the third-party library, which shouldn't take
 them long to accept if it's maintained (and if it's not maintained, you
 may be better off moving that monkeypatch into your own code base anyway).
 Yes, my plan is to contribute the fix to `longerusername`, and I'm happy
 to do that.  My frustration is with the "wontfix" sentiment surrounding
 what was obviously a poor design choice in Django, as if it will magically
 get better on its own if we ignore it for another 10 years (usernames are
 only getting shorter, right?).


 Replying to [comment:12 timgraham]:
 > In fact, Collin started a [https://groups.google.com/d/topic/django-
 developers/v3wYKWWYFT4/discussion thread on django-developers] a few days
 ago to discuss the possibility of reopening this.
 Thanks for the link -- I'll direct my comments to the mailing list thread
 from here on out.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.ed96ee96e6e9c1ba6ef2a14e82993204%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by timgraham):

 In fact, Collin started a [https://groups.google.com/d/topic/django-
 developers/v3wYKWWYFT4/discussion thread on django-developers] a few days
 ago to discuss the possibility of reopening this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.f7b335d54656fea6403556cc2aacebe1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by carljm):

 Replying to [comment:10 hwkns]:
 > Apologies for re-opening if that was not the correct course of action.
 I just got burned by this issue, after migrating a very large Django
 project, from 1.6 using the third-party `longerusername` package, to 1.7
 (for which that package does not yet have a migration).  This is our only
 blocker for deploying with 1.7, and it's painful that my choices are to
 either create a custom User model or fork a third-party library.

 Or contribute a fix to the third-party library, which shouldn't take them
 long to accept if it's maintained (and if it's not maintained, you may be
 better off moving that monkeypatch into your own code base anyway).

 > Replying to [comment:9 carljm]:
 > > If they never run `migrate`, that results in a much much worse
 situation, because their models no longer match their database schema,
 meaning that instead of getting nice Django-level form validation errors,
 they now get unpredictable errors depending on their database backend --
 some backends will silently truncate the data, some will raise a database-
 error resulting in a 500 Internal Server Error.
 > `max_length` can and should be specified in forms for validation.  It
 was my impression that the model's `max_length` information was only for
 the database backend...  is that inaccurate?

 If you use a `ModelForm` without overriding the field, the form field's
 `max_length` will be automatically derived from the model field's
 `max_length`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.509b7751eeabeb44ddd0be2d4cf3ab57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by hwkns):

 Apologies for re-opening if that was not the correct course of action.  I
 just got burned by this issue, after migrating a very large Django
 project, from 1.6 using the third-party `longerusername` package, to 1.7
 (for which that package does not yet have a migration).  This is our only
 blocker for deploying with 1.7, and it's painful that my choices are to
 either create a custom User model or fork a third-party library.

 Replying to [comment:9 carljm]:
 > Replying to [comment:6 hwkns]:
 > > Replying to [comment:1 russellm]:
 > > > If we applied the diff you describe, every Django user on the planet
 would need to issue a migration on their database
 > >
 > > Is this even true?  Wouldn't this migration only have to run if the
 user was already running `manage.py migrate` ?  And if the user never ran
 that command, they would just keep the old limit of 30?
 >
 > If they never run `migrate`, that results in a much much worse
 situation, because their models no longer match their database schema,
 meaning that instead of getting nice Django-level form validation errors,
 they now get unpredictable errors depending on their database backend --
 some backends will silently truncate the data, some will raise a database-
 error resulting in a 500 Internal Server Error.
 `max_length` can and should be specified in forms for validation.  It was
 my impression that the model's `max_length` information was only for the
 database backend...  is that inaccurate?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.9b83bd507145daf35318e7055291a2d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by carljm):

 Replying to [comment:6 hwkns]:
 > Replying to [comment:1 russellm]:
 > > If we applied the diff you describe, every Django user on the planet
 would need to issue a migration on their database
 >
 > Is this even true?  Wouldn't this migration only have to run if the user
 was already running `manage.py migrate` ?  And if the user never ran that
 command, they would just keep the old limit of 30?

 If they never run `migrate`, that results in a much much worse situation,
 because their models no longer match their database schema, meaning that
 instead of getting nice Django-level form validation errors, they now get
 unpredictable errors depending on their database backend -- some backends
 will silently truncate the data, some will raise a database-error
 resulting in a 500 Internal Server Error.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.47be5589f72e121abcfab1dff4226825%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by carljm):

 Please don't reopen tickets closed wontfix by a core committer just "to
 get a second opinion"; that's against our documented policy, as it leads
 to too many open/close wars. The right course of action is to raise the
 question on the django-developers mailing list.

 I'm not sure if this should have been fixed in 1.7 or not. We're still
 ironing out some issues with the base initial migrations shipped with the
 contrib apps, so I think it's advisable to be cautious in shipping out new
 migrations. The 30-character limit has been around for 10 years, another
 year plus or minus isn't the end of the world.

 That said, I do think that the overly-restrictive max-lengths in the
 default user model should be fixed, custom-user-models notwithstanding,
 and that built-in migrations should make it possible to fix. Russell, it
 sounds like you agree, at least in theory? Could we reflect that consensus
 by reopening this ticket?

 It occurs to me that custom user models may actually prove an obstacle to
 fixing this in a much more direct way, in that fixing it will likely
 change the abstract base models that many custom user models are
 inheriting from, and we can't ship a migration to change someone's custom
 user model. I guess if we start to allow shadowing of fields on abstract
 bases, as has been discussed recently on the mailing list, we could make
 this change only on the final concrete User model, and leave the abstract
 bases alone, for backwards-compatibility. But then future custom user
 models inheriting from those bases won't benefit from the change...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.4c4d6d6989f08f402c9a97508cf2af3c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Changes (by hwkns):

 * status:  closed => new
 * resolution:  wontfix =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.710d9a372e1051f2beaa427792e1944f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by hwkns):

 Replying to [comment:1 russellm]:
 > If we applied the diff you describe, every Django user on the planet
 would need to issue a migration on their database

 Is this even true?  Wouldn't this migration only have to run if the user
 was already running `manage.py migrate` ?  And if the user never ran that
 command, they would just keep the old limit of 30?

 I'm re-opening this in hopes of getting a second opinion.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.6c0be4b91656e32843fc16d32717b698%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by hwkns):

 This absolutely should have been fixed in Django 1.7.  With all the
 warnings attached here
 (https://docs.djangoproject.com/en/dev/topics/auth/customizing/#substituting-a
 -custom-user-model), why would anyone think creating a custom User model
 is a better idea than a sane default / running a single migration as a
 part of a gigantic migrations overhaul?

 As far as the definition of "sane", this is a **max_length** property, so
 a sane value would be the smallest maximum allowed length for a CharField
 in any of Django's supported database backends.  I guarantee that value is
 not 30.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.13647250926ebb430e47467db1275dc6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by ivoras@…):

 > I hope you realize that this is completely untrue. As I said in my
 previous email -- we have a pluggable User model *specifically* to address
 this sort of limitation.

 Requiring devs to add yet another level of indirection just to get sane
 behaviour instead of having sane default is, IMO, wrong. But then we will
 probably get into a discussion on the definition of "sane" or "wrong" so
 I'll let someone else fight this one out. Cheers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.5b7f5fa91e6cfe850578ed299097e54e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by russellm):

 Replying to [comment:2 ivoras@…]:
 > > This *isn't* as simple as the change you suggest. If we applied the
 diff you describe, every Django user on the planet would need to issue a
 migration on their database, which is a *massive* backwards
 incompatibility.
 >
 > Surely now that Django has a kind of built-in migration facility
 something can be done about it?

 Possibly. There are a bunch of size limits in Django that have analogous
 problems; I'm certainly interested in seeing if the new built-in
 migrations framework can be used to address these.

 > I hope you realize that this change will have to be done sooner or
 later, so better do it sooner?

 I hope you realize that this is completely untrue. As I said in my
 previous email -- we have a pluggable User model *specifically* to address
 this sort of limitation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.f06a2720dcbbfe12fc7c3ee34532c773%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by ivoras@…):

 > This *isn't* as simple as the change you suggest. If we applied the diff
 you describe, every Django user on the planet would need to issue a
 migration on their database, which is a *massive* backwards
 incompatibility.

 Surely now that Django has a kind of built-in migration facility something
 can be done about it?

 > You're also then into the territory where you are discussing whether 150
 characters is enough for a username. Email addresses, for example, can be
 up to 254 characters and still be RFC compliant.

 Great, I'd happy with 254 characters limit, and it would be future proof
 as well.

 I hope you realize that this change will have to be done sooner or later,
 so better do it sooner?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.f7515a0b584d593199fb771fa4150867%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+--
 Reporter:  ivoras@…  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  1.5
 Severity:  Normal|   Resolution:  wontfix
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Changes (by russellm):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 This *isn't* as simple as the change you suggest. If we applied the diff
 you describe, every Django user on the planet would need to issue a
 migration on their database, which is a *massive* backwards
 incompatibility.

 You're also then into the territory where you are discussing whether 150
 characters is enough for a username. Email addresses, for example, can be
 up to 254 characters and still be RFC compliant.

 This is why Django 1.5 introduced the ability to define a
 [https://docs.djangoproject.com/en/1.5/topics/auth/customizing/#substituting-a
 -custom-user-model custom User model] -- this puts the control in the
 hands of the developer. See the docs and release notes for more details.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.e92dc7c51fe273c5addd2e19a8df74a1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20846: Increase contrib.auth's User.username length

[Django]

#20846: Increase contrib.auth's User.username length
--+
 Reporter:  ivoras@…  |  Owner:  nobody
 Type:  New feature   | Status:  new
Component:  contrib.auth  |Version:  1.5
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  1 |  UI/UX:  0
--+
 Currently, contrib.auth's User model sets the username field's max_length
 at 30, the same as for first_name and last_name. This is reasonable but a
 bit conservative (http://www.kalzumeus.com/2010/06/17/falsehoods-
 programmers-believe-about-names/). Nowadays it is common to use e-mail
 addresses as usernames (especially if using external auth sources such as
 OAuth), but while the email field is reasonably long (75), the 30
 characters for the username seems too short for modern sites.

 I'd actually like to propose increasing all the naming fields (username,
 email, first_name, last_name) to 150, but I'll settle for making the
 username field as long as the e-mail field.

 Patches:

 {{{
 --- models.py   2013-06-28 15:08:30.0 +0200
 +++ /home/ivoras/temp/Django-1.6b1/django/contrib/auth/models.py
 2013-08-01 18:13:01.280591492 +0200
 @@ -366,8 +366,8 @@

  Username, password and email are required. Other fields are optional.
  """
 -username = models.CharField(_('username'), max_length=30,
 unique=True,
 -help_text=_('Required. 30 characters or fewer. Letters, numbers
 and '
 +username = models.CharField(_('username'), max_length=75,
 unique=True,
 +help_text=_('Required. 75 characters or fewer. Letters, numbers
 and '
  '@/./+/-/_ characters'),
  validators=[
  validators.RegexValidator(re.compile('^[\w.@+-]+$'), _('Enter
 a valid username.'), 'invalid')
 }}}

 and

 {{{
 --- forms.py2013-06-28 15:08:30.0 +0200
 +++ /home/ivoras/temp/Django-1.6b1/django/contrib/auth/forms.py 2013-08-01
 18:14:52.760588650 +0200
 @@ -73,9 +73,9 @@
  'duplicate_username': _("A user with that username already
 exists."),
  'password_mismatch': _("The two password fields didn't match."),
  }
 -username = forms.RegexField(label=_("Username"), max_length=30,
 +username = forms.RegexField(label=_("Username"), max_length=75,
  regex=r'^[\w.@+-]+$',
 -help_text=_("Required. 30 characters or fewer. Letters, digits
 and "
 +help_text=_("Required. 75 characters or fewer. Letters, digits
 and "
"@/./+/-/_ only."),
  error_messages={
  'invalid': _("This value may contain only letters, numbers
 and "
 @@ -123,8 +123,8 @@

  class UserChangeForm(forms.ModelForm):
  username = forms.RegexField(
 -label=_("Username"), max_length=30, regex=r"^[\w.@+-]+$",
 -help_text=_("Required. 30 characters or fewer. Letters, digits
 and "
 +label=_("Username"), max_length=75, regex=r"^[\w.@+-]+$",
 +help_text=_("Required. 75 characters or fewer. Letters, digits
 and "
"@/./+/-/_ only."),
  error_messages={
  'invalid': _("This value may contain only letters, numbers
 and "
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/059.46873efc346d90ed3fdf5ae4bf0c1a5a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.