Re: [Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+-
 Reporter:  koirikivi  |Owner:  koirikivi
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"65cf82bd08631a7aa8d9dd007b2527476fa3304f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="65cf82bd08631a7aa8d9dd007b2527476fa3304f"
 Fixed #20934 -- Avoided NoReverseMatch in ModelAdmin.changelist_view

 The view tried to display links to a ModelAdmin's change_view, which
 resulted in NoReverseMatches if get_urls was overridden to remove the
 corresponding url.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.78db3bae3bbec40b2aab8ff52a71eacc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+-
 Reporter:  koirikivi  |Owner:  koirikivi
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by koirikivi):

 * has_patch:  0 => 1


Comment:

 Topic branch at https://github.com/koirikivi/django/tree/ticket_20934
 Pull request at https://github.com/django/django/pull/1499

 Tests pass under sqlite and postgresql

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6c5bc169b12e8fbf5bdbaada3af87e9a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+-
 Reporter:  koirikivi  |Owner:  koirikivi
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by koirikivi):

 * status:  new => assigned
 * owner:  nobody => koirikivi


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ca713a4262b40ed7bafe0f66efc7a94f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+
 Reporter:  koirikivi  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * component:  Uncategorized => contrib.admin
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.109a4d80768b95f83e8cd32422f23094%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+--
 Reporter:  koirikivi  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by koirikivi):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Created a test project to verify this bug and #20640:
 https://github.com/koirikivi/django-admin-views-test

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.be5431a9035038e85aed48a8443670ce%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change url is removed from get_urls

[Django]

#20934: NoReverseMatch on ModelAdmin.changelist_view if appname_modelname_change
url is removed from get_urls
---+
 Reporter:  koirikivi  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Uncategorized  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Accessing the {{{changelist_view}}} of a {{{ModelAdmin}}} subclass results
 in a {{{NoReverseMatch}}} error if {{{get_urls}}} is overridden so that
 the "appname_modelname_change" url is removed, but
 "appname_modelname_changelist" is left untouched.

 Example ModelAdmin subclass causing this error:

 {{{
 class UnchangeableModelAdmin(admin.ModelAdmin):
 model = models.UnchangeableModel

 def get_urls(self):
 # return the standard urls, except for the change url
 urlpatterns0 = super(UnchangeableModelAdmin, self).get_urls()
 return [p for p in urlpatterns0 if not p.name.endswith("_change")]
 }}}

 Traceback points to line 91 in
 {{{django/contrib/admin/templates/admin/change_list.html}}}, namely the
 {{{ result_list}}} template tag.

 Related issue: #20640

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.744e19f886360f397c330cc45f36b537%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.