Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by apollo13):

 See
 
https://github.com/django/django/blob/280c1a65ccacd679bf298bf2b169ff01e7266b8e/django/core/mail/message.py#L26
 -- we purposely don't want to change anything globally. also are you
 talking about the 3.3.3 fix, or the 3.3.3+ fix and how exactly would your
 patch look like (and why would it be better than what we have now and
 would the tests pass ;))?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e2e993bc7041dfed373611370269dcac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by cainmatt@…):

 regarding message.py:

 I think that rather than re-encoding the message in SafeMimeText you
 should set the encoding globally for python using:

 Charset.add_charset('utf-8', Charset.SHORTEST, None, 'utf-8')

 Note:

 u1 = Charset.Charset('utf-8')
 u1.body_encoding = None
 u2 = Charset.Charset('utf-8')

 u2.body_encoding != u1.body_encoding

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.00c4cf9c4ba87d76112ead2a4357d578%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Florian Apolloner ):

 In [changeset:"ed167e53a52af22a8dce229696184b0d87a88a78"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ed167e53a52af22a8dce229696184b0d87a88a78"
 [1.6.x] Worked around a bug in python 3.3.3. Refs #21093

 Backport of 280c1a65ccacd679bf298bf2b169ff01e7266b8e from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1a999aeb823a5b9600540996ac19ffa5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Florian Apolloner ):

 In [changeset:"35a447a263115b22a7040a9f4a16ff4bd2078466"]:
 {{{
 #!CommitTicketReference repository=""
 revision="35a447a263115b22a7040a9f4a16ff4bd2078466"
 [1.6.x] Fixed #21093 -- Ensured that mails are not base64 encoded on
 python 3.3.3+.

 Thanks to Arfrever for the report and Aymeric for the review.

 Backport of f28ea0230846c81e9b6725454bb3a10df24678aa from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7d35533c432c3902c42506debac8ceae%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Florian Apolloner ):

 In [changeset:"280c1a65ccacd679bf298bf2b169ff01e7266b8e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="280c1a65ccacd679bf298bf2b169ff01e7266b8e"
 Worked around a bug in python 3.3.3. Refs #21093
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cf0ac68d71496c84e5e15f721ed1564c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Florian Apolloner ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f28ea0230846c81e9b6725454bb3a10df24678aa"]:
 {{{
 #!CommitTicketReference repository=""
 revision="f28ea0230846c81e9b6725454bb3a10df24678aa"
 Fixed #21093 -- Ensured that mails are not base64 encoded on python
 3.3.3+.

 Thanks to Arfrever for the report and Aymeric for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b9e62934aed829f823ac0532011afca6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Release blocker|   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by apollo13):

 * version:  1.5 => master
 * severity:  Normal => Release blocker


Comment:

 We should review if our smtp backend properly sends mails on python 3.3+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b361632a0c1d3e3a4cb273098b8d5085%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by apollo13):

 Waiting for the outcome of http://bugs.python.org/issue19063

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ba0aa996390ff34ca22e4e1fb5d0e62a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by apollo13):

 * cc: apollo13 (added)


Comment:

 I think get_payload in python shouldn't decode the message, I am in
 contact with the author of the patch, hopefully we can get that fixed for
 python 3.3.3 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e89b4df65e624b38dc433547a6d47e5f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Arfrever):

 * cc: Arfrever (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2cda576ed873c0383d3ee6df36121008%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.5
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e74fbca25ea4c0a65966d23f997b8ab8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Django]

#21093: regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails 
with
Python >=3.3.3
---+
 Reporter:  Arfrever   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Testing framework  |Version:  1.5
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with
 Python >=3.3.3 since [http://hg.python.org/cpython/rev/64e004737837 Python
 commit 64e004737837].
 It passes with older versions of Python.
 I use Django 1.5.3.

 {{{
 $ PYTHONPATH="." python3.3 tests/runtests.py --settings=test_sqlite -v0
 mail.MailTests.test_dont_base64_encode
 ==
 FAIL: test_dont_base64_encode (regressiontests.mail.tests.MailTests)
 --
 Traceback (most recent call last):
   File "/tmp/Django-1.5.3/tests/regressiontests/mail/tests.py", line 330,
 in test_dont_base64_encode
 self.assertTrue(str('Content-Transfer-Encoding: 8bit') in s)
 AssertionError: False is not True

 --
 Ran 1 test in 0.025s

 FAILED (failures=1)
 }}}

 Variable 's' contains 'Content-Transfer-Encoding: 8bit' with older
 versions of Python and 'Content-Transfer-Encoding: 7bit' with Python
 >=3.3.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.5a6af06dff9e9c8607b0698574b93356%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.