Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7e5d7a76bf60564d39d25a101380e47da7f1e2f6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7e5d7a76bf60564d39d25a101380e47da7f1e2f6"
 Fixed #21259 -- Fixed formstools wizard for InlineFormSet.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.72a2528885c92fb68038f5125237f3fa%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by kkillebrew):

 * needs_better_patch:  1 => 0


Comment:

 That worked!  Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.903a5620f7a2ee87e619cbc4d107aed5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 I believe you will need to include:
 {{{
 class Meta:
 app_label = 'formtools'
 }}}
 on the model.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.2d486f6537ddd687134adc01112f815e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by kkillebrew):

 Thanks for the notes.  I'm having some issues with the test models.  I put
 the new models.py in django.contrib.formtools.tests, and I see runtests.py
 says in the verbose output 'Creating table formtools_testmodel', but then
 the test fails with 'OperationalError: no such table: tests_poet'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.0b6300d6035488d4ff4440b2e9f45654%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1
 * needs_tests:  1 => 0


Comment:

 Thanks, I left comments for improve on the PR. Please uncheck "Patch needs
 improvement" when you update it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.267e05def0b4732927e89c84689f1d31%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by kkillebrew):

 Okay, I've added a test to the pull request.

 https://github.com/django/django/pull/1726

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.0b9c68577fdbd7513a1ac5717122c7ec%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
-+-
 Reporter:  banderkat@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  wizard,  | Triage Stage:  Accepted
  InlineFormSet  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 1
 * stage:  Unreviewed => Accepted


Comment:

 Tentatively accepting, however, a test case demonstrating the problem and
 proving the fix works is necessary for this to be committed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.9a166650c8f72d23b3b4fa81942ee65b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21259: Wizard sets queryset instead of instance on InlineFormset

[Django]

#21259: Wizard sets queryset instead of instance on InlineFormset
---+---
 Reporter:  banderkat@…|  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.formtools  |Version:  master
 Severity:  Normal |   Keywords:  wizard, InlineFormSet
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+---
 Because {{{InlineFormSet}}} subclasses {{{BaseModelFormSet}}}, the wizard
 thinks it's like any {{{BaseModelFormSet}}} and incorrectly initializes
 the form by setting the form's {{{queryset}}} instead of the form's
 {{{instance}}}.  An {{{InlineFormSet}}} needs to have its instance set to
 the parent model object instead.

 Currently, attempting to set {{{self.instance}}} for the
 {{{InlineFormSet}}} in the wizard's {{{get_form_instance}}} results in an
 {{{AttributeError}}} saying "object has no attribute 'none'" as the wizard
 attempts to set the form's queryset (instead of instance) with it's
 {{{self.instance}}}.

 I have a fix to propose here:
 
[https://github.com/flibbertigibbet/django/commit/885798aa250544bd5c6d3a7325dc5c20c0795f2c]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ebde8dc15528f4b3ac6fd59f1fc09eb2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.