Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-19 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"584110417f6a3c16cc0c6723825a21940a9a2bc4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="584110417f6a3c16cc0c6723825a21940a9a2bc4"
 Fixed #21283 -- Added support for migrations if models is a package.

 Thanks Markus Holtermann for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cbe535d4a9901e3488c0f107837197f8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-18 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by loic84):

 I had a go at this https://github.com/django/django/pull/1772, feedback
 welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.633dbdbd3965f3ea7f59288afa4a6170%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timo):

 That would be `get_app_path()` introduced in
 31c13a99bb9ebdaf12ccab4e880c5da930d86e79, I think.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5bd490696960de56773a8b5845ea4e31%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by loic84):

 @timo, shouldn't this use the app cache methods that you reworked at some
 point to better deal with models in exotic locations?

 As for testing, dunno if this is going to play nice with
 `MIGRATION_MODULES` that we need to use in tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.901a5014876b3f380330c3ec61d905d7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timo):

 Could you make a separate test app like "migrations_model_package" and
 make sure migrations are properly generated there?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.380ee815da4ee76283610d1eca031dc5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by MarkusH):

 * cc: info@… (added)
 * owner:  anonymous => MarkusH


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.17fb3310e5f0993fd3d33a1aee4cd9da%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+-
 Reporter:  anonymous   |Owner:  anonymous
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Markus Holtermann ):

 * owner:  MarkusH => anonymous
 * status:  new => assigned
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 The pull request is at https://github.com/django/django/pull/1763

 Right know I don't have a clue how to write a test case for this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e60fe34dab3b680c6910fc74aaf9dad%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+
 Reporter:  anonymous   |Owner:  MarkusH
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timo):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b866266416f9cb33cb94e89dee34d9c0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21283: Migrations created in wrong directory for models defined in model package

2013-10-17 Thread Django 
#21283: Migrations created in wrong directory for models defined in model 
package
+-
 Reporter:  anonymous   |  Owner:  MarkusH
 Type:  Bug | Status:  new
Component:  Migrations  |Version:  master
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+-
 Django supports to split a bunch of models into a separate Python modules
 which are placed in a models Python package. However the
 `django.db.migrations.writer.MigrationWriter` does not reflect this fact
 in its `path` property.

 The solution is easy:

 If `myapp.models` is a Python `app_module` (currently line 61) has a
 `__path__` attribute. If it is a Python module there is no such attribute.

 I'm going to write a patch and open a pull request for further discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.862e9e76fd051dab3cb3aafecf556262%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.