Re: [Django] #21286: Fix commented out tests in serializers_regress

2017-09-17 Thread Django 
#21286: Fix commented out tests in serializers_regress
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"01c6a3e227b645e8dea97e9befecd23d1d3b8581" 01c6a3e]:
 {{{
 #!CommitTicketReference repository=""
 revision="01c6a3e227b645e8dea97e9befecd23d1d3b8581"
 Refs #21286 -- Enabled serializer tests with time pk model
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ea16ed400530e247a0eeec6dda4a9add%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers_regress

2017-06-05 Thread Django 
#21286: Fix commented out tests in serializers_regress
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"d02fc8dfd3622efd996c0e300e11f6c219b549b4" d02fc8d]:
 {{{
 #!CommitTicketReference repository=""
 revision="d02fc8dfd3622efd996c0e300e11f6c219b549b4"
 Refs #21286 -- Enabled serializer tests with date/datetime pk model
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ccce8b12571760b52071050cc609b4e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers_regress

2015-09-26 Thread Django 
#21286: Fix commented out tests in serializers_regress
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 FileField and NULL value issue is tracked in #10244.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.dccd5b5ae94a0ad375599460346da302%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers_regress

2013-10-20 Thread Django 
#21286: Fix commented out tests in serializers_regress
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by bmispelon):

 * cc: bmispelon@… (added)


Comment:

 While looking into this, I believe I found the reason why some of the
 tests are commented:
 
https://github.com/django/django/blob/8d6953d55c3aba04bbaf0f268499d6e405c653ff/tests/serializers_regress/models.py#L168-L170


 The comment is not completely correct however because a few of the
 commented out models trigger and error immediately, regardless of the
 backend (`TypeError: 'primary_key' is not a valid argument for ...`).

 * `FilePKData`, `ImagePKData` and `NullBooleanPKData` can be deleted
 because of this.

 * `DatePKData`, `DateTimePKData`, `TimePKData` and `TextPKData` might be
 database-dependent (they all work under sqlite).

 * Test case 51 (`FileData`) might be worth looking into a bit deeper. It
 fails when uncommented and I believe it might be caused by the weird
 `FileField.__eq__` implementation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e44dcb4d9cd07e161caa22c2f2be19da%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21286: Fix commented out tests in serializers_regress

2013-10-17 Thread Django 
#21286: Fix commented out tests in serializers_regress
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Core (Serialization)  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 `tests/serializers_regress/tests.py` contains some commented out items in
 the `test_data` list. I think it may be because not all serializers
 support those items. If this is the case, we should make appropriate
 modifications so the tests are run where they are supported and skipped
 where not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.3c843eaa10fdf7d0f7bf92f90d1f6da6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.