Re: [Django] #21288: pep8 cleanup: continuation line over-indented for hanging indent

[Django]

#21288: pep8 cleanup: continuation line over-indented for hanging indent
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b289fcf1bfeaa717ed465b2529a275b61dc02d92"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b289fcf1bfeaa717ed465b2529a275b61dc02d92"
 Fixed #21288 -- Fixed E126 pep8 warnings
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.385b2523d23f179df9b65065c1751728%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21288: pep8 cleanup: continuation line over-indented for hanging indent

[Django]

#21288: pep8 cleanup: continuation line over-indented for hanging indent
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alasdair):

 Thanks for the suggestions. They were enough for me to finish my patch.

 Pull request https://github.com/django/django/pull/1780

 I've left inline comments on the pull request about a few of the changes I
 wasn't 100% sure about. Feel free to change before committing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d0e281466dcbe32ee10f4f579dbf934a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21288: pep8 cleanup: continuation line over-indented for hanging indent

[Django]

#21288: pep8 cleanup: continuation line over-indented for hanging indent
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by timo):

 Thanks for bring this up. For the contenttypes, I would put the key/value
 pairs on the same line, even if we have to go a bit over 80 chars. 80
 chars is a soft guideline that may be broken for readability.

 Similarly for db.models.base I think `tuple(x.DoesNotExist for x in
 parents if hasattr(x, '_meta') and not x._meta.abstract) or
 (ObjectDoesNotExist,),` could all be on the same line. Feel free to make
 adjustments if you feel otherwise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.6424606b585f862cc54b64c35a07b1b8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21288: pep8 cleanup: continuation line over-indented for hanging indent

[Django]

#21288: pep8 cleanup: continuation line over-indented for hanging indent
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alasdair):

 This cleanup is a bit less straight forward than the other recent pep8
 tickets.

 The attached patch makes sense to me, when we are changing the indentation
 of homogeneous list/dictionary items and function arguments.

 However other E126 errors seem trickier to fix.

 I've included a patch for django/contrib/contenttypes/generic.py as an
 example. I'm concerned that I've made the code less readable, because the
 indentation to distinguish between dictionary keys and values has been
 removed.

 Another tricky example is lines 113 & 114 of django.db.models.base.py.
 It's not clear to me how to re-format the code to remove the error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.77be3ba30551dea0289472a6142ee154%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21288: pep8 cleanup: continuation line over-indented for hanging indent

[Django]

#21288: pep8 cleanup: continuation line over-indented for hanging indent
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (Other)  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 To find errors, ensure you have an up-to-date master with the flake8
 config in setup.cfg, then remove E126 from the ignore list there. You can
 then run `flake8` from the directory with setup.cfg in it to list all
 errors - there should be about 300.

 Attaching an example patch to get you started.

 Apply it, if you'd like:

 `patch -p1 -i E126.diff`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.c865db599b4a437ce6c9d0482df629db%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.