Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2014-06-04 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  anubhav9042
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anubhav9042):

 First we will deal with raising errors. Cross-version conversions in
 `Model` would be dealt with separately.
 Regarding raising errors, we have reached where we are raising errors when
 version is different. Any ideas on how we can proceed further and check if
 versions are compatible or not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.47d343d4c0bb771e679ce307a94d07bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2014-05-30 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  anubhav9042
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anubhav9042):

 Replying to [comment:2 akaariai]:
 > By the way, I don't think we should leave this to just QuerySet. I know
 that at least Model unpickling can have this same issue. But for model
 unpickling we might be able to actually do cross-version conversions in
 `__getstate__()` and `__setstate__()`. Again, first try lets just throw an
 error.

 Can you please comment out your thoughts regarding cross-version
 conversion. I mean if you have thought of any way to pickle `Models` than
 the normal way or some other startegy.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9f641f3ccbba701522b984df9bcc3865%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2014-05-30 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  anubhav9042
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by anubhav9042):

 * version:  1.6 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e4b6e9553d40e481646dcbb899e4a742%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2014-05-18 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  anubhav9042
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by anubhav9042):

 * owner:  prasoon2211 => anubhav9042


Comment:

 Working on this in my GSoC project.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9aedd80cdfd24b411ebeeac59d8eb47d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2013-12-16 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  prasoon2211
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by prasoon2211):

 A PR has been filed for this : https://github.com/django/django/pull/2082

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fd6361f483fd0d79f5650fd86a1e23d0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2013-12-15 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:
 Type:  New feature  |  prasoon2211
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by prasoon2211):

 * status:  new => assigned
 * owner:  nobody => prasoon2211


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f14bfe97e67c96a94eda7cce35fe36b3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2013-11-12 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * stage:  Unreviewed => Accepted


Comment:

 By the way, I don't think we should leave this to just QuerySet. I know
 that at least Model unpickling can have this same issue. But for model
 unpickling we might be able to actually do cross-version conversions in
 `__getstate__()` and `__setstate__()`. Again, first try lets just throw an
 error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.dcc2689a2c3ebbf759038ed6a16081f0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2013-11-12 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
-+-
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I think this is a good idea. We should invent a new exception type
 UnsupportedUnpickleException or something like that.

 The implementation doesn't need to be more complicated than adding version
 = django's major version to the pickled state in `__getstate__` and then
 checking that the version is compatible in `__setstate__`. For first try
 we should just raise error if versions differ, later on we might want to
 try to actually recover from pickling errors. Unfortunately Query and all
 that it depends on seems to be way too complex to successfully do cross-
 version unpickling.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b5cbd7639ff886a73087e40d6bec6856%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21430: Raise explicit error when unpickling QuerySet from incompatible version

2013-11-12 Thread Django 
#21430: Raise explicit error when unpickling QuerySet from incompatible version
--+
 Reporter:  FunkyBob  |  Owner:  nobody
 Type:  New feature   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.6
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Currently the errors from doing this are not obvious at all, and make
 debugging a nightmare.

 Having a specific exception to look for in such cases would greatly
 simplify everyones job.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.d00599de23b3c766be2481d34a44aef7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.