Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  closed
 Type:   |  Version:  1.5
  Cleanup/optimization   |   Resolution:  fixed
Component:  Generic views| Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  BaseYearArchiveView  |  Patch needs improvement:  0
  filtering  |UI/UX:  0
Has patch:  0|
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Closing per above commit as I believe it solves it, but please reopen if
 not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.a063b03b273d7010ba64dd778aba2bea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:   |  Version:  1.5
  Cleanup/optimization   |   Resolution:
Component:  Generic views| Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  BaseYearArchiveView  |  Patch needs improvement:  0
  filtering  |UI/UX:  0
Has patch:  0|
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"2724cdbff635a40819f206411de23e9b14867a58"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2724cdbff635a40819f206411de23e9b14867a58"
 Fixed #18355 -- Added ordering options to list based generic views.

 Added MultipleObjectMixin.ordering and get_ordering().

 Refs #21450.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.b8898162bd4b762795cf433e9b8b38c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:   |  Version:  1.5
  Cleanup/optimization   |   Resolution:
Component:  Generic views| Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  BaseYearArchiveView  |  Patch needs improvement:  0
  filtering  |UI/UX:  0
Has patch:  0|
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by pjrharley):

 Replying to [comment:4 aaugustin]:
 > #18355 looks related.

 I've added a PR there. I think it looks like it might close this ticket
 too if accepted. By default the behaviour is the same but the user can now
 easily use custom filtering (without overriding get_queryset either).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.d491ae242ec4f1a2cc036cb5191e3666%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:   |  Version:  1.5
  Cleanup/optimization   |   Resolution:
Component:  Generic views| Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  BaseYearArchiveView  |  Patch needs improvement:  0
  filtering  |UI/UX:  0
Has patch:  0|
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * has_patch:  1 => 0
 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Accepting on the basis of the problem, not sure about the proposed
 solution at this point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.40b4fc97fdb0e56173aaa5b0d8a33b50%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:  Bug  |  Version:  1.5
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  BaseYearArchiveView  |  Unreviewed
  filtering  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aaugustin):

 #18355 looks related.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.98d736bf2383fc10c25fe9f3814bce19%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:  Bug  |  Version:  1.5
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  BaseYearArchiveView  |  Unreviewed
  filtering  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 Is the current behavior documented? I see some
 [https://docs.djangoproject.com/en/1.6/ref/class-based-views/generic-date-
 based/ references to ordering in the docs]. Would this be a backwards
 incompatible change for people relying on the current behavior? If we can
 call it a bug, we may be able to change it (and sooner rather than later
 would be best). Can you submit a patch with a test that demonstrates the
 new functionality that we'd be adding?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.c7722cd12abc9a4fa12b370d1d116439%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:  Bug  |  Version:  1.5
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  BaseYearArchiveView  |  Unreviewed
  filtering  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Thibault Serot ):

 Hello,
 I actually see that there is also a default filtering + ordering in
 BaseArchiveIndexView:
 qs = self.get_dated_queryset(ordering='-%s' %
 self.get_date_field())
 date_list = self.get_date_list(qs, ordering='DESC')
 Should be replaced by:
 qs = self.get_dated_queryset()
 date_list = self.get_date_list()

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.facb72281fd0664575494aca7258ecf9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |Owner:  nobody
    |   Status:  new
 Type:  Bug  |  Version:  1.5
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  BaseYearArchiveView  |  Unreviewed
  filtering  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Thibault Serot ):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.ec1bf7f9d52dd0fd36738aa859e96917%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21450: BaseYearArchiveView prevent ordering of queryset

[Django]

#21450: BaseYearArchiveView prevent ordering of queryset
-+-
 Reporter:  Thibault Serot   |  Owner:  nobody
    | Status:  new
 Type:  Bug  |Version:  1.5
Component:  Generic views|   Keywords:  BaseYearArchiveView
 Severity:  Normal   |  filtering
 Triage Stage:  Unreviewed   |  Has patch:  1
Easy pickings:  0|  UI/UX:  0
-+-
 In BaseYearArchiveView, the get_dated_items calls the get_dated_queryset
 with an extra parameter '''ordering="-%s"''' : qs =
 self.get_dated_queryset(ordering='-%s' % date_field, * * lookup_kwargs)

 This behavior is not the same as in BaseMonthArchiveView (which do qs =
 self.get_dated_queryset(* * lookup_kwargs))
 and prevents from using custom filtering in get_queryset.

 Could you please remove the extra ordering="-%s" in the
 BaseYearArchiveView and let the user handle the filtering?

 Thanks a lot

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/079.8183b2a0fecf03e08c9afc9369b891c9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.