Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Russell Keith-Magee ):

 In [changeset:"2c176eb95cc53f29367e56e0a8eec336834a299d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2c176eb95cc53f29367e56e0a8eec336834a299d"
 Refs #21798 - Modified error number to provide room for future expansion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5d23ca37e4f59bd050d25294420b2ab7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cb15231888df2545356ad307eaea07f36aa0e8e0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="cb15231888df2545356ad307eaea07f36aa0e8e0"
 Fixed #21798 -- Added check for DateTime mutually exclusive options

 Added DateTimeCheckMixin to avoid the use of default, auto_now, and
 auto_now_add options together. Added the fields.E151 Error that is raised
 if one or more of these options are used together.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7939e1464a22985ce748f5c01d557b09%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * easy:  1 => 0
 * needs_better_patch:  0 => 1


Comment:

 I think we should just add the check and forget the deprecation warning.
 There are ways to ignore the check, so it wouldn't be backwards
 incompatible anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f54012868678549c3c11c3df065f7812%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-
Changes (by pirosb3):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.70d2cd802afd8db1c520df5311e2f17a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by pirosb3):

 Hi

 I have opted for a simple DeprecationWarning.
 I also did a small amount of refactoring, to avoid duplication. Let me
 know if we want me to change it.

 https://github.com/django/django/pull/2428

 Probably we will want to squash merge (once ready)? I have done a few
 useless commits that shouldn't mess up the existing history.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b61840994dbb128313dc3a6d71715e40%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by pirosb3):

 I think it would be more sensible to add DeprecationWarning first, and
 then field check later. In makes it more smoother. But the final call is
 up to you two :)
 I am willing to make the changes for the choice you make. Let me know.

 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4a91e00f0a4fd49502d7d55915077725%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by erikr):

 Eh, pressed enter too soon there. Two more notes:

 * If we also take `default` into account this warning, I definitely agree
 with charettes that we should fix this. Particularly as the behaviour in
 combination with `default` is a lot less obvious.
 * There are basically two options here: we could issue a
 DeprecationWarning, and add a field check in the next version, or just add
 the field check now. We went for the latter in #20484, but that was a
 little more severe: that actually broke in some conditions. If I
 understand comment:9 correctly, charette is in favour of adding the check
 now - I don't feel strongly either way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bfee374fd70d38dec16d48dc633eb4f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by erikr):

 Well, the decision of which option is enabled has already been made
 implicitly by the code. If one sets both `auto_now_add` and `auto_now`,
 the behaviour is identical to only providing `auto_now`. The warning could
 indicate that. I'm sure a similar deterministic precedence is present for
 `default`.

 The warning could be something along the lines of (not polished): `The
 combining of auto_now, auto_now_add and/or default paramaters of a ..field
 is deprecated. X takes precedence over Y, which takes precedence over Z`.
 Note also that there are three fields that have these parameters:
 DateTimeField, DateField and TimeField, to my knowledge.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d6e7d546a43dc254071def13195170c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by PirosB3):

 Hi charettes,

 so you would not take any action, other than warning the user? (you would
 still keep both options enabled?)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.14f68a31da8e3dcdd9777a1cf72487b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by charettes):

 By ''warn the user'' I mean adding a field check.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.afb1658f37e5039bcbddd184077a434e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by charettes):

 @erikr, I agree that we allow many silly definition, the combination of
 `auto_now_add` and `default is a good example.

 However I think we should at least warn the user if two of the `add_now`,
 `auto_add_now` and `default` options are defined since the defined
 behavior here is ambiguous.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f77c7e4c5c77adf517e11137a63180a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by PirosB3):

 Hi erikr

 I just read this now, after having done my PR
 (https://github.com/django/django/pull/2428)
 I understand your point, but shouldn't we correct the user in any case? I
 think the fields should do some validation on parameters that are mutually
 exclusive.

 Let me know if we would need this, in any case.

 Regards,
 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f62cee4aed3b5018eacad3e1a525b9ff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by erikr):

 You are talking about `auto_now` and `auto_now_add`, right? There is no
 `auto_add_now`, as far as I know.

 Provided that #21785 has resolved the migration issue, what is the actual
 need in deprecating this? Looking at the code, I see no reason why it
 should be invalid, or how it could cause issues. Yes, it would certainly
 be silly to add both `auto_now` and `auto_now_add`to a field, but I there
 are tons of silly field definitions that we still allow. For example, we
 also allow the combination of `auto_now_add` and `default`.

 A different situation would be if defining both would actually break in
 some cases, like the issue we resolved in #20484. But with #21785 is
 fixed, I see no similar situation here. When defining both, as far as I
 know, it behaves correctly and precisely as one would expect. Therefore,
 why should we disallow this combination?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.958b8a2d854f1a52a7085825aeca0cdb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by PirosB3):

 Hi again,

 I think it would be good to warn the user that both parameters cannot be
 used, but also automatically make a decision for him/her (and notify it
 through the warning).
 Does this sound like a reasonable solution?

 The warning could be: "add_now and auto_add_now cannot be both specified,
 add_now has been disabled on this field"

 Please let me know,
 Daniel Pyrathon

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1e703af4434fe6a8e530837c5c3291a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by anonymous):

 Hi,

 I am working now to provide a fix for this.

 Regards,
 Daniel Pyrathon

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.52a40482616ef0f5596de678b3560dca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-
Changes (by PirosB3):

 * owner:  charettes => anonymous
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e2f5b71e6b67d2ac134f1d5a055b656e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-

Comment (by russellm):

 Check framework is now merged; although if this is deprecation path, it's
 not a check framework thing - it's a DeprecationWarning where the feature
 is used. The check framework only applies if we're going to make the
 change and expect users to clean up the mess (as we did with the default
 change on BooleanField in 1.6).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6e1a2e91c6657e16b95dfb5ff59a469d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  1|
-+-
Changes (by timo):

 * stage:  Unreviewed => Accepted


Comment:

 Accelerated deprecation sounds ok to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6094bcbd19de0c8306804212be08981a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21798: Model validation should complain if both `add_now` and `auto_add_now` are specified.

[Django]

#21798: Model validation should complain if both `add_now` and `auto_add_now` 
are
specified.
-+-
   Reporter:  charettes  |  Owner:  charettes
   Type: | Status:  new
  Cleanup/optimization   |Version:  master
  Component:  Database   |   Keywords:
  layer (models, ORM)|  Has patch:  0
   Severity:  Normal |Needs tests:  1
   Triage Stage: |  Easy pickings:  1
  Unreviewed |
Needs documentation:  1  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
 It was reported in #21785 that `add_now` and `auto_add_now` can be both
 specified without triggering any kind of warning or validation or value
 error.

 Not sure of the path we want to take here since it should be pretty
 uncommon and easily fixed by the users. Would an accelerated deprecation
 be acceptable?

 In order to ease the merge of the `check` framework before the 1.7 alpha
 we should wait before landing a fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.81e85b451db183390bacdaf6643588dc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.