Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5a4f1298cf00fe4e2e35d0a3c02281b4c6afe07c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5a4f1298cf00fe4e2e35d0a3c02281b4c6afe07c"
 Fixed #21908 -- Added example usage for ModelAdmin.get_inline_instances().

 Thanks matt at schinckel.net for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.7accfb7a232331335b5a648442020e2c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"e7649789eddeb2ce8f3bf8f69ddc624006d0a46c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e7649789eddeb2ce8f3bf8f69ddc624006d0a46c"
 [1.6.x] Fixed #21908 -- Added example usage for
 ModelAdmin.get_inline_instances().

 Thanks matt at schinckel.net for the suggestion.

 Backport of 5a4f1298cf from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.a35e4eb01235a75a41ceae8450daed74%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timo):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.d581bb7a4ddf68ce036eb504561ecd02%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alextreme):

 Your patch is close, however fyi it uses a single colon where a double-
 colon should be used. A double colon indicates that the next block is a
 code sample.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.126e9bbf00d1410f0d57650db7574d9a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by avendael):

 I'm not sure if my patch is good enough. It's my first time to contribute
 to django :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.180f2962a3985b27a2174e31947d34a1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  avendael
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by avendael):

 * status:  new => assigned
 * owner:  nobody => avendael


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.56aa5a07fb027bc4e8f3e62e3ab01a45%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
--+
 Reporter:  matt@…|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timo):

 * needs_better_patch:   => 0
 * component:  contrib.admin => Documentation
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Sure, I'll be happy to review your patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.47b0479457b8939dd791fd8e484b0a2f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21908: Misleading documentation in ModelAdmin.get_inline_instances

[Django]

#21908: Misleading documentation in ModelAdmin.get_inline_instances
---+
 Reporter:  matt@… |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  contrib.admin  |Version:  1.6
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 The documentation for this method seems a little sparse:

 
https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_inline_instances

 It's not actually clear that you need to instantiate the inline classes in
 this manner:

 return [inline(self.model, self.admin_site) for inline in
 self.inlines]

 (Obviously, that is without filtering).

 I'm happy to submit a documentation patch, if it is likely to be accepted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.286c77d79d2997fa74ee6aeae39f7f20%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.