Re: [Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
--+
 Reporter:  timo  |Owner:  alasdair
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8aa1efff6d6cb1589a1977f3e68f4c26eb6adc74"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8aa1efff6d6cb1589a1977f3e68f4c26eb6adc74"
 Fixed #21951 -- Updated docs to use __str__ for Python 3

 Thanks Tim Graham for the report and recommendations
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.91370cc2a0f0cd3fa86b742300114804%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
--+
 Reporter:  timo  |Owner:  alasdair
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alasdair):

 > 1. You could repeat the method twice: first the Python 3 version, then
 the Python 2 version.

 Thanks for the suggestion. I've updated my patch to include examples for
 Python 3 and 2.

 Pull request https://github.com/django/django/pull/2258

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ed7ef749a2d532d374b9a21fba61d7dc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
--+
 Reporter:  timo  |Owner:  alasdair
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by timo):

 1. You could repeat the method twice: first the Python 3 version, then the
 Python 2 version.
 2. I agree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.85fdb87fb45e93a3cd5eb879d0afac35%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
--+
 Reporter:  timo  |Owner:  alasdair
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by alasdair):

 I have done most of this ticket in a branch

 https://github.com/alasdairnicol/django/compare/ticket_21951

 I'm unsure what to do about the following docs pages

  * https://docs.djangoproject.com/en/dev/ref/models/instances/ -- the
 `__str__` method is written for python 2, and returns bytes
  * https://docs.djangoproject.com/en/dev/releases/1.0-porting-guide/ --
 this page mentions replacing `__str__` with `__unicode__`. The page is
 historic, I suggest leaving it as it is.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.81b4deb01323030b703f0726a3b303ed%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
--+
 Reporter:  timo  |Owner:  alasdair
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by alasdair):

 * owner:  nobody => alasdair
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b543e4a6dc24117a81c67449b38d5f96%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21951: Docs should assume Python 3 first for __str__/__unicode__ methods

[Django]

#21951: Docs should assume Python 3 first for __str__/__unicode__ methods
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 `def __unicode__` should be replaced with `def __str__` and `# On Python
 3: def __str__(self):` should be replaced with `# On Python 2: def
 __unicode__(self):`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.9190673eaf8cf2d58269a9462ce66e0e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.