Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+---
 Reporter:  motiejus   |Owner:  gregchapple
 Type:  Bug|   Status:  closed
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:  worksforme
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---
Changes (by bmispelon):

 * status:  assigned => closed
 * resolution:   => worksforme


Comment:

 As mentionned by gregchapple, this appears to have already been fixed so
 I'll close this ticket as `worksforme`.

 Please reopen if you can provided steps that reproduce your issue.

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9e63318ed2f2fcfd977b9fdd5b20fee6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+---
 Reporter:  motiejus   |Owner:  gregchapple
 Type:  Bug|   Status:  assigned
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---

Comment (by Baptiste Mispelon ):

 In [changeset:"b1d10205ce0c4bb355e20bed6258b5264ed06cc5"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b1d10205ce0c4bb355e20bed6258b5264ed06cc5"
 Added tests for django.contrib.admindocs

 Refs #22015
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.308172110c809cef54eb421929fb6801%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+---
 Reporter:  motiejus   |Owner:  gregchapple
 Type:  Bug|   Status:  assigned
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---

Comment (by gregchapple):

 Added tests which cover `django.contrib.admindocs.views.ModelDetailView`
 which was seriously lacking in test coverage. This is part of ticket
 #22015, though the original issue for which the ticket was opened, seems
 to be already working as expected, with and without this patch. Though
 this patch does contain a test which covers the issue raised in the
 ticket, and should catch it in the future should it re-arise.

 Pull request: https://github.com/django/django/pull/2364

 I will do some further investigation into the original issue, and update
 again with my findings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2c6775ff444b484e0e85b211f9d5eef0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+---
 Reporter:  motiejus   |Owner:  gregchapple
 Type:  Bug|   Status:  assigned
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---
Changes (by gregchapple):

 * keywords:   => nlsprint14


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.edf148311d3f1f5bc3a1cdfb726b757f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+---
 Reporter:  motiejus   |Owner:  gregchapple
 Type:  Bug|   Status:  assigned
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---
Changes (by gregchapple):

 * owner:  nobody => gregchapple
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c741fd883bacabce6ba5e4a511b2f61f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+
 Reporter:  motiejus   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by claudep):

 Note that there are also tests in `tests/admin_docs`, notably
 `admin_docs.tests.AdminDocViewTests.test_model_detail`. We'd need a new
 `models.py`, though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0369a8a97e5dfb19bd2dddb9d9d7191c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22015: Hide relationships with related_name='+' in contrib.admindocs (was: Hide relationships with related_name='+')

[Django]

#22015: Hide relationships with related_name='+' in contrib.admindocs
---+
 Reporter:  motiejus   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admindocs  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+

Comment (by timo):

 As noted on the PR, admindocs is severely lacking in tests and
 bootstrapping them enough to be able to write a test for this change is
 more work than the reporter wants to do. If anyone else is interested in
 this patch, the first step will be to do that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ae80313eef2ec5df4988e7ca59f2053b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.