Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5233b366935dcc81e47546921ab4eb5007c83719"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5233b366935dcc81e47546921ab4eb5007c83719"
 Fixed #22029 -- Removed obsolete advice on registering migrate/syncdb
 signal handlers.

 All signals should now be registered in AppConfig.ready().

 Thanks un33k for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5b98836c1f842a38f43467242e53837e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"994274ea8315282484bc24aa403b2fd12b5bdeec"]:
 {{{
 #!CommitTicketReference repository=""
 revision="994274ea8315282484bc24aa403b2fd12b5bdeec"
 [1.7.x] Fixed #22029 -- Removed obsolete advice on registering
 migrate/syncdb signal handlers.

 All signals should now be registered in AppConfig.ready().

 Thanks un33k for the report.

 Backport of 5233b36693 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.75ecc050a2c3cd127b31ce8df1ef69f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by un33k):

 The current docs says that you "'''need to'''" register these signals in
 the management module or else.

 This is not the case anymore ... AppConfig.ready() is a better place,
 right Aymeric?

 Also, circular dependencies are no longer the issue if these signals are
 registering in AppConfig.ready() and yes, no need to register in urls.py
 are more.

 In short: "need to" is no longer true.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7d7af50e8591fed459803ac7e02acb91%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 I didn't check the commit logs, but the wording sounds like this is a
 warning against registering signals in urls.py (for instance). I don't
 think these signals are a special case any more.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e71328d7997a55ded3ec9f9e32661ce4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * has_patch:  0 => 1


Comment:

 I wonder if we need to mention this as something specific to these signals
 though? Can we assume all signals will now be registered in
 `AppConfig.ready()`?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ef4028e3f052d85ee7e83a56bfa6b6eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1c974895074d7026393aec281442b943%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by un33k):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 '''Also:
 '''
 '''This:'''
 "Sent by the migrate command before it starts to install an application."
 '''Could be changed to:'''
 "Sent by the migrate command before it starts to install an application
 that has a models module."

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.19c9ae999e2d85fdc1e99a5a22e36821%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22029: documentation: new best place to put the signal handler registration

[Django]

#22029: documentation: new best place to put the signal handler registration
--+
 Reporter:  un33k |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 The new best place for registering the signal handlers are in the ready()
 of the AppConfig.

 This way, the signals properly emit with the server starts and also via
 the django-admin shell.

 The documentation would benefit from an update indicating the new feature
 of Django 1.7.

 The following section may require the update.
 
https://docs.djangoproject.com/en/dev/ref/signals/#django.db.models.signals.pre_migrate
 
https://docs.djangoproject.com/en/dev/ref/signals/#django.db.models.signals.post_migrate


 '''This:'''
 "Any handlers that listen to this signal need to be written in a
 particular place: a management module in one of your INSTALLED_APPS. If
 handlers are registered anywhere else they may not be loaded by migrate."
 '''Could be changed to:'''
 "Any handlers that listen to this signal need to be written in a
 particular place: the AppConfig.ready() within the apps module in one of
 your INSTALLED_APPS. If handlers are registered anywhere else they may not
 be loaded by migrate."

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.686f77bfa8bc3b26a44872ec2dd8485e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.