Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+-
 Reporter:  bpeschier  |Owner:  bpeschier
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by bpeschier):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 And that commit actually fixed it

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.76f769541ba6c4526eb7fc3253e89202%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+-
 Reporter:  bpeschier  |Owner:  bpeschier
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Baptiste Mispelon ):

 In [changeset:"578bdb532cd88333569ef3f77042653e1a9f2d9d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="578bdb532cd88333569ef3f77042653e1a9f2d9d"
 Added tests and minified javascript missing in
 83a3add4bed8d8d49f93b30c817c66908b0a26ba.

 Refs #22038.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.186e93981880f676c4bd0c36749cc0d2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+-
 Reporter:  bpeschier  |Owner:  bpeschier
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by bpeschier):

 Sent a new PR which documents the variable, adds a test and minifies the
 Javascript: https://github.com/django/django/pull/2340

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.58a71982b5b9f4187e8c04718331eaa1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+-
 Reporter:  bpeschier  |Owner:  bpeschier
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by bmispelon):

 the modified js file should also be minified:
 https://docs.djangoproject.com/en/1.6/internals/contributing/writing-code
 /submitting-patches/#compressing-javascript

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.978dab5e660dc217ec13216cbd6fcddc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+-
 Reporter:  bpeschier  |Owner:  bpeschier
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  nlsprint14 | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by bpeschier):

 * owner:  nobody => bpeschier
 * status:  new => assigned
 * keywords:   => nlsprint14


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.483273364770128eb2841e457fcce4a2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+
 Reporter:  bpeschier  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by claudep):

 Tim merged the PR in 83a3add4bed8d8d49f93b30c817c66908b0a26ba. A test
 would be nice.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e06ccc3404d5e201def761dd4614bff9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+
 Reporter:  bpeschier  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by bmispelon):

 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 1
 * needs_better_patch:   => 1


Comment:

 Hi,

 Th PR looks good but it'd be better with some tests.
 I was also thinking it might be wise to add a comment on the line where
 `_actions_icnt` is used to indicate that the lack of declaration is on
 purpose.

 I'll mark this as `release blocker` as well so that it doesn't slip
 through the cracks.

 Thanks for catching this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8bfc035867c12b4236670adbecf11de5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22038: Admin shows selected rows as " of undefined selected"

[Django]

#22038: Admin shows selected rows as " of undefined selected"
---+
 Reporter:  bpeschier  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+
 Commit
 
https://github.com/django/django/commit/4523fcd60101124a307bd4026296337087b66884
 introduces ```_actions_icnt``` to the local scope, which overrides the
 value set in the HTML.

 The admin will show selected rows in a change list as "1 of undefined
 selected".

 PR under https://github.com/django/django/pull/2274; looking into a test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.fbc9bae5b612fe115bfde31dfdd2316b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.