Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
-+-
 Reporter:  Grzegorz Nosek   |Owner:  Andrew
 Type:   |  Northall
  Cleanup/optimization   |   Status:  closed
Component:  Core (URLs)  |  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * has_patch:  1 => 0
 * resolution:   => wontfix
 * stage:  Accepted => Unreviewed


Comment:

 Agreed, it's not worth adding the extra complexity. 404 is not like other
 exceptions and treating some 404s differently just because they don't come
 from the Django codebase could be confusing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189cf84e3ff-9872edad-9d25-4ebc-b3c6-b9ac6c2e4067-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
-+-
 Reporter:  Grzegorz Nosek   |Owner:  Andrew
 Type:   |  Northall
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Natalia Bidart):

 I'm not sure if it's too late to propose to "unaccept" this ticket. I have
 read the use case, and while there is a description for a use case, that
 use case feels, to me, insufficient to make a strong argument to add this
 change of behavior in the django codebase.

 My rationale is that failing to resolve an URL in a view is, indeed,
 semantically an "url not found" (404) result. At least in my experience, I
 can think of a few reasons for a failed resolve in a view such as:

   * there is a spelling error in the url name or args (in which case the
 unit tests should caught this)
   * there is a dynamic component in the url name/params that at the time
 of the execution evaluates to something that does not exist (this still
 feels like a 404 and not a 500)
   * something else I'm missing?

 I don't think the above justify the complexity that seems to be necessary
 to solve this (following [https://github.com/django/django/pull/17007 PR
 17007]).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189ad6d01d0-38372126-200e-4cdf-b07e-c737e03691cb-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
-+-
 Reporter:  Grzegorz Nosek   |Owner:  Andrew
 Type:   |  Northall
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  (none) => Andrew Northall


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188f63a0c7b-9595b09a-afe5-41e2-9bfc-9a77450675b9-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
--+
 Reporter:  Grzegorz Nosek|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (URLs)   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Andrew Northall):

 * cc: Andrew Northall (added)
 * has_patch:  0 => 1
 * version:  1.6 => dev


Comment:

 Initial patch added. Keen for some feedback on the implementation. Many
 thanks!

 https://github.com/django/django/pull/17007

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188f0857093-bdcd52de-2943-4351-bc46-9067ae0c70cd-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
--+
 Reporter:  Grzegorz Nosek|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (URLs)   |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Andrew Northall):

 * status:  new => assigned


Comment:

 I will work on this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188eed25cfd-dc96d9fb-9fc1-4018-b72d-7ca2420adfe4-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
--+
 Reporter:  Grzegorz Nosek|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (URLs)   |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Grzegorz Nosek => (none)
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701870383dc76-5d52e2d3-1a02-4f9e-ac21-611f361f11c8-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
--+
 Reporter:  Grzegorz Nosek|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701870383e85a-b32957d6-be5d-494b-ade0-23c0c90943ad-00%40eu-central-1.amazonses.com.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
--+
 Reporter:  gnosek|Owner:  gnosek
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4f6afe0b9cf496b1013c5e4f7b0ad3fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
---+--
 Reporter:  gnosek |Owner:  gnosek
 Type:  Uncategorized  |   Status:  new
Component:  Core (URLs)|  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by gnosek):

 * status:  closed => new
 * resolution:  wontfix =>


Comment:

 See #18373 for the use case.

 If you're calling resolve('/some-url') that fails, you're not raising an
 Http404 explicitly. It's just a function call that fails, just like the
 ORM or whatever.

 I agree that manually raised Http404s should not trigger the stack trace
 and this ticket is not about it. It's just about treating exceptions from
 resolve() failure just like every other exception.

 IMO, the right thing to do is:
   * Failing to resolve an URL from Django core -> no stack trace
   * Raising Http404 from a view -> no stack trace
   * Failing to resolve an URL from a view -> stack trace (and arguably 500
 response code but there's backwards compatibility to worry about)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6384209efa8b1a1a14b193e449344849%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
---+--
 Reporter:  gnosek |Owner:  gnosek
 Type:  Uncategorized  |   Status:  closed
Component:  Core (URLs)|  Version:  1.6
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by AeroNotix):

 * status:  assigned => closed
 * resolution:   => wontfix


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ecce0bc00ba0d336233113276027e922%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
---+--
 Reporter:  gnosek |Owner:  gnosek
 Type:  Uncategorized  |   Status:  assigned
Component:  Core (URLs)|  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by AeroNotix):

 Hi,

 What kind of useful information could you gain from a 404 page with a
 stacktrace? If you're explicitly creating a 404 exception then you want
 that to happen.

 Could you convince this list of the usefulness in changing this behaviour,
 please?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8cadccd8576c5561102ed9318109e3e3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
---+--
 Reporter:  gnosek |Owner:  gnosek
 Type:  Uncategorized  |   Status:  assigned
Component:  Core (URLs)|  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by gnosek):

 * owner:  nobody => gnosek
 * needs_docs:   => 0
 * status:  new => assigned
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.811ec2bca77dec4faf87b4cc777f6d4c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22055: 404 page does not display stack trace when Resolver404 is raised from a view

[Django]

#22055: 404 page does not display stack trace when Resolver404 is raised from a
view
---+
 Reporter:  gnosek |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Core (URLs)|Version:  1.6
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Related to #18373, the 404 error page served when
 django.core.urlresolvers.resolve() fails does not contain the exception
 stack trace, which makes finding the failing call unnecessarily difficult.

 When the resolve() call fails in a view, the error should actually be 500
 (it's not the user's fault), but for backwards compatibility the response
 code will have to remain 404 (as discussed with Honza Kral last year).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.b63dd0d2a40c848fb0d332a88da9180a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.