Re: [Django] #22101: Querysets using F() expressions with time deltas are not cloned correctly.

[Django]

#22101: Querysets using F() expressions with time deltas are not cloned 
correctly.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:  duplicate
 Severity:  Normal   | Triage Stage:
 Keywords:  queryset timedelta   |  Unreviewed
  expression regression  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by mrmachine):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #21643. Will add comments there about back porting the fix to
 1.6.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6b21a46e7627359fd1c0a549e27b67ec%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22101: Querysets using F() expressions with time deltas are not cloned correctly.

[Django]

#22101: Querysets using F() expressions with time deltas are not cloned 
correctly.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  queryset timedelta   |  Unreviewed
  expression regression  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by mrmachine):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request opened.

 https://github.com/django/django/pull/2330

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4dc22c94b7dac0d53593fa6096eed906%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22101: Querysets using F() expressions with time deltas are not cloned correctly.

[Django]

#22101: Querysets using F() expressions with time deltas are not cloned 
correctly.
-+-
 Reporter:  mrmachine|  Owner:  nobody
 Type:  Bug  | Status:  new
Component:  Database layer   |Version:  1.6
  (models, ORM)  |   Keywords:  queryset timedelta
 Severity:  Normal   |  expression regression
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+-
 This appears to be a regression in 1.6. Possibly refs #16759.

 Looks like expression nodes are no longer deep copied, so when a query
 that uses `DateModifierNode` is cloned, the second clone to be evaluated
 will generate an exception when the `DateModifierNode` tries to pop the
 timedelta off `node.children`.

 Suspected fix is to persist the timedelta as an attribute on
 `DateModifierNode` expression in `__init__` so we don't need to pop it off
 `node.children` when the node is evaluated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.8e655e8784b1364ae6b9e5cce1bf2aa8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.