Re: [Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+-
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.6
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"1a2939bc26b7077e3196cea9bce52826ec7a6d9d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="1a2939bc26b7077e3196cea9bce52826ec7a6d9d"
 [1.6.x] Fixed #22245 -- Avoided widget overwrite in forms.IntegerField
 subclasses

 Thanks Jeroen Pulles for the report and Simon Charette for the review.
 Backport of 5a976b4bec7 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.973f092e29fbaefc6165de970024c5f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+-
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.6
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5a976b4bec79cdb6b75581be6478356fb13fda77"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5a976b4bec79cdb6b75581be6478356fb13fda77"
 Fixed #22245 -- Avoided widget overwrite in forms.IntegerField subclasses

 Thanks Jeroen Pulles for the report and Simon Charette for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.67ac4b026bcaa76c019251870b01a32d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+-
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by charettes):

 * stage:  Accepted => Ready for checkin


Comment:

 Patch looks RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.01f06af1de1c7f83e6514142dd476a51%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.369832e3b719c8b80ba125ee8c4328d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.6
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.947a878ce3e9dea13101b02471b24875%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22245: Widget on DecimalField subclass ignored

[Django]

#22245: Widget on DecimalField subclass ignored
-+
 Reporter:  jeroen.pulles@…  |  Owner:  nobody
 Type:  Uncategorized| Status:  new
Component:  Forms|Version:  1.6
 Severity:  Normal   |   Keywords:
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+
 I have a subclass of DecimalField with a widget member set, like so:

 {{{
 class ParameterField(DecimalField):
 widget = ParameterWidget
 }}}

 This works in Django 1.5 (by way of the constructor of Field, I guess).
 Django 1.6 doesn't pick up the specialised widget. IntegerField does a
 setdefault on widget that I can't follow:

 {{{
 class IntegerField(Field):
 ...

 def __init__(self, max_value=None, min_value=None, *args, **kwargs):
 self.max_value, self.min_value = max_value, min_value
 kwargs.setdefault('widget', NumberInput if not
 kwargs.get('localize') else self.widget)
 super(IntegerField, self).__init__(*args, **kwargs)
 }}}

 Adding `localize = False` to the ParameterField class doesn't help because
 that doesn't make it appear in kwargs for IntegerField.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2c2698f485091c72a56863654c863989%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.