Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+-
 Reporter:  abhishek.garg@…  |Owner:  Tim
 |  Graham 
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ec6121693f112ae33b653b4364e812722d2eb567" ec61216]:
 {{{
 #!CommitTicketReference repository=""
 revision="ec6121693f112ae33b653b4364e812722d2eb567"
 Fixed #22383 -- Added support for HTML5 required attribute on required
 form fields.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.9f8c8730ecb05f9d03700ec96c41506d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+-
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.2d8970559c94828d37ea2876de09def0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jdufresne):

 * needs_better_patch:  1 => 0


Comment:

 > I've left some comments for improvement on the pull request.

 I have addressed all comments in the PR. All additional feedback is
 welcome. Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.c7d94d012e64231d08c3d1ba456409aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 For the record, Loic dropped his suggestion of a deprecation cycle: "I
 guess people can easily add `novalidate` to their `` to opt out of
 that".

 I've left some comments for improvement on the pull request.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.95601113b9c71aad2b86802a9d2feb92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jdufresne):

 From Alex Riina in the thread:

 > What's the plan for formsets with extra?
 >
 > I could see the required only getting applied to the first min forms but
 I'm not sure there is an actual workable case there. It seems like it will
 get too messy with adding and deleting at the same time.
 >
 > If can_delete is false and extra is 0, it seems like the required
 attribute could at least be used. Because of this, I think it should
 probably be an initialization argument, default to false, or be overridden
 when constructing forms in formsets.

 Updated PR based on this feedback. The required attribute is no longer
 applied to formsets by default. Can now override the
 `Form.use_required_attribute` value by passing the kwarg
 `use_required_attribute` to the form's constructor.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.47e42e1f1bcde3ce5354ac4eb6e23cec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 New [https://groups.google.com/d/topic/django-
 developers/OEcRKkV_6cw/discussion django-developers thread].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.fba5e5ba9acb8f024a62135b4e73188e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jdufresne):

 > I guess I'm not sure if a deprecation path provides more value than
 making a backwards-incompatible change.

 I've added alternative PR that skips the deprecation cycle:
 . It uses the same
 `Form.use_required_attribute` approach as the previous PR.

 I'll follow through with mailing list to get other opinions.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.9f1eb95d49a57d1b4c20d68fd70a34bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 I guess I'm not sure if a deprecation path provides more value than making
 a backwards-incompatible change. For example, if we expect a majority of
 projects to adopt this change, then a deprecation will require every
 Django project to silence the warning instead of a subset of users to opt-
 out. Maybe you could try to get some other opinions on the
 [https://groups.google.com/d/topic/django-
 developers/obw18wSc4xU/discussion mailing list thread].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.8919117253a7eb03cd21cd2200711af3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jdufresne):

 > I fear the deprecation will be quite annoying if every form in a project
 needs to be modified to silence all warnings.

 Alternatively, a project could monkey patch the base form class to set a
 `True`/`False` default for `use_required_attribute`. I could document this
 technique if you agree with the approach.

 > A project could provide custom widget templates if they don't want the
 required attribute (or if they want required='required'.

 Wouldn't this still require a deprecation path such that the `required`
 attribute isn't set by default until a future version? In this scenario
 where would warning be produced? Would the project need to override all
 templates to squelch all warnings?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.1c130a913c5b4b8a9106ca41e372a616%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 I fear the deprecation will be quite annoying if every form in a project
 needs to be modified to silence all warnings. I wonder if template-based
 widget rendering (#15667) might ease this change. A project could provide
 custom widget templates if they don't want the `required` attribute (or if
 they want `required='required'`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.4013265803113ed86c68b9a843f12a03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jdufresne):

 * cc: jon.dufresne@… (added)
 * has_patch:  0 => 1


Comment:

 Implemented {{{use_required_attribute}}} as described above.

 https://github.com/django/django/pull/6341

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.1ef2240599d3058d5a6a8ea4ebfea8d3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * owner:  anubhav9042 =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.9497380c5f7202c5502b55e232088e46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by melinath):

 FTR, there are (potentially) backwards-compatibility issues regarding the
 "required" attribute and formsets. See https://github.com/gregmuellegger
 /django-floppyforms/issues/75

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.5318e0a60f10adc735dbc159ba8be486%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by anubhav9042):

 https://groups.google.com/forum/#!topic/django-developers/obw18wSc4xU

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.817a0f4f789c7e0d3bfa39e843330050%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by anubhav9042):

 I am in favor for accelerated deprecation, although I don't know if it'll
 allowed here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.c19efe9c0c1d64bf618769d7c0f672f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by loic84):

 So sum up what's been discussed on IRC:

 I didn't suggest a quick deprecation cycle, but a normal deprecation cycle
 based on the value of a boolean. (btw, even if we did a faster
 deprecation, that would be using a subclass of DeprecationWarning, not
 just Warning)

 To deprecate you could do:

 {{{
 class form.Form(object):
 #...
 use_required_attribute = None

 class BoundField(object):
 #...
 def as_widget():
 if self.form.use_required_attribute is None:
 warnings.warn()
 elif form.use_required_attribute:
 attrs['required'] = True
 }}}

 Now what happens next depends on the actual goal, do we want to use
 `use_required_attribute` as a permanent way to control this feature, or as
 a mere deprecation tool.

 Personally I'm not thrilled by this feature, although I know lot of people
 will want it, so I'd like to keep the switch.

 Another point of interest, right now there is no way to tell a form that
 it should render as HTML4 or HTML5. When we discussed #20684 we
 acknowledged that if someone really cared about HTML4 validation, they
 could use `required="required"` instead of `required=True`, but if this
 becomes the default and we kill `use_required_attribute`, we'd be
 outputting HTML5.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.b066862ebfe749f911376e3ce83f708e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by anubhav9042):

 Replying to [comment:10 loic84]:
 > Having the `required` HTML5 attribute changes the browser behavior
 significantly. If we want it on by default, then I think we need a
 deprecation period, maybe the strategy used for #20684 can be applied
 here?

 I like this approach.
 We can add the optional behaviour now with a warning that it would be made
 default in 1.9.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.e910abd14a4e5216b211a28b545d3621%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by loic84):

 Having the `required` HTML5 attribute changes the browser behavior
 significantly. If we want it on by default, then I think we need a
 deprecation period, maybe the strategy used for #20684 can be applied
 here?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.214e1fbb6e74ee598b4852d418c12d35%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+---
 Reporter:  abhishek.garg@…  |Owner:  anubhav9042
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---
Changes (by anubhav9042):

 * status:  new => assigned
 * owner:  nobody => anubhav9042


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.26a8d2b05fca8b8799b48ff067587a13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anubhav9042):

 Ok.
 Wouldn't it be better to provide people to choose whether they want to go
 the conventional way or other just like in case of `required_css_class`

 But also as Tim Graham says "I don't think the feature will be used very
 much if it isn't turned on by default." also seems valid situation.

 Thoughts?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.1eb064a5122804e4b7332ee6d75f79c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timo):

 A form attribute doesn't seem like the most elegant solution, but it's
 consistent with other form attributes like `Form.required_css_class` and I
 cannot think of a better way. A setting is obviously a no-go...

 I suggest calling it `use_required_attribute` instead of
 `required_html_tag`. IMO, I think most people would want this behavior so
 the attribute could default to `True` and people could opt-out by setting
 it to `False`. It would just need to be noted in the release notes as a
 backwards incompatible change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.c50b6cb47db1c93610b7d8181cdbf8c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anubhav9042):

 I did some work here:
 https://github.com/coder9042/django/compare/ticket_22383?expand=1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.d71f5b4741ba31a9138a41f874f4c0f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anubhav9042):

 Loic suggested that this would be good as an optional feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.2ea1f11be2e349945d06778c68487b81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anubhav9042):

 Replying to [comment:3 timo]:
 > Are there any backwards compatibility concerns? For example, what if
 someone is not using an HTML5 doctype?

 I don't think there is any problem, if `` is not used, then
 form does not gets submitted just as the case when doctype is used. The
 only difference is that the help message does not pops out.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.b7de64c22b463a87becbe6eaeffd20d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timo):

 Are there any backwards compatibility concerns? For example, what if
 someone is not using an HTML5 doctype?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.7ec30387cb75982302a0818cc2546377%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22383: Add the required tag to the input fields which are required for database entry (was: Django form auto add requried tag)

[Django]

#22383: Add the required tag to the input fields which are required for database
entry
-+
 Reporter:  abhishek.garg@…  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by anubhav9042):

 * cc: anubhav9042@… (added)
 * version:  1.6 => master
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/084.7ed17f9474fbe8a51e459dc870ee093c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.