Re: [Django] #22477: Incompatible Global Settings

2014-04-21 Thread Django 
#22477: Incompatible Global Settings
--+
 Reporter:  mlavin|Owner:  mlavin
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 It's a bit late in the 1.7 release cycle to make this change, so I suggest
 we do it in 1.8. Note that PRs should always be against master anyway; we
 then backport from there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c05779b438bb4006a0946eece7c017ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22477: Incompatible Global Settings

2014-04-20 Thread Django 
#22477: Incompatible Global Settings
---+--
 Reporter:  mlavin |Owner:  mlavin
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by mlavin):

 * has_patch:  0 => 1


Comment:

 Added a PR against 1.7.x https://github.com/django/django/pull/2591. If
 you feel like this shouldn't be back-ported I'll fix to submit vs master.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cc26a15a7350cebb3069f9d4a8db811f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22477: Incompatible Global Settings

2014-04-19 Thread Django 
#22477: Incompatible Global Settings
---+--
 Reporter:  mlavin |Owner:  mlavin
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by mlavin):

 * owner:  nobody => mlavin
 * status:  new => assigned


Comment:

 The first case of people who have removed the declaration could be handled
 through the system checks similar to the warning for the change to the
 {{{TEST_RUNNER}}} setting:
 
https://github.com/django/django/blob/master/django/core/checks/compatibility/django_1_6_0.py

 I would personally rather fix them piecewise at least on the ticket basis.
 I know there are larger movements within the community to try to remove or
 simplify the settings (there are currently 6 settings just for the CSRF
 cookie) but sweeping changes are difficult to move through the process.
 Waiting on a more general solution to global settings is letting better be
 the enemy of done. To me this is a clear inconsistency which is simple to
 fix and document, it's unlikely to impact many users and some (though not
 all) of the rare users who might be bitten by this change can be warned
 through the system checks.

 I'll put together a PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.15c5a5decda76385be6dd7eca44b4951%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22477: Incompatible Global Settings

2014-04-19 Thread Django 
#22477: Incompatible Global Settings
---+--
 Reporter:  mlavin |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Indeed, this is inconsistent, but it should hardly ever crop up in
 practice.

 Fixing it technically backwards-incompatible for people who:
 - have removed the declaration from their settings because they're using
 the global default
 - are importing the global default and tweaking it, for instance by
 appending some middleware to the list.

 I believe the global settings could use a much more fundamental overhaul
 and stop pretending they're the documentation for settings -- we have
 ref/settings.txt for this purpose.

 I don't have a strong opinion on how to deal with this. I usually prefer
 tackling problems globally rather than piecewise. But changing a large
 number of defaults could be unpopular!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.67800d1a439f68367d0ee89e969b11b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22477: Incompatible Global Settings

2014-04-19 Thread Django 
#22477: Incompatible Global Settings
---+
 Reporter:  mlavin |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 The app-loading refactor has deprecated importing a model which is not in
 the installed apps #21680. This leads to some incompatible defaults in the
 global settings defaults. In the defaults {{{INSTALLED_APPS}}} is empty
 but {{{MIDDLEWARE_CLASSES}}} contains
 {{{'django.contrib.sessions.middleware.SessionMiddleware'}}} and
 {{{'django.contrib.auth.middleware.AuthenticationMiddleware'}}} which rely
 on the related apps being in the {{{INSTALLED_APPS}}}. Since most users
 create their initial settings via {{{startproject}}} this isn't an issue
 but it still makes for a poor default. It also implies a coupling or
 dependency between Django core and {{{contrib.auth}}} and
 {{{contrib.sessions}}} which doesn't actually exist.

 My recommendation would be to remove any contrib middleware from the
 {{{MIDDLEWARE_CLASSES}}} in the global settings but continue to set them
 in the {{{startproject}}} template which also sets an appropriate
 {{{INSTALLED_APPS}}} setting. Since this setting is created by default in
 {{{startproject}}} I don't think this raises any major backwards
 incompatibility issues.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.f04b5c9d927e095998c25899e73365b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.