Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 If you can confirm that the test suite still passes on Oracle, yes, please
 revert my commit.b

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.62a2f1f38c2ae732046a6553dc81f623%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by shai):

 I feel a little uneasy about  25209715d44562dcbf26f04ed9e0d19ee3c2aa84. I
 think ignoring all backend errors in `close()`, on all backends, may hide
 real problems. For the purpose of this ticket,
 53d97e4fe300f2775b5bb1b8010ec415994fa105 serves the same purpose with much
 narrower focus; more generally, I think we should only catch
 `connection.features.closed_cursor_error_class` -- I don't think we can
 reasonably say that any other error should be silenced.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0ad29ff034bbbf415b6a541e2a405533%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger ):

 In [changeset:"53d97e4fe300f2775b5bb1b8010ec415994fa105"]:
 {{{
 #!CommitTicketReference repository=""
 revision="53d97e4fe300f2775b5bb1b8010ec415994fa105"
 Made sure cursor.close() does not complain if cursor is already closed on
 Oracle

 Refs #22483
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.c13ac3e4ee732a326f0ac8a3cb89cada%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"25209715d44562dcbf26f04ed9e0d19ee3c2aa84"]:
 {{{
 #!CommitTicketReference repository=""
 revision="25209715d44562dcbf26f04ed9e0d19ee3c2aa84"
 Prevented a crash in the cursor wrappers on Oracle.

 Fixed #22483 (again).

 Forwardport of 5cd6429620 from stable/1.7.x
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9c925d99f542a758dff66040bf8688a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aymeric Augustin ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5cd64296205e1b5cc4fc1f7e02e22d62795bb604"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5cd64296205e1b5cc4fc1f7e02e22d62795bb604"
 [1.7.x] Prevented a crash in the cursor wrappers on Oracle.

 Fixed #22483 (again).

 Backport of 0f85103e from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.8e706ed91a8325f6f9ce6848a32b6eb6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  aaugustin
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => assigned
 * owner:  nobody => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.41456aa1f520bf35b38b0da45e60ab74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 One failure persists:
 {{{
 ./runtests.py --settings=test_oracle transactions --failfast
 Testing against Django installed in '/home/tim/code/django/django'
 Creating test database for alias 'default'...
 Creating test user...
 Creating test database for alias 'other'...
 Creating test user...
 E
 ==
 ERROR:
 test_atomic_prevents_queries_in_broken_transaction_after_client_close
 (transactions.tests.AtomicErrorsTests)
 --
 Traceback (most recent call last):
   File "/home/tim/code/django/django/test/testcases.py", line 925, in
 skip_wrapper
 return test_func(*args, **kwargs)
   File "/home/tim/code/django/tests/transactions/tests.py", line 373, in
 test_atomic_prevents_queries_in_broken_transaction_after_client_close
 Reporter.objects.create(first_name="Cuthbert", last_name="Calculus")
   File "/home/tim/code/django/django/db/models/manager.py", line 92, in
 manager_method
 return getattr(self.get_queryset(), name)(*args, **kwargs)
   File "/home/tim/code/django/django/db/models/query.py", line 367, in
 create
 obj.save(force_insert=True, using=self.db)
   File "/home/tim/code/django/django/db/models/base.py", line 603, in save
 force_update=force_update, update_fields=update_fields)
   File "/home/tim/code/django/django/db/models/base.py", line 631, in
 save_base
 updated = self._save_table(raw, cls, force_insert, force_update,
 using, update_fields)
   File "/home/tim/code/django/django/db/models/base.py", line 712, in
 _save_table
 result = self._do_insert(cls._base_manager, using, fields, update_pk,
 raw)
   File "/home/tim/code/django/django/db/models/base.py", line 745, in
 _do_insert
 using=using, raw=raw)
   File "/home/tim/code/django/django/db/models/manager.py", line 92, in
 manager_method
 return getattr(self.get_queryset(), name)(*args, **kwargs)
   File "/home/tim/code/django/django/db/models/query.py", line 916, in
 _insert
 return query.get_compiler(using=using).execute_sql(return_id)
   File "/home/tim/code/django/django/db/models/sql/compiler.py", line 924,
 in execute_sql
 self.query.get_meta().db_table, self.query.get_meta().pk.column)
   File "/home/tim/code/django/django/db/backends/utils.py", line 40, in
 __exit__
 self.close()
 InterfaceError: not connected
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.22ec691d0669755a6005ed3d9bdb9648%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
 Reporter:  timo |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |  1.7-beta-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Hopefully fixed by e74d2183c28467aefc0b87e3fa6d405dbfdea82c (master) and
 9bf890f6f9d137d5b86fd9a6a38fb11c5d21b1af (1.7.x).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.bc0fcbb3b42a5fd2340d428c5e803920%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22483: Oracle test failures due to InterfaceError

[Django]

#22483: Oracle test failures due to InterfaceError
-+-
   Reporter:  timo   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.7-beta-1
  layer (models, ORM)|   Keywords:
   Severity:  Release|  Has patch:  0
  blocker|Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
 Bisected to 2e42c859da42a871244aca36162a0aad2b63c02b (#21239)

 Example:
 {{{
 $ ./runtests.py --settings=test_oracle migrations
 ==
 ERROR: test_migrate (migrations.test_commands.MigrateTests)
 --
 Traceback (most recent call last):
   File "/home/tim/code/django/django/test/utils.py", line 316, in inner
 return test_func(*args, **kwargs)
   File "/home/tim/code/django/django/test/utils.py", line 216, in inner
 return test_func(*args, **kwargs)
   File "/home/tim/code/django/tests/migrations/test_commands.py", line 44,
 in test_migrate
 call_command("migrate", verbosity=0)
   File "/home/tim/code/django/django/core/management/__init__.py", line
 167, in call_command
 return klass.execute(*args, **defaults)
   File "/home/tim/code/django/django/core/management/base.py", line 337,
 in execute
 output = self.handle(*args, **options)
   File "/home/tim/code/django/django/core/management/commands/migrate.py",
 line 145, in handle
 executor.migrate(targets, plan, fake=options.get("fake", False))
   File "/home/tim/code/django/django/db/migrations/executor.py", line 60,
 in migrate
 self.apply_migration(migration, fake=fake)
   File "/home/tim/code/django/django/db/migrations/executor.py", line 94,
 in apply_migration
 migration.apply(project_state, schema_editor)
   File "/home/tim/code/django/django/db/migrations/migration.py", line 97,
 in apply
 operation.database_forwards(self.app_label, schema_editor,
 project_state, new_state)
   File "/home/tim/code/django/django/db/migrations/operations/fields.py",
 line 36, in database_forwards
 field,
   File "/home/tim/code/django/django/db/backends/schema.py", line 392, in
 add_field
 self.execute(sql, params)
   File "/home/tim/code/django/django/db/backends/schema.py", line 95, in
 execute
 cursor.execute(sql, params)
   File "/home/tim/code/django/django/db/backends/utils.py", line 40, in
 __exit__
 self.close()
 InterfaceError: not connected
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.63155fcb1dade55698c50caf50b8a648%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.