Re: [Django] #22507: Sending signal documentation is misleading

[Django]

#22507: Sending signal documentation is misleading
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"b4b63b3832896d00bd9bd9e15c00cb7f1f9ac3ad"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b4b63b3832896d00bd9bd9e15c00cb7f1f9ac3ad"
 [1.6.x] Fixed #22507 -- Clarified nature of the sender argument of signals

 Backport of d1f93e9c1e from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c16a11e4619e8c6cc6b2c29290ac5975%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22507: Sending signal documentation is misleading

[Django]

#22507: Sending signal documentation is misleading
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"abd68b5affaec35e941b49f1b0a4cb8d70c22d7b"]:
 {{{
 #!CommitTicketReference repository=""
 revision="abd68b5affaec35e941b49f1b0a4cb8d70c22d7b"
 [1.7.x] Fixed #22507 -- Clarified nature of the sender argument of signals

 Backport of d1f93e9c1e from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fd4824da8f730f352d8ab6aa330734b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22507: Sending signal documentation is misleading

[Django]

#22507: Sending signal documentation is misleading
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d1f93e9c1e2c61bb06a6f99c80bd9437c5081f2d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d1f93e9c1e2c61bb06a6f99c80bd9437c5081f2d"
 Fixed #22507 -- Clarified nature of the sender argument of signals
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4a9dc76d3d8a5115a2a21b57f0784e1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22507: Sending signal documentation is misleading

[Django]

#22507: Sending signal documentation is misleading
+
   Reporter:  claudep   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 In the documentation of sending signals
 (https://docs.djangoproject.com/en/dev/topics/signals/#sending-signals),
 there is an example where the sender parameter is filled with `self` (an
 instance), while most of the time, sender should be a class (at least it's
 the case in Django's own source code).

 Unless I'm misunderstanding something, I suggest to replace `sender=self`
 by `sender=self.__class__` in the example. And maybe specify that sender
 is a class most of the time. I can do the change if someone confirms that
 issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.32e32e64b06c9d42a916996462f0f3c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.