Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-05-01 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by Tim Graham ):

 In [changeset:"d56267ba57f28395946fadd6401ad7e1606c3cb0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d56267ba57f28395946fadd6401ad7e1606c3cb0"
 [1.7.x] Fixed #22539 -- Copied exclude argument in Model.full_clean() to
 prevent side effects.

 Backport of e2e4cdba11 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.00132e7f75b50e2ede74eec21e8bca3a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-05-01 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e2e4cdba1178ebcfd95c19eb063abd55b4afbcbb"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e2e4cdba1178ebcfd95c19eb063abd55b4afbcbb"
 Fixed #22539 -- Copied exclude argument in Model.full_clean() to prevent
 side effects.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.67fc6a673880f5c61a5355026ca14470%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-05-01 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by maggotfish@…):

 * has_patch:  0 => 1


Comment:

 PR here: https://github.com/django/django/pull/2622

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.5f8509310ffcf15caad51ef170b8dcc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-04-29 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by charettes):

 Yes please, go ahead and make sure to include tests and link the PR to
 this Trac issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.8394541c8e48c24e902f9843137ade62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-04-29 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by anonymous):

 I have patch ready, shall I send a pull request under a new branch
 ticket_22539?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.0b4ae004cc1b036eaeaa0417e8180ce2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22539: Model.full_clean() mutates exclude argument

2014-04-29 Thread Django 
#22539: Model.full_clean() mutates exclude argument
-+-
 Reporter:  maggotfish@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * has_patch:  1 => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.73c7f7de56dc43c1a97514fc9fb310c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22539: Model.full_clean() mutates exclude argument

2014-04-29 Thread Django 
#22539: Model.full_clean() mutates exclude argument
--+
 Reporter:  maggotfish@…  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  1 |  UI/UX:  0
--+
 If model.full_clean() gets a list argument for `exclude`, and after
 running clean_fields() errors are raised, it appends the names of those
 fields to the `exclude` argument, mutating it and causing a really bad
 side effect which is not expected by the user.

 Instead, the list should be copied if it is not None.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.74b4782d9b36985fc1c9bc275cfdd727%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.