Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Sarah
   |  Boyce
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"594fcc2b7427f7baf2cf1a2d7cd2be61467df0c3" 594fcc2]:
 {{{
 #!CommitTicketReference repository=""
 revision="594fcc2b7427f7baf2cf1a2d7cd2be61467df0c3"
 Fixed #22569 -- Made ModelAdmin.lookup_allowed() respect
 get_list_filter().

 Thank you Simon Meers for the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701878f3a8278-6e3409e6-ba5a-48f4-ac50-3a476561a3b3-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Sarah
   |  Boyce
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701878f1d9022-a65c04e0-4bc3-4eca-9b48-32a68ae9c6f3-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Sarah
   |  Boyce
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701878e697df3-cae67255-53f4-42cf-83f2-0dcdc566a09a-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Sarah
   |  Boyce
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701878df3c917-bfc72a54-ed47-493f-8e5a-2362c2d7675a-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Sarah
   |  Boyce
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * owner:  (none) => Sarah Boyce
 * needs_better_patch:  1 => 0
 * status:  new => assigned


Comment:

 https://github.com/django/django/pull/16759

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701877a05910c-cc0b2b00-7be8-4419-a637-6d2695360bf6-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  (none)
   |
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Sarah Boyce (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070186e9cd06c9-77869061-07e7-443b-8805-943c6cc6596f-00%40eu-central-1.amazonses.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  (none)
   |
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Simon Meers => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.f86f6663b034a9ce0b8cced37779de5c%40djangoproject.com.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Simon
   |  Meers
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Meers):

 * needs_better_patch:  1 => 0


Comment:

 I've now got three separate commits for the three tickets involved, and
 three pull requests, though perhaps only this
 https://github.com/django/django/pull/8904 pull request is needed since it
 contains all three commits?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.5d0b7f7dbd63c3c13a3de46ee521cb85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Simon
   |  Meers
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.6a56a1415d05f181fbc66816c0afd5b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Simon
   |  Meers
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Meers):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/8856

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.296342efc39827a11825ae1280b9906a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  Simon
   |  Meers
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Meers):

 * owner:  nobody => Simon Meers
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.5f0c0ffc9df5828de0b5a4f7111be390%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:
   |  parasgithub
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ernestoalejo):

 * cc: contact@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.20e36ecad9374c06fdac3e0551b04419%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:
   |  parasgithub
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by parasgithub):

 * status:  new => assigned
 * owner:  nobody => parasgithub


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.6408524779d055b2bc376061a1a54242%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+-
 Reporter:  Keryn Knight |Owner:  nobody
   |   Status:  new
 Type:  Bug  |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * type:  Uncategorized => Bug
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.bbe11e67c1d8918a0e88242200c19051%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22569: lookup_allowed fails to consider dynamic list_filter

[Django]

#22569: lookup_allowed fails to consider dynamic list_filter
-+
 Reporter:  Keryn Knight   |  Owner:  nobody
 Type:  Uncategorized| Status:  new
Component:  contrib.admin|Version:  master
 Severity:  Normal   |   Keywords:
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+
 Currently, `lookup_allowed` iterates over `self.list_filter` to determine
 valid params. This is technically incorrect since the introduction of
 `get_list_filter()` on `ModelAdmin` in 1.5, because it is possible to
 define a ModelAdmin such that self.list_filter is `()` but
 `get_list_filter` yields SimpleListFilter classes.

 To correct it, the above code would need to change from:
 {{{
 for filter_item in self.list_filter:
 }}}
 to
 {{{
 for filter_item in self.get_list_filter(request):
 }}}
 The problem is that now `lookup_allowed` needs to accept `request` so that
 it can pass it back to `get_list_filter`

 In Django itself, that's actually reasonably acceptable as a change,
 because
 [https://github.com/django/django/search?q=lookup_allowed=cmdform it's
 used infrequently] - the only place it's actually used is in
 
[https://github.com/django/django/blob/274048351ae2fc35995645a6dad7c98f74f51eb1/django/contrib/admin/views/main.py#L96
 ChangeList.get_filters], which has access to the request. However, it is
 overridden
 [https://sourcegraph.com/search?page=1_page=100=lookup_allowed in
 the wild] without accept `*args, **kwargs`, so it'd not be easy to provide
 a clean upgrade path.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.6363f69d9232e31a7e444ab08eca2a94%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.