Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => needsinfo
 * stage:  Accepted => Unreviewed


Comment:

 Ad, Thanks for checking!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.2234cd667f0df3511a81a15558b21f67%40djangoproject.com.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ad Timmering):

 @Mariusz: Thanks for cc'ing me. Would be happy to add some tests, however
 have been unable to replicate the behavior.

 Forcably letting `msgmerge` throw errors (by pausing the `makemessages`
 process and messing up the intermediate file on purpose), does for me
 (a) give sensible error messages, and
 (b) they are actually displayed together with the `CommandError`.
 I searched SO etc. for other users with similar issues, but unfortunately
 couldn't find an example to build a test around.

 I suggest closing as `needsinfo`, pending the original author or someone
 else to provide an example of a case where the error message given with
 the exception does not provide enough information.


 Example of an intentionally broken run:
 {{{
 (env) awtimmering @ ~/djtest $ ./manage.py makemessages  --locale nl
 processing locale nl
 CommandError: errors happened while running msgmerge
 /home/awtimmering/djtest/locale/django.pot:49: keyword "msgid_plasdural"
 unknown
 /home/awtimmering/djtest/locale/django.pot:45: missing 'msgstr' section
 /home/awtimmering/djtest/locale/django.pot:49:16: syntax error
 msgmerge: found 3 fatal errors
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8f3c4d36870cfed7d5ba92d55c994527%40djangoproject.com.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Ad Timmering (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.55a6c203737df3d2ac29dbe4ccf436a9%40djangoproject.com.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by berkerpeksag):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.f3621f73bf4a906fd2c7ea58b51af6a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Core (Management |   Resolution:
  commands)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * has_patch:  0 => 1
 * version:  1.6 => master
 * stage:  Unreviewed => Accepted


Comment:

 Let's see if we can get someone to review the patch. Is it feasible to add
 tests?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.d11425619e23485db7ec6fe1785c432d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
-+-
 Reporter:  Cezary.Wagner|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.6
Component:  Core (Management |   Resolution:
  commands)  | Triage Stage:
 Severity:  Normal   |  Unreviewed
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * component:  Uncategorized => Core (Management commands)
 * type:  Uncategorized => Cleanup/optimization


Old description:

> Please replace code in make messages to not delete *.po files if error
> occured and show messages (fix exception later).
>
> Replace this code:
> if errors:
> if status != STATUS_OK:
> raise CommandError(
> "errors happened while running msgmerge\n%s" %
> errors)
> elif self.verbosity > 0:
> self.stdout.write(errors)
>
> With this code (it shows error root cause and save/copy *.po need to
> solve this error):
>
> if errors:
> if status != STATUS_OK:
> self.stdout.write(errors) # bug exception bellow not
> shows errors
> import shutil
> shutil.copyfile(pofile, '%s.debug' % pofile)
> raise CommandError(
> "errors happened while running msgmerge\n%s" %
> errors)
> elif self.verbosity > 0:
> self.stdout.write(errors)
>
> All modules using command line tools should report errors and not delete
> input if error occured.

New description:

 Please replace code in make messages to not delete *.po files if error
 occurred and show messages (fix exception later).

 Replace this code:
 {{{
 if errors:
 if status != STATUS_OK:
 raise CommandError(
 "errors happened while running msgmerge\n%s" %
 errors)
 elif self.verbosity > 0:
 self.stdout.write(errors)
 }}}
 With this code (it shows error root cause and save/copy *.po need to solve
 this error):
 {{{
 if errors:
 if status != STATUS_OK:
 self.stdout.write(errors) # bug exception bellow not
 shows errors
 import shutil
 shutil.copyfile(pofile, '%s.debug' % pofile)
 raise CommandError(
 "errors happened while running msgmerge\n%s" %
 errors)
 elif self.verbosity > 0:
 self.stdout.write(errors)
 }}}
 All modules using command line tools should report errors and not delete
 input if error occurred.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ce10b1ebc861583e69b4f4310d22b0e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by areski):

 It seems there is some confusion with this ticket, to clarify:

  - `keep-pot` option ONLY prevent Django from deleting the temporary .pot
  - this patch ensure that we don't delete the original PO file when
 `msgmerge` fails.

 I haven't be able to test it as I guess it's a bit tricky to make
 `msgmerge` fails.
 The PR looks good but I would recommend to move 'import shutil' at the top
 of the file.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.46070196f897978a42d6960cbea58e6b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Cezary.Wagner):

 It is not solve still "Messages from msgmerge is not presented since bug -
 exception blocks print out." is in force!

 You need to known where in django template there is error - --keep-pot
 allow nothing in this case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.01848dfe42dd49bf774f934b2e13db01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Cezary.Wagner):

 * status:  closed => new
 * resolution:  needsinfo =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.779c752952c8df2bbfeb4234bc715b6e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by anonymous):

 You not understand this bug really - it is not problem of *.pot bit *.po
 file. As far as I remember there is not help if I use --keep-pot.

 It not helps :)

 Read it again "Messages from msgmerge is not presented since bug -
 exception blocks print out." - I will reopen until we will find some
 solution - I will not give up now ...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.3f4742e214e8a7764d2e5ece484706be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * status:  new => closed
 * resolution:   => needsinfo


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.9a85790753e11851f3605c922b3ced70%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by timo):

 I will let someone more familiar with `makemessages` make a call on
 whether or not anything needs to be done here, but for some more context,
 I also closed #22615 and #22616 which are related.

 I do see `--keep-pot` in the help for `makemessages` on 1.6 (I'm not sure
 if that's what you are saying in the above comment).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.716592cc6589e84af6d2dc6eb2b06dba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Cezary.Wagner):

 Push Request on github is related.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.207bfbc10fde5ea46342bd1b9b15f29c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Cezary.Wagner):

 Not known about such option but should not help too much since many bugs
 is in code - see my pulls on github.

 1. Messages from msgmerge is not presented since bug - exception blocks
 print out.
 2. --keep-pot is not presented in --help I think so (not checked but never
 seen it before - o.k. since it from 1.6).

 I think problem is with "blocktrans" on 60% - I gave up now - I was done
 very large project more than 1k strings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.9c56aac723083cd2a07b94e7235d300e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by timo):

 This [https://github.com/django/django/pull/2648 PR] appears related.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a3bf4ea90de0af49136f94bff60de8b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+--
 Reporter:  Cezary.Wagner  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Does the [https://docs.djangoproject.com/en/1.6/ref/django-admin/#django-
 admin-option---keep-pot --keep-pot] option not help?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.52c6d3a5d1993b4ae7f8e52ecbe5287e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22617: Allow to fix translation -> Fix makemessages to not delete debug data and hide errors (and all similar modules using "msgmerge")

[Django]

#22617: Allow to fix translation -> Fix makemessages to not delete debug data 
and
hide errors (and all similar modules using "msgmerge")
---+
 Reporter:  Cezary.Wagner  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.6
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Please replace code in make messages to not delete *.po files if error
 occured and show messages (fix exception later).

 Replace this code:
 if errors:
 if status != STATUS_OK:
 raise CommandError(
 "errors happened while running msgmerge\n%s" %
 errors)
 elif self.verbosity > 0:
 self.stdout.write(errors)

 With this code (it shows error root cause and save/copy *.po need to solve
 this error):

 if errors:
 if status != STATUS_OK:
 self.stdout.write(errors) # bug exception bellow not
 shows errors
 import shutil
 shutil.copyfile(pofile, '%s.debug' % pofile)
 raise CommandError(
 "errors happened while running msgmerge\n%s" %
 errors)
 elif self.verbosity > 0:
 self.stdout.write(errors)

 All modules using command line tools should report errors and not delete
 input if error occured.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.0c3ed1d7ead768046c2cf03888484094%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.