Re: [Django] #22618: Documentation about import_string unclear

[Django]

#22618: Documentation about import_string unclear
-+-
 Reporter:  ewjoachim|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"0bb90de869303f4e0fc9479391fde7c68b4088a0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0bb90de869303f4e0fc9479391fde7c68b4088a0"
 [1.7.x] Fixed #22618 -- Improved import_string example.

 Thanks ewjoachim for the sugggestion.

 Backport of c501662f3c from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.68d502c6280a180247d555ea2e45d5b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22618: Documentation about import_string unclear

[Django]

#22618: Documentation about import_string unclear
-+-
 Reporter:  ewjoachim|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c501662f3c3f03876effcf3ede94922c0cec43bd"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c501662f3c3f03876effcf3ede94922c0cec43bd"
 Fixed #22618 -- Improved import_string example.

 Thanks ewjoachim for the sugggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f08211a673f9b5bf5c4f208e183b4a55%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22618: Documentation about import_string unclear

[Django]

#22618: Documentation about import_string unclear
-+-
 Reporter:  ewjoachim|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 If we replaced the example with something like: `ValidationError =
 import_string('django.core.exceptions.ValidationError')` would that
 address your concerns?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.06e91f4fa36cdc2b66caaebcfd6612be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22618: Documentation about import_string unclear

[Django]

#22618: Documentation about import_string unclear
--+
 Reporter:  ewjoachim |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 I found about import_string and import_by_path from
 django.utils.module_loading, and read their doc :
 https://docs.djangoproject.com/en/dev/ref/utils/#module-
 django.utils.module_loading

 I have the feeling that the example is not chosen wisely as :
  - import_string raises an ImportError
  - but it replaces import_by_path that used to raise an
 ImproperlyConfigured error
  - And in the example, the function is used to load the
 ImproperlyConfigured class.

 It may leave the fast reader or the beginner under the impression that
 this function '''returns''' an error when called with incorrect
 parameters. Or at least serious doubts.

 (Additionaly, transition code could be provided but that's not as
 important)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.2447e0b88812f5de6828503313c85839%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.