Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"45e47f7b95aad98d91bb40e19dda14ae120980a4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="45e47f7b95aad98d91bb40e19dda14ae120980a4"
 [1.7.x] Fixed #22653 -- Added some database feature flags to tests.

 Thanks Rahul Priyadarshi.

 Backport of 99f5ea9cc8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.df52edc95021ec5f00426d798d6db9b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"99f5ea9cc8f41724e07b88c6142d0092961ce5e0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="99f5ea9cc8f41724e07b88c6142d0092961ce5e0"
 Fixed #22653 -- Added some database feature flags to tests.

 Thanks Rahul Priyadarshi.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.07f22418cfc10f4276ece651c5a5bd92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by rahul.priyadarshi@…):

 MySQL + SQLite can defer the constraint checking  and can support forward
 reference until the end of the transaction. These test cases doing all the
 operation within a transaction only that's why these test case passes with
 MySQL+SQLite.

 But it is not in case of dtatabse like DB2, which strictly follow
 constraint checking and can't defer it within a transaction also.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.5e53f315ca0a4b49217c63efe0ecce75%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by timo):

 Couple of things I noticed:

 * The MySQL backend has `supports_forward_references=False`
 ([https://github.com/django/django/commit/121d2e36#diff-
 dbe1511db54b8fff2cb72a199cf37b4cR127 blamed to 121d2e36]), but after
 removing that (which changes it to True) the tests still pass (i.e. the
 existing test that has
 `@skipUnlessDBFeature('supports_forward_references')` is currently skipped
 on MySQL, but works fine). This issue is not necessarily related to this
 patch, except that additional tests that current pass on MySQL will be
 skipped. I'm not sure if `supports_forward_references=False` can be
 removed or if maybe it is only relevant for particular versions and/or
 storage engines in MySQL.

 * MySQL + SQLite have `can_defer_constraint_checks=False` but
 `admin_views.tests.AdminViewDeletedObjectsTest` and
 `serializers_regress.tests.SerializerTests` current pass (the patch would
 cause them to be skipped).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.44820ff2aec100b1914d21586645cd85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by rahul.priyadarshi@…):

 Yes, It would be good if always use {{{skipUnlessDBFeature}}}. In new
 attached patch(patch2.diff) I have made this modification.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.a1d0cb91a05394871c2a3fd17016d456%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by manfre):

 Why does the patch use `skipUnlessDBFeature` in some places and
 `skipUnless` in others? Why not always use `skipUnlessDBFeature`?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.f5ac5e35021430e27c20fb220a88ccd4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+-
 Reporter:  rahul.priyadarshi@…  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Testing framework|  Version:
 Severity:  Normal   |  1.7-beta-2
 Keywords:   |   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.d7efb5b165b90669a076c5fdf23c6bc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22653: Need to add database features flag in some of the test cases

[Django]

#22653: Need to add database features  flag in some of the test cases
-+
 Reporter:  rahul.priyadarshi@…  |  Owner:  nobody
 Type:  Uncategorized| Status:  new
Component:  Testing framework|Version:  1.7-beta-2
 Severity:  Normal   |   Keywords:
 Triage Stage:  Unreviewed   |  Has patch:  1
Easy pickings:  0|  UI/UX:  0
-+
 Some of the Database backend doesn't allow to defer constraints check like
 DB2 which doesn't allow to defer constraint check within a transaction
 also

 Following test cases requires to check can_defer_constraint_checks
 i) test cases under admin_views.tests.AdminViewDeletedObjectsTest test
 class
 ii) test cases under serializers_regress.tests.SerializerTests test class

 Following test cases requires supports_forward_references flag check
 i) serializers.SerializersTransactionTestBase.test_forward_refs
 ii)
 fixtures_regress.TestFixtures.test_loaddata_works_when_fixture_has_forward_refs
 iii)
 fixtures_regress.TestFixtures.test_loaddata_forward_refs_split_fixtures

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.86d8e13f740f4e78ab7ca66ef4aec0a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.