Re: [Django] #22826: Simplify Query.setup_joins

[Django]

#22826: Simplify Query.setup_joins
-+-
 Reporter:  jorgecarleitao   |Owner:
 Type:   |  jorgecarleitao
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jorge C. Leitão ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e66896226a41eb9e56b08d7adf29b44c0cd87dad"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e66896226a41eb9e56b08d7adf29b44c0cd87dad"
 Fixed #22826 -- Improved internal usage of Query.setup_joins.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b61c3bb2de3316a4c1bb8f0b48063603%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22826: Simplify Query.setup_joins

[Django]

#22826: Simplify Query.setup_joins
-+-
 Reporter:  jorgecarleitao   |Owner:
 Type:   |  jorgecarleitao
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marc Tamlyn ):

 In [changeset:"dd57b89fcb8f009fc73f16efea9539e5888eb59d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="dd57b89fcb8f009fc73f16efea9539e5888eb59d"
 Merge pull request #2806 from jorgecarleitao/issue22826

 Fixed #22826 -- Improved internal usage of Query.setup_joins.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bad269a28ce47679b9c4b852acae2a5a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22826: Simplify Query.setup_joins

[Django]

#22826: Simplify Query.setup_joins
-+-
 Reporter:  jorgecarleitao   |Owner:
 Type:   |  jorgecarleitao
  Cleanup/optimization   |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jorgecarleitao):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.72bd739e17d4b0724e75b5ba57182de1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22826: Simplify Query.setup_joins

[Django]

#22826: Simplify Query.setup_joins
-+-
 Reporter:  jorgecarleitao   |Owner:
 Type:   |  jorgecarleitao
  Cleanup/optimization   |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jorgecarleitao):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This is easier to explain with code... I will submit a PR to explain what
 I mean.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.44c3a6e3409b0ea269839e97d19129e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22826: Simplify Query.setup_joins

[Django]

#22826: Simplify Query.setup_joins
--+
 Reporter:  jorgecarleitao|  Owner:  jorgecarleitao
 Type:  Cleanup/optimization  | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Currently, not all arguments returned by Query.setup_joins are being used
 all the times.

 On the other hand, some arguments are systematically being used in common
 things (e.g. join_list[-1])

 I propose to have a minor cleanup on these as part of an effort to
 simplify the entanglement between
 Query, SQLCompiler, and SQLEvalutor.

 This is a minor simplification and doesn't affect any public API.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.ab9cf60b64371c0186f26ab6b2445742%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.