Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
-+-
 Reporter:  scottanderson|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |   Resolution:  duplicate
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  syncdb   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 In any case, custom sql loading is handled in #3214.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.7981b66062eab3a75002f8361699fd4b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
-+-
 Reporter:  scottanderson|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  syncdb   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by merb):

 this ticket seems to be fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.078e018a61ea247e5d16ec680c72028a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
-+-
 Reporter:  scottanderson|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  syncdb   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by claudep):

 I think that the parsing solution leads us nowhere. It is not fair to
 penalize all backends because some cannot execute multiple statements.
 IMHO, we should have a backend-specific `load_sql` that take care of
 either splitting the statements or to feed the database with the read file
 at once.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
--+-
  Reporter:  scottanderson| Owner:  nobody
Status:  new  | Milestone:
 Component:  django-admin.py  |   Version:  SVN   
Resolution:   |  Keywords:  syncdb
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  1|  
--+-
Changes (by adamnelson):

  * needs_better_patch:  0 => 1

Comment:

 From Jeremy Dunck (http://groups.google.com/group/django-
 developers/browse_thread/thread/a60a582d1e0a562b/cfca983bfe633b80):

 ... the current status is captured in
 comments 11 through 14 -- that the logic for executing initial SQL
 breaks in cases where extended SQL syntax (such as pgsql's DECLARE)
 includes quoted text, etc.
 You can see the Malcolm objected to the latest patch in 11, and
 !ScottAnderson objected to it in 13.
 Certainly, the patch needs improvement because it doesn't include any
 test cases.  Possibly, the patch as-is isn't good for the reasons
 Malcolm listed, but it's hard for me to tell without doing my own
 testing.  I'd mark patch-needs-improvement.  If you're feeling more
 ambitious, I'd suggest coming up with a set of initial SQL files that
 exercise the assumptions of the loading code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
--+-
  Reporter:  scottanderson| Owner:  nobody
Status:  new  | Milestone:
 Component:  django-admin.py  |   Version:  SVN   
Resolution:   |  Keywords:  syncdb
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Comment (by anonymous):

 Replying to [comment:19 russellm]:
 > Reverting some unhelpful status changes
 no not this time

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
--+-
  Reporter:  scottanderson| Owner:  nobody
Status:  new  | Milestone:
 Component:  django-admin.py  |   Version:  SVN   
Resolution:   |  Keywords:  syncdb
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * needs_better_patch:  1 => 0
  * component:  django.contrib.databrowse => django-admin.py
  * version:  1.0-alpha => SVN
  * milestone:  post-1.0 =>
  * owner:  anonymoushgjdhj  vf => nobody
  * needs_docs:  1 => 0

Comment:

 Reverting some unhelpful status changes

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
+---
  Reporter:  scottanderson  | Owner:  
anonymoushgjdhj  vf
Status:  new| Milestone:  post-1.0  
 
 Component:  django.contrib.databrowse  |   Version:  1.0-alpha 
 
Resolution: |  Keywords:  syncdb
 
 Stage:  Accepted   | Has_patch:  1 
 
Needs_docs:  1  |   Needs_tests:  1 
 
Needs_better_patch:  1  |  
+---
Changes (by anonymous):

  * needs_better_patch:  0 => 1
  * component:  django-admin.py => django.contrib.databrowse
  * version:  SVN => 1.0-alpha
  * milestone:  => post-1.0
  * owner:  nobody => anonymoushgjdhj  vf
  * needs_docs:  0 => 1

Comment:

 Replying to [ticket:2284 scottanderson]:
 > Extra .sql files in /sql directories break syncdb when the files have
 whitespace.
 >
 > Example:jgnjn   njngjnj jnj koijiojij jiojiojibvj iojiojbio jiojioji ji
 jiojio joi joijoijovijfiji ijoijkioj  iojoij oij oijioj iojio joijiojioj
 iojioj ioj
 >
 > CREATE TABLE "forum_post_fulltext" (
 > etc...
 >   ) WITHOUT OIDS;
 >
 > CREATE INDEX idxcontent ON forum_post_fulltext USING gist (content_idx);
 >
 > CREATE INDEX idxposttree ON forum_post (thread_id, leftid, rightid);
 >
 > CREATE FUNCTION f_post_insert() RETURNS trigger AS '
 > ... etc. ...
 > ' LANGUAGE plpgsql
 > ;
 >
 > The above will cause syncdb to display errors.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #2284: [patch] Extra /sql files with whitespace break syncdb

[Django]

#2284: [patch] Extra /sql files with whitespace break syncdb
--+-
  Reporter:  scottanderson| Owner:  nobody
Status:  new  | Milestone:
 Component:  django-admin.py  |   Version:  SVN   
Resolution:   |  Keywords:  syncdb
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  1 
Needs_better_patch:  0|  
--+-
Changes (by adrian):

  * component:  Tools => django-admin.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---