Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
--+
 Reporter:  rm_   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  1
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"68c9a72e29c929d896a25b3a0f566c09b6723dd4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="68c9a72e29c929d896a25b3a0f566c09b6723dd4"
 Fixed #22894 -- Made admin add related/raw ID fields widgets customizable.

 Decoupled behavior and style from the RelatedFieldWidgetWrapper and
 ForeignKeyRawIdWidget.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.93844afd7ac6ed0befa4722f30f9440b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
--+
 Reporter:  rm_   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  1
--+

Comment (by rm_):

 Thanks for the review Tim, pull requests updated with these changes:
 - added title to 
 - splitted css blocks
 - renamed template block
 - splitted long lines in tests

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.f6cb5226cfe9a09579c005b04861e618%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
--+
 Reporter:  rm_   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  1
--+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.d13c06c526c87c339b1304e6b17ba873%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
-+-
 Reporter:  rm_  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by timo):

 Yes, please add it to the PR and I'll add some comments.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.a608b5731ced4dd977b5cd76b936ce6c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
-+-
 Reporter:  rm_  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by rm_):

 If change looks ok i've done the same for raw_id_fields widget and unified
 common js code here
 https://github.com/xrmx/django/commits/morepopupcleanup

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.60c83205b8e1a9a38fb8e73fb12a6ecf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
-+-
 Reporter:  rm_  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by rm_):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request here https://github.com/django/django/pull/2847

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.b8be8c435301b8561475b7168cf85ada%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22894: make admin add related behaviour customizable

[Django]

#22894: make admin add related behaviour customizable
--+
 Reporter:  rm_   |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  contrib.admin |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  1
--+
 Decouple behaviour and style from the RelatedFieldWidgetWrapper widget so
 it's easier to customize.
 This makes life easier for people that want to say use a modal or just
 style it differently.

 While at it in change_form.html start consolidating document ready event
 listeners in one place.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/046.1a8fe23f9b97df5a6e8c19c0e361bc86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.