Re: [Django] #22909: Fix camelCase test names

2020-11-29 Thread Django
#22909: Fix camelCase test names
-+-
 Reporter:  Tim Graham   |Owner:  Brylie
 Type:   |  Christopher Oxley
  Cleanup/optimization   |   Status:  closed
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"58740c0d7f441e7a12e5847fcd7409a78d9edd7b" 58740c0d]:
 {{{
 #!CommitTicketReference repository=""
 revision="58740c0d7f441e7a12e5847fcd7409a78d9edd7b"
 Refs #22909 -- Removed camelCasing in auth_tests.test_templates tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.38412ded4c1e2f0eb50da2523a612247%40djangoproject.com.


Re: [Django] #22909: Fix camelCase test names

2014-07-08 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by timo):

 I moved the dispatch tests in 136a3ffe21988d49e443867d129cc01fb62b34cd and
 created #22979 for moving the bug tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.fba109cd43fcf97fb19d0b40bc02e7b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-07-07 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"28962c57f3f2b4543cd67d55ca635e9198f585dd"]:
 {{{
 #!CommitTicketReference repository=""
 revision="28962c57f3f2b4543cd67d55ca635e9198f585dd"
 [1.7.x] Fixed #22909 -- Removed camelCasing in some tests.

 Thanks brylie.

 Backport of 89b9e6e5d6 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.4aeded07551decea8fcf853795eefc7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-07-07 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"89b9e6e5d68297e7fe10baea6abcd96e24de0e09"]:
 {{{
 #!CommitTicketReference repository=""
 revision="89b9e6e5d68297e7fe10baea6abcd96e24de0e09"
 Fixed #22909 -- Removed camelCasing in some tests.

 Thanks brylie.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.09871497ae51895c94045682ac7528d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-30 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by brylie):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.4a2f369d8ec0bf8883cb3e4fb5611e99%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-30 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 OK, I have modified the files where I found camel case test names. Please
 review the following changes, so that I may submit a pull request:

   *
 
[https://github.com/brylie/django/commit/e5fbf9087a0ea2e688e7fd351b174c88eba3e5a6
 admin_custom_urls]
   *
 
[https://github.com/brylie/django/commit/b18def65987d7c4903ad00f84b1b42780b09a8d2
 admin_views]
   *
 
[https://github.com/brylie/django/commit/0970cf6149b3f630a0c029b5decb904c5b3aab58
 admin_widgets]
   *
 
[https://github.com/brylie/django/commit/2a935773f8c16c42f5a77ee208d7ac8d8b9f7a71
 conditional_processing]
   *
 
[https://github.com/brylie/django/commit/4931cff49cd56ba8deb705f848f9b1aafb17a516
 dispatch]
   *
 
[https://github.com/brylie/django/commit/e81b0cd48c7fdde48a62ae3727fc45f128b4bed2
 generic_inline_admin]
   *
 
[https://github.com/brylie/django/commit/7051550346830a9ac58c192551900582ca93bf62
 model_fields]
   *
 
[https://github.com/brylie/django/commit/bf34e6190df549374cfec224e6ab91583bbefe6e
 nested_foreign_keys]
   *
 
[https://github.com/brylie/django/commit/f12558b8b9db7f8a43f018c7735ade57ebaf2930
 raw_query]
   *
 
[https://github.com/brylie/django/commit/fa19d6014682fcd01f6014244f31685d02556900
 utils_tests/test_http]
   *
 
[https://github.com/brylie/django/commit/bdbcc5090719bfd9e57ef2f1ff7925e3dbed3a9c
 view_tests/tests/i18n]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.8bfdf0943e42c8f1c4f05d028de8a1a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-30 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 Replying to [comment:18 timo]:
 > * model_fields -- I'd remove the existing camel case for field names.

 Ah, dang. I just went with the opposite and ''added'' camel case to field
 names in tests. I think this is a good strategy for two reasons:
   1. It is consistent with other tests/test suites
   1. It improves readability, which seems to be a priority here

 Does this seem reasonable?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.96927fc5e5fe1130d8fdb7f93b084848%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-30 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 Replying to [comment:1 brylie]:
 > The '''admin_custom_urls''' package has camel case tests.

 Fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b9ac8f02941f94019aa3f332ce4a9cf9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by timo):

 Thanks for looking at this. Let's just focus on camel case test names for
 this ticket. We can open a separate one for some of the other issues you
 raised.

 To address some specific questions:
 * admin_filters -- think it's fine to leave as-is.
 * bug* -- yes, let's move them, but as a separate item.
 * dispatch -- probably move them as a separate item.
 * file_uploads -- setUpClass/tearDownClass are fine.
 * model_fields -- I'd remove the existing camel case for field names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.063b57337c9ce5259135dd062fbf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''view_tests/tests/test_i18n''' has camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ffeb8087bec409f784400f907fad1816%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''unit_tests/test_http''' has camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3135b8cb19b987fb2b204d7246b4fd86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''raw_query''' has camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.f72fdae3888f714c4a30fea589ea4c5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''nested_foreign_keys''' has camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.07f8a04669b86aa8036f4e1f2567855c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''model_fields''' contains a function without a camel case for the field
 name: ''test_slugfield_max_length''

 This is inconsistent with other field names in test functions. Should this
 be changed to ''test_SlugField_max_length''?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.aff7b7d298b78b00c22b6c668a3d6168%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''generic_inline_admin''' has camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.53783ac841b00b53e9a2f9f45028f654%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''fixtures_model_package''' has one function named ''testClassFixtures''.
 Should this be renamed?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e076177de45ef187e178e193e174f24e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''fixtures''' has two test functions named ''testClassFixtures''.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.870bf5ba59ab2097a0d1bfe55cbab235%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''file_uploads''' has set up and tear down classes that are named
 ''setUpClass'' and ''tearDownClass''. Should these be renamed to ''setUp''
 and ''tearDown''?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.6bd3a23cb37869d53debdf2fe381a070%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''dispatch''' needs work. Also, the tests were created in a sub-
 directory: ''dispatch/tests/test_dispatcher.py''

 Should the tests be moved up to the ''dispatch'' directory, and possibly
 renamed ''tests.py''?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ad0037fb9e1708ee358aacd04dad6179%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''conditional_processing''' needs cleanup.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d1bd7ad409450a74e52035bd2188b8fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''bug639''' has one camel case test name. Should this test be moved into
 another, more general, test module?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9549794b43395369316cb43f450eb7ef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''admin_widgets''' needs cleanup.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.46e6889acb7203848131e2471343cda0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''admin_views''' has several camel case test names.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.548f32721ccddd278695626ed08804c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 '''admin_filters''' may need consistent spacing in test functions in the
 ''ListFiltersTests'' class. Please review and comment as to whether
 spacing/underscores should be changed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.5abc233e7d581ace443819eb670677be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  brylie
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by brylie):

 * owner:  nobody => brylie
 * status:  new => assigned
 * cc: brylie (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.fcc118a25c9861ed19a2faa10eaf906a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #22909: Fix camelCase test names

2014-06-29 Thread Django
#22909: Fix camelCase test names
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by brylie):

 The '''admin_custom_urls''' package has camel case tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.87e1087fe35c43e341dfc04ab8518e28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #22909: Fix camelCase test names

2014-06-26 Thread Django
#22909: Fix camelCase test names
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Uncategorized |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 In some test files like `tests/admin_widgets/tests.py`, there are tests
 with names like `testDateField` where it should be `test_date_field`. Note
 that it's fine for assertions to be camel cased, so there's no need to
 change things like `assertFormfield`. I have seen this most often in the
 `admin_*` tests, so those would be the main ones to check.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.333baffdfc141aecd9a09b75740e30eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.