Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  Tim Graham   |Owner:  Chris Luc
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"e90c745afdcf89bc3416c9cb2d4a06dfacb2a250" e90c745]:
 {{{
 #!CommitTicketReference repository=""
 revision="e90c745afdcf89bc3416c9cb2d4a06dfacb2a250"
 Refs #22993 -- Removed skipIfCustomUser per deprecation timeline.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.6d16e541cd8ea2e5dec7693cbe8769b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  chrisjluc
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e37d52bd5eb98e6ddf61b766720583481d18bc2b" e37d52b]:
 {{{
 #!CommitTicketReference repository=""
 revision="e37d52bd5eb98e6ddf61b766720583481d18bc2b"
 Fixed #22993 -- Deprecated skipIfCustomUser decorator
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b12938a122a7ce74e611861feb909d59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  chrisjluc
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by claudep):

 * has_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Hi Chris, the `Ready for checkin` flag is only set when someone else has
 reviewed your patch. Just set the `Has patch` flag when your pull request
 is ready.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.39f9ac68b00fc44b50431b6b164ab0b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  chrisjluc
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by chrisjluc):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.11cb14556e08e566067bfbf0b8173864%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  chrisjluc
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by chrisjluc):

 * owner:  nobody => chrisjluc
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.45a6f0867f04d75fb1702f897c55db23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by claudep):

 * easy:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.fd1b8038e4e2df06ac6997ee88189578%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 I don't know of any apps that ship tests that are designed to run as part
 of your project which would be the reason for the decorator. If we remove
 it from Django (after deprecation since it's documented) It's easiest
 enough to copy it into your project if you need it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e1cbeb35e10d6e6c8520a2eeec9d51d4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 Django's auth tests no longer use that decorator. Is the decorator still
 useful for reusable apps developers (then this bug can be closed)? Or do
 we want to remove the decorator from `contrib.auth` (it is currently
 documented)?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.01d7c01059e34c69dc337965ba020f76%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 I'm not quite understanding your argument for why it would be advantageous
 to deprecate for 1.8. I think 1.9 is fine.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.aa1fde0fbc95796b764f9f8cf92f4861%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
--+
 Reporter:  timo  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * stage:  Someday/Maybe => Accepted


Comment:

 Can we still deprecate it in 1.8? That way developers can use it through
 the LTS version and only need to upgrade to the next LTS after 1.8 and we
 can get rid of it in 2.0. If deprecation time for 1.8 is already over,
 let's do it for 1.9. Either way should give users plenty of time to update
 their test suite.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1768ec5b4c2b957495ec3f26db490d9d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.auth |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * stage:  Unreviewed => Someday/Maybe


Comment:

 [https://groups.google.com/d/topic/django-
 developers/ihRZYIcfwVo/discussion django-developers] thread. Consensus
 seems to be that we shouldn't drop it now because of projects that may
 still be using the old test runner.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.629250a29bd6c63ad11bb339692153f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
+
   Reporter:  timo  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.auth  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 With the test discovery changes in 1.6, the tests for `django.contrib`
 apps are no longer run as part of user's project. For this reason I
 believe we no longer need to decorate tests in `contrib.auth` with
 `@skipIfCustomUser`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.ac45080da49605c3d01ada5824bb4f4d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.