Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit |  worksforme
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => worksforme


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.635a572ea9d662ebbcfb42f4f86249e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 This is already documented further in that file: "*At this stage, your
 code shouldn't import any models!*"

 The problem isn't restricted to `my_app/__init__.py`; any model import
 triggered, even indirectly, by `my_app/__init__.py` or `my_app/apps.py`
 will have the same effect.

 This raises a PendingDeprecationWarning, which is silent by default, but
 which you may display by running `python -Wall`. In 1.8 it will raise a
 DeprecationWarning, which is loud by default, and in 1.9 it will raise an
 exception. So the silent failure only happens in 1.7.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.babb0418fe20ea204dac18e94690cd4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by collinanderson):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.716c1481d0f4e753d3e426b3c8ab9677%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by brycecaine):

 Submitted the pull request https://github.com/django/django/pull/3189

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d03a60cacfd9efbbbf82d80a85102f22%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by brycecaine):

 Tested adding the documentation-item locally, which generated this html
 when doing a {{{make html}}}:

 {{{
 
 Warning
 Additionally, avoid importing models in __init__.py; doing
 so leads to
 inconsistent behavior.
 
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b6f1f23d25dc935e2c1af014e15269f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+-
 Reporter:  rafalp   |Owner:
 Type:   |  brycecaine
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.7-rc-2
 Severity:  Normal   |   Resolution:
 Keywords:  afraid-to-commit | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by brycecaine):

 * owner:  nobody => brycecaine
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1ae6d0a248bc42c78387fd0775234b3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
--+
 Reporter:  rafalp|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.7-rc-2
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by evildmp):

 * keywords:   => afraid-to-commit


Comment:

 I've marked this ticket as especially suitable for people following the
 ​'''Don't be afraid to commit tutorial''' at the DjangoCon US 2014
 sprints.

 If you're tackling this ticket, please don't hesitate to ask me for
 guidance if you'd like any, either at the sprints themselves, or here or
 on the Django IRC channels, where I can be found as ''EvilDMP''.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b29cd4002813a1564a83c1a5edc41281%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
--+
 Reporter:  rafalp|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.7-rc-2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * type:  Bug => Cleanup/optimization
 * component:  Migrations => Documentation
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f896946320b4c2884f0b08221c887f07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
+--
 Reporter:  rafalp  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7-rc-2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by c-schmitt):

 Couldn't we just document that? I mean "Don't import Models on
 `__init__.py`, it leaves to inconsistent behavior"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6b8f07c41195d8d150a8e230cb2432a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
+--
 Reporter:  rafalp  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7-rc-2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by andrewgodwin):

 * severity:  Release blocker => Normal


Comment:

 OK, I'm going to demote this from release blocker, as it's a combination
 of two unusual things that there's an easy recovery from (setting
 app_label in the model's Meta field, or just not doing the imports in
 __init__)

 In particular, by importing the models before the app's initialised,
 you're doing something that we've already started down a deprecation path,
 and it's complex enough to fix this bug that it's going to potentially
 cause more problems than it solves for the 1.7 release.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b166bfb4ab4b0510418a7d35c95e1fe3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+--
 Reporter:  rafalp   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.7-rc-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by collinanderson):

 * cc: cmawebsite@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7a7b7457f8cec6f1873d9f13876992dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+--
 Reporter:  rafalp   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.7-rc-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by c-schmitt:

Old description:

> Models that are imported in app's `__init__.py`, or by modules imported
> from that become invisible for Django if app uses apps.py and AppConfig.
>
> To reproduce it create app with basic config and simple model in
> models.py. If this model is imported inside `__init__.py`, or other
> module imported in `__init__.py`, it will become invisible to
> makemigrations.
>
> Tried this both with default_app_config as well as giving full path to
> AppConfig in INSTALLED_APPS.
>
> I'm running latest code from 1.7 branch.
>
> '''EDIT by (c-schmitt):''' This Bug Report only works when you import an
> Model in `__init__.py` and relabel your application in AppConfig.
> I Appended a Test and the user that submitted the bug also has an example
> application on github.

New description:

 Models that are imported in app's `__init__.py`, or by modules imported
 from that become invisible for Django if app uses apps.py and AppConfig.

 To reproduce it create app with basic config and simple model in
 models.py. If this model is imported inside `__init__.py`, or other module
 imported in `__init__.py`, it will become invisible to makemigrations.

 Tried this both with default_app_config as well as giving full path to
 AppConfig in INSTALLED_APPS.

 I'm running latest code from 1.7 branch.

 '''EDIT by (c-schmitt):''' This Bug Report only works when you import an
 Model in `__init__.py` and relabel your application in AppConfig.
 I attached a Test that could be applied to `stable/1.7.x` and the user
 that submitted the bug also has an example application on github.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e0d7d3a6ada581bd9be79c573dd60529%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld (was: Models that are imported on app's import time are invisible to

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+--
 Reporter:  rafalp   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.7-rc-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by c-schmitt:

Old description:

> Models that are imported in app's `__init__.py`, or by modules imported
> from that become invisible for Django if app uses apps.py and AppConfig.
>
> To reproduce it create app with basic config and simple model in
> models.py. If this model is imported inside `__init__.py`, or other
> module imported in `__init__.py`, it will become invisible to
> makemigrations.
>
> Tried this both with default_app_config as well as giving full path to
> AppConfig in INSTALLED_APPS.
>
> I'm running latest code from 1.7 branch.

New description:

 Models that are imported in app's `__init__.py`, or by modules imported
 from that become invisible for Django if app uses apps.py and AppConfig.

 To reproduce it create app with basic config and simple model in
 models.py. If this model is imported inside `__init__.py`, or other module
 imported in `__init__.py`, it will become invisible to makemigrations.

 Tried this both with default_app_config as well as giving full path to
 AppConfig in INSTALLED_APPS.

 I'm running latest code from 1.7 branch.

 EDIT by (c-schmitt): This Bug Report only works when you import an Model
 in `__init__.py` and relabel your application in AppConfig.
 I Appended a Test and the user that submitted the bug also has an example
 application on github.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6ea0e3ca05673e66af0c1a9f0be86485%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23305: Models that are imported on app's import time are invisible to makemigrations when the application is relabeld

[Django]

#23305: Models that are imported on app's import time are invisible to
makemigrations when the application is relabeld
-+--
 Reporter:  rafalp   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.7-rc-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by c-schmitt:

Old description:

> Models that are imported in app's `__init__.py`, or by modules imported
> from that become invisible for Django if app uses apps.py and AppConfig.
>
> To reproduce it create app with basic config and simple model in
> models.py. If this model is imported inside `__init__.py`, or other
> module imported in `__init__.py`, it will become invisible to
> makemigrations.
>
> Tried this both with default_app_config as well as giving full path to
> AppConfig in INSTALLED_APPS.
>
> I'm running latest code from 1.7 branch.
>
> EDIT by (c-schmitt): This Bug Report only works when you import an Model
> in `__init__.py` and relabel your application in AppConfig.
> I Appended a Test and the user that submitted the bug also has an example
> application on github.

New description:

 Models that are imported in app's `__init__.py`, or by modules imported
 from that become invisible for Django if app uses apps.py and AppConfig.

 To reproduce it create app with basic config and simple model in
 models.py. If this model is imported inside `__init__.py`, or other module
 imported in `__init__.py`, it will become invisible to makemigrations.

 Tried this both with default_app_config as well as giving full path to
 AppConfig in INSTALLED_APPS.

 I'm running latest code from 1.7 branch.

 '''EDIT by (c-schmitt):''' This Bug Report only works when you import an
 Model in `__init__.py` and relabel your application in AppConfig.
 I Appended a Test and the user that submitted the bug also has an example
 application on github.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7d2008a9810d839a40d19a03beb70a04%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.