Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"731654197cfbc49296c0d5869aae698b315440e9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="731654197cfbc49296c0d5869aae698b315440e9"
 [1.6.x] Fixed #23307 -- Clarified the way max_num limits the output of
 formsets.

 Thanks velle for the report.

 Backport of 5f3806b861 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6bc741a4e28f7603b4879caa362751d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"813619405b4920c44f455b23ef407c6c66eb5746"]:
 {{{
 #!CommitTicketReference repository=""
 revision="813619405b4920c44f455b23ef407c6c66eb5746"
 [1.7.x] Fixed #23307 -- Clarified the way max_num limits the output of
 formsets.

 Thanks velle for the report.

 Backport of 5f3806b861 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.00b41f1e3354387d261622d5eadc830d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5f3806b8612efca45dba1a75b29ad1bbbc12a7ca"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5f3806b8612efca45dba1a75b29ad1bbbc12a7ca"
 Fixed #23307 -- Clarified the way max_num limits the output of formsets.

 Thanks velle for the report.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ea9b4c242ca268187049a7c8b7e32307%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by collinanderson):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.bf8ad591258065ecc8a26da1db302a1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Octowl):

 Created a pull request at:

 https://github.com/django/django/pull/3187

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.176eeb0e7b1745dcee681f23e74d7e63%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Octowl):

 I am making changes in the following branch:

 https://github.com/Octowl/django/tree/ticket_23307

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c051015882149632ac887fd236622ab5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  Octowl
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Octowl):

 * owner:  nobody => Octowl
 * status:  new => assigned


Comment:

 I'm picking this up at the don't be afraid to commit workshop in the
 djangocon sprints

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.58539f77a790cc11b1497200ba1fb689%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  afraid-to-commit  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by evildmp):

 * keywords:   => afraid-to-commit
 * version:  1.4 => master


Comment:

 I've marked this ticket as especially suitable for people following the
 ​'''Don't be afraid to commit tutorial''' at the DjangoCon US 2014
 sprints.

 If you're tackling this ticket, please don't hesitate to ask me for
 guidance if you'd like any, either at the sprints themselves, or here or
 on the Django IRC channels, where I can be found as ''EvilDMP''.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.06aeb3e82f4efb77a25ac27608932fab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by freakboy3742):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.00826df6394d823e38da3b118b667931%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
-+-
 Reporter:  velle|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by collinanderson):

 * cc: cmawebsite@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.afe1c756b9a6e6e969b5462461762d9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
-+-
 Reporter:  velle|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by collinanderson):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 It's true `max_num` limits the total number of forms, but it also allows
 you (with `extra`) to control the number of blank forms, but I agree it's
 a hair unclear.

 Re `objects`: maybe `rows` or `items`? The example at the top simply uses
 an example `article`, even though it's not a model form.

 Do you a clearer way to word these sentences?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9172292e9fe330e06aa0f4c32b1a4cee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23307: max_num limits total number of forms, not empty forms

[Django]

#23307: max_num limits total number of forms, not empty forms
--+
 Reporter:  velle |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 On: https://docs.djangoproject.com/en/1.6/topics/forms/formsets/

 The documentation says: "The max_num parameter to formset_factory() gives
 you the ability to limit the maximum number of empty forms the formset
 will display".

 I believe max_num limits the total number of forms, not the empty forms,
 or else the rest of the documentation on the page and the example do not
 make sense.

 Also, right after the example they write: "If the value of max_num is
 greater than the number of existing objects, up to extra additional blank
 forms will be added to the formset, so long as the total number of forms
 does not exceed max_num."

 They mention "objects". But if a newcomer to Django is reading the
 documentation on forms from one end to the other, he will not know what is
 meant by objects, when he hasnt yet read about ModelForms. I don't know
 how to deal with this. Maybe the ModelForm section could come before
 FormSet, but I have not thought that through.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.66dcd4735dbfe5e800365a4975d491d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.