Re: [Django] #23560: MigrationWriter prefixes builtin types with __builtins__.

2014-09-26 Thread Django 
#23560: MigrationWriter prefixes builtin types with __builtins__.
+-
 Reporter:  loic|Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Loic Bistuer ):

 In [changeset:"7355885ef504cc34f447311741511018f777667f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7355885ef504cc34f447311741511018f777667f"
 [1.7.x] Fixed #23560 -- Fixed MigrationWrite to handle builtin types
 without imports.

 Thanks Tim Graham for the review.

 Backport of b23d47412c from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.98d56680aa78310dec868cb581013f62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23560: MigrationWriter prefixes builtin types with __builtins__.

2014-09-26 Thread Django 
#23560: MigrationWriter prefixes builtin types with __builtins__.
+-
 Reporter:  loic|Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Loic Bistuer ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b23d47412c12352ba2e2133b05a15ccd09e81af3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b23d47412c12352ba2e2133b05a15ccd09e81af3"
 Fixed #23560 -- Fixed MigrationWrite to handle builtin types without
 imports.

 Thanks Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.58f42f1db67b1f59b67c614eb327b89b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23560: MigrationWriter prefixes builtin types with __builtins__.

2014-09-26 Thread Django 
#23560: MigrationWriter prefixes builtin types with __builtins__.
+-
 Reporter:  loic|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by timgraham):

 * version:  master => 1.7
 * stage:  Unreviewed => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0cfd8d4c7f26c58d39c2e0e99bc40fb0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23560: MigrationWriter prefixes builtin types with __builtins__.

2014-09-26 Thread Django 
#23560: MigrationWriter prefixes builtin types with __builtins__.
+--
 Reporter:  loic|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by loic):

 * has_patch:  0 => 1


Comment:

 PR https://github.com/django/django/pull/3281.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7a1fcb937e0458ce0272b418f3d702fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23560: MigrationWriter prefixes builtin types with __builtins__.

2014-09-26 Thread Django 
#23560: MigrationWriter prefixes builtin types with __builtins__.
--+
   Reporter:  loic|  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Migrations  |Version:  master
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 When MigrationWriter finds a builtin type (i.e. not a builtin type
 instance) it serializes as follows:

 {{{
 import __builtin__
 __builtin__.dict
 }}}

 `__builtin__` isn't needed nor pretty, but worse it was renamed `builtins`
 in PY3 so migrations written in PY2 wouldn't work in PY3 and vice versa.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.6c99ab71e58df56ca1006d6a5cd5ca60%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.