Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
-+-
 Reporter:  nijel|Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.7
  Internationalization   |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by charettes):

 normanjaeckel, please go ahead and open a new release blocker ticket
 referring to this one to make sure we release 1.7.2 with the appropriate
 fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cf0f6e542379692c9b8545224703059d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
-+-
 Reporter:  nijel|Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.7
  Internationalization   |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by normanjaeckel):

 If STATIC_ROOT is None (which is the default), makemessages raises
 AttributeError. This bug was introduced with Django 1.7.1. In Django 1.7
 it is not there.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9fd61f75e545d0f58a3a85f744a88e0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
-+-
 Reporter:  nijel|Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.7
  Internationalization   |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"d5a273eadb00ee3edd7e81d373b7237220b42571"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d5a273eadb00ee3edd7e81d373b7237220b42571"
 [1.7.x] Fixed #23583 -- More selectively ignored static/media roots

 Fixed a regression introduced by 28efafa24c.
 Thanks Michal Čihař for the report and initial patch, and
 Collin Anderson and Tim Graham for the reviews.
 Backport of 8b4cc9df9c from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8582bc5c1f6c681a4f44b879a120a354%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
-+-
 Reporter:  nijel|Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.7
  Internationalization   |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8b4cc9df9c0760eb4896f1423b6119bdad5674c6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8b4cc9df9c0760eb4896f1423b6119bdad5674c6"
 Fixed #23583 -- More selectively ignored static/media roots

 Fixed a regression introduced by 28efafa24c.
 Thanks Michal Čihař for the report and initial patch, and
 Collin Anderson and Tim Graham for the reviews.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2b855237c97d84572fc3ff55fbaadb6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
-+-
 Reporter:  nijel|Owner:  claudep
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  1.7
  Internationalization   |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dd751ecdde0b829230aa17ec51f9bffd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+
 Reporter:  nijel |Owner:  claudep
 Type:  Bug   |   Status:  assigned
Component:  Internationalization  |  Version:  1.7
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * needs_better_patch:  1 => 0


Comment:

 Alternative patch: https://github.com/django/django/pull/3386
 Review welcome (possibly on Windows). This is a candidate for 1.7.1.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.55d6082a0434504339878306200e303d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+
 Reporter:  nijel |Owner:  claudep
 Type:  Bug   |   Status:  assigned
Component:  Internationalization  |  Version:  1.7
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * status:  new => assigned
 * severity:  Normal => Release blocker
 * needs_better_patch:  0 => 1
 * component:  Translations => Internationalization
 * owner:  nobody => claudep
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a732093acb85417e396b3c384253b760%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+--
 Reporter:  nijel |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Translations  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by blodone):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  invalid =>


Old description:

> When using manage.py makemessages -d djangojs, it no longer works (for
> me) as makemessages now completely ignores media and static dirs, what's
> place where javscript is usually stored. This has been introduced as fix
> for issue #23010.

New description:

 makemessages ignores any in-app paths that begin with static because of
 this line:
 
https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L233

 it should ignore something like "/*" but not "*"

 reproducible:
 https://github.com/blodone/django_static_broken

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.28d57df17c54d1e61756d955013b9d97%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+--
 Reporter:  nijel |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Translations  |  Version:  1.7
 Severity:  Normal|   Resolution:  invalid
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by claudep):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 `STATIC_ROOT` is not supposed to point to where your static files are
 located in your source code, but where you deploy them. I think you might
 be misusing the static files framework.
 https://docs.djangoproject.com/en/1.7/ref/settings/#std:setting-
 STATIC_ROOT

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d43898b7e4e92af45d4d9a60cb800bdd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+--
 Reporter:  nijel |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Translations  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by nijel):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request: https://github.com/django/django/pull/3298

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7ce21f7bc6e71313ab4bad6fcc886ba3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23583: makemessages for javascript no longer works

[Django]

#23583: makemessages for javascript no longer works
--+
 Reporter:  nijel |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Translations  |Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+
 When using manage.py makemessages -d djangojs, it no longer works (for me)
 as makemessages now completely ignores media and static dirs, what's place
 where javscript is usually stored. This has been introduced as fix for
 issue #23010.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.26ba2412614967b657f710529685a45c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.